From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63DA242C44; Wed, 7 Jun 2023 00:23:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4604940ED5; Wed, 7 Jun 2023 00:23:32 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2062.outbound.protection.outlook.com [40.107.93.62]) by mails.dpdk.org (Postfix) with ESMTP id 251B7406B6 for ; Wed, 7 Jun 2023 00:23:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VAqUd9iO9wpzc/loOXVhwjyLYiV/zyMuUQTQrfgXMQnDPHvySidTHUv24QyPxMefzUuB2+0W34iCqNAPGX13t11+kcSxdvAHA4vsz+D1O8QnjkD05HrPxLYfqIclEfRFD/Ou8RO6CSmZv2iFK3LFMr8SMVDbAZ8OWtI681Cg0h1BN0rpKf6y9O/QSHT9APxEPSjfzaa0ANBAQWy5s1DniC3lwWr/9jjmfFoFWp3d6uHy+3/IEC6l/Jv+jeFZe9+0SDSzXPORfhW5btlYnI5ZTlZEyoDtaDiBb/I55n5/O29q0xjB7W9Z4t21JyhmxOxGOhsSQka0fGj0lNlUFG6HmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n00UKJLLiR2TbzLKFf5ZMd9MWLSi463K4jXa8bfUUs0=; b=bZkt4Cw16aGT94/ub3yKnjwVbZ4EuTPj7vSoy/0HXoz1QB5zmOI9mN0Dn8mF3fMAI8hcn8TWqvuyCO5UPdxgv4rKpDvTC6z7v+2psHHGBq8GMNhpgvE1hls/YF8sAG2kXoqIDDC9BSNCzc0OrFwhykEZHqfZZhU3t8v18r5Ez8/TNnwWrbrqwhVxTg14me6wT3pj3PCPxYZ4EDV0lESVmQ+CJUy4kchoqSiNKKMcU11ahCzA2FS50EYNUj/GNCrdCmR74lUlHxDQMAUebtyE/mVK5G0RIuRYcQG6fYacI2D//Lo5Qo9t0xssVNkt56pqVQBW8xLlkEzYgBhUusD3QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n00UKJLLiR2TbzLKFf5ZMd9MWLSi463K4jXa8bfUUs0=; b=a9Lu8wicuf17mU6K3YBsbGwm+N2t4PYJsbd4NABfiiHIM4zZAiziEkOs7vDU/pJbWsVnz5v1sM11ZZ6ZlU+gCc3Rj2rSyRA8/pcNxyjdRoNVRV+nGhiwLxKDSrjtyykY2N4uIJqO3nNAf7COmlHUgTZhDAnapdg+2hDPmbHzc4I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6012.namprd12.prod.outlook.com (2603:10b6:8:6c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Tue, 6 Jun 2023 22:23:29 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::cf07:30f7:a92a:c53b]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::cf07:30f7:a92a:c53b%4]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 22:23:29 +0000 Message-ID: Date: Tue, 6 Jun 2023 23:23:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Mike Pattrick , Aman Singh , Yuying Zhang Cc: ktraynor@redhat.com, dev@dpdk.org References: <20230602182928.1717802-1-mkp@redhat.com> <20230606211242.2855795-1-mkp@redhat.com> From: Ferruh Yigit Subject: Re: [PATCH v5] app/testpmd: expand noisy neighbour forward mode support In-Reply-To: <20230606211242.2855795-1-mkp@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0011.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6012:EE_ X-MS-Office365-Filtering-Correlation-Id: 8fa0d6eb-3812-487e-336c-08db66dca734 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tnLqsqGYq/ZLwqb8AxSlKyqFPM6QCdw7U4JbojJz9TO5n2Hn9Stc8hIJOzh+ua0BxDCu8UBlEuEYeDCPzNwg97yaGdh2CltjcWYWML//e2ZWGsIFQ/1gqC5Y8Ya4uNPur7giv3rNW9lxx1XOT8OvmwdGKFwCW+qHmkNX7ePz/T9L3LszOSB7JIzoWDsJ1wovPUL/baGGM3MN/P+MjjrUW4WXfbCgeu3DwNASi5pCvPGOZEkLhABVwMJIJw1Ek/3bozuoD5ci6SFaIEhVkG5lwkXqZjj3mY+aMMkfQJF63mMJ9MA7FBZdFBBFURFZjcDiiNowqwSwq1eIb9QSI6qy/Ur50/nLbxez8MZorr7SdB0zmabvSSTbC3jCbZZqSG6zYT5aZyBaQUdy1oqO0CrTn6KslmdjsZBo+J3Zb/ZK9kPcp+SIXqHq0BPVJjdupcIHATzLr/X52Dnl9cwDTQ5l7+uhtqBTaz3ZNiClGrYrpG350DsvzNsLiZO3EvY03eMKJ26aCXCSyRZ0tuN4IiP1SBiObO+CAoxrff7+jYTyBQ2wMOETDb/wF0qIP2mXHU3shH7G8Y4FOPtP2Ey2EWptYKxHKep8p9+W2PwQMY1RolkOogUlRyCJMi/17JPTvR/ZLDDWLYdhDZNg9/y0CF1lFQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(451199021)(110136005)(45080400002)(478600001)(8936002)(8676002)(5660300002)(44832011)(4326008)(31696002)(2906002)(36756003)(86362001)(66476007)(66556008)(66946007)(316002)(6506007)(38100700002)(41300700001)(2616005)(53546011)(6512007)(186003)(26005)(83380400001)(6486002)(31686004)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkN5YXZnVm16KzFoZ3prbEN2U3M2UkR2RWRycm1wOWdUTEtWdFpHRi9Tc2k1?= =?utf-8?B?UzhHSXJwK2lCMFZmdXB0STFPRWwycU1qMTNOVlpEbFVVSUZibis4VENpVmM5?= =?utf-8?B?bmwyODZWOEorWERZMm5zdkJHVVZVTkpmZXgzbEtrNXRsNXZWRnVncmh1QTRP?= =?utf-8?B?bkFGM2VONmZYSnFoMDlHaTRWTTFwRFk4T2Rybk1zdlhvSnJtSVVMTkdTbFcx?= =?utf-8?B?akxsbXVOd2VaM1dZUmNuRDdJck1URjNpTE9MbWpPdWlYTmdibDgzUzQ5enhW?= =?utf-8?B?TGpuK3BDRkl6TCtHREVmVzRCazQ4M2dNbllpdXR6bUdtMXdkL284MTRSSVJo?= =?utf-8?B?MlI3M0hIUHZJaDF1N3VyajArQmgrZU1ZZU5vM013eTY3RTVnb05yc0EzaWcr?= =?utf-8?B?S0I0L3h4eHVvUVVCTE8zY2FoazBUYm5tVE5WbXYydnVxOHZTUVVwUjUwSml0?= =?utf-8?B?cjQrMnByR0pSSGZDaXpYT045ZW55Sk5Kd2N5UWVaZXFPWlBCc0NVYVZXK0Rm?= =?utf-8?B?OVB1SnZKQUV2MThicnh0VWVNMzRienhKRkluNG9FL1NzcGVpSmczZmkvdm80?= =?utf-8?B?UjFIeTlNYXRnalkvZDhHQVIwY2p2SEl0UGhBU0pMOEtBaHlRZk81UXlxTDNh?= =?utf-8?B?WXRNckh4TExDS3FwSHhEVUh4TlBZanRRWXBRdEJBaHd4UFRXT0ZVYlRSL1RW?= =?utf-8?B?QVJMRHkzV1F0YXphTS9kWWZJWDU3ZmRmNTVnU216cXZMcjlHOWNlR3hEQXRZ?= =?utf-8?B?NnFVOG5COGpmTmlnU2tvciszZ3ltbWtwb1VSQUpsVDVsRTBtUXM0SHRmbHNn?= =?utf-8?B?MHllVFBTVHBnOFZKMWRGR2RNc1FWK2Rvc3R0M041eEVWazErMys3TFRKUWR6?= =?utf-8?B?Y0xnbnRyTnFZcG9ZUERVNEFTVGFsVFFrMDRPTG02S2lxRWwyKzJ3TVkxTHpB?= =?utf-8?B?c2RrbGdvR3dDTVNFZVM2d0ZLZHA1WTBqTHlxS2FsbktPTlA4VWtaL3lWSTQr?= =?utf-8?B?NWJKMDVkTXcyR3AyVkFpWkgxUDkzNG0vWVNCcVE5dVZmaHprZmFjWjdpbkpU?= =?utf-8?B?Y2xiS0FRak4wQzNHMS9oYkVRMVRRWnNpOXpqSmViYjRmbDB0UjVZU21iRkhJ?= =?utf-8?B?MWQ5STVPU1FVcmFvU0RCejRrNmdveFVMT3lQM0tlRGNrdk9jK1NLZlQ3QTd3?= =?utf-8?B?SXVlSjNmYkhhRU5SVVpFTUtjVVptL0MrYmozbWVCM204NVVQdENCVTZOQ2ZR?= =?utf-8?B?M1hMZkh2ZDN5VEJOR0NtU1JnaGt2U201ZVFLdGxGWVIzanlxL1F0Q0xKZFFB?= =?utf-8?B?M2hYUlV1Y3d3eTN0RVlVbmxCeEZZaVBvaUlhZi8zTHZnY2htVWUxNERQQ0ZT?= =?utf-8?B?Smw3YnpTOFQvZnNKQ1ZZWFVoajZ2M0pTekFQbGR3c0tHRnMrWWwwd1BpNWpB?= =?utf-8?B?MTRsd2x2T1JGRFJTYzR2aUJ6bHFVR3lGWVoxUlJSN0FUYjhTTnQ3eGxFRXRt?= =?utf-8?B?Y1duZTlhQzZUa3dkN24zT2lMMk41WGpLalFCbTNGTFhYUlNDOWdYL1VCUExw?= =?utf-8?B?RlhGaVJ1QlpnRTAxUVB5WjF0TXFQQTRSYVpxZ2NKblJwVnJ5ZFB4YTg1Y1Rh?= =?utf-8?B?WUhZRk0rcDQyZk53SXBRbXFDVjBVY2l2cjkzT0E4cUtWaHk2MkVnZ2F6S0N1?= =?utf-8?B?M2lCMHFDLzhxcUROUU9GSkw2Tm9ieEd1bFJpN3dzUllQTnRlL1FpVXhiTHhZ?= =?utf-8?B?ZVRVUlFGS2dZTm5GRlJ0bTJUNnhOZVJWNHJCWk9TSmlQaUhRdVJVOUk2L3M4?= =?utf-8?B?Z0VTU1phTjFVeGxrbjBIVTRiSy8xejdXN2ZOOWYxWFRZSVZOdFVVQldMc1VR?= =?utf-8?B?K0NiSWNoWjlKb1NYSjg1YUxES2tzVGRBZVYxdUg3YXdQTldKTGJWbzZKbVE3?= =?utf-8?B?azlqQU0xWXpBZU9ubTFsY2s0Z1pFRm5aZE1JQ1JPWDNYY0REbmdQNStqdnpw?= =?utf-8?B?VzBSTGlQS2pYK0Jad0V6c3crdjhWQVQ3akNzb2g3K3BXMkI3NmNNQ09sZ1A0?= =?utf-8?B?NG90Q1lJK25zdzYzTFpxa240WTNqREh2blp5V0VGanpTNjlNOVZOZ1gzUU95?= =?utf-8?Q?v+R3Hwd6wag0Lwaubn3iTrjd2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fa0d6eb-3812-487e-336c-08db66dca734 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 22:23:28.9363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s4cNf/xEe23uU70yOOQDVNZA5wSr/clSYq40BlkdQi+CMHhepRq7vzPHPQQzxza9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6012 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/6/2023 10:12 PM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswap modes. To facilitate adding this support, some new header files > were added. > > Signed-off-by: Mike Pattrick > --- > v2: Reverted changes to random memory lookup > v3: Refactored entire patch > v4: Implemented recommended formatting changes > v5: Corrected copyright statement and formatting changes <...> > @@ -226,6 +291,15 @@ noisy_fwd_begin(portid_t pi) > "--noisy-lkup-memory-size must be > 0\n"); > } > > + if (noisy_fwd_mode == NOISY_FWD_MODE_IO) > + noisy_vnf_engine.packet_fwd = pkt_burst_io; > + else if (noisy_fwd_mode == NOISY_FWD_MODE_MAC) > + noisy_vnf_engine.packet_fwd = pkt_burst_mac; > + else if (noisy_fwd_mode == NOISY_FWD_MODE_MACSWAP) > + noisy_vnf_engine.packet_fwd = pkt_burst_macswap; > + else if (noisy_fwd_mode == NOISY_FWD_MODE_5TSWAP) > + noisy_vnf_engine.packet_fwd = pkt_brust_5tswap; > + When noisy forward mode is set, it is not possbile to see what mode is set, what about keeping '.fwd_mode_name' longer, like "noisy - ", and update it based on selected mode? This way "show config fwd" command displays selected noisy mode. > return 0; > } > > @@ -233,6 +307,6 @@ struct fwd_engine noisy_vnf_engine = { > .fwd_mode_name = "noisy", > .port_fwd_begin = noisy_fwd_begin, > .port_fwd_end = noisy_fwd_end, > - .stream_init = common_fwd_stream_init, > - .packet_fwd = pkt_burst_noisy_vnf, > + .stream_init = common_fwd_stream_init, > + .packet_fwd = pkt_burst_io, > }; > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > index 3b37809baf..d29c65fef4 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -190,6 +190,7 @@ usage(char* progname) > " anon: use regular DPDK memory to create and anonymous memory to populate mempool\n" > " xmem: use anonymous memory to create and populate mempool\n" > " xmemhuge: use anonymous hugepage memory to create and populate mempool\n"); > + printf(" --noisy-fwd-mode=: set the sub-fwd mode, defaults to io\n"); Main forwarding parameter is '--forward-mode=N', and while testing I searched for 'forward' in the testpmd help output but not able to find this command, because of shortened 'fwd'. What do you think to have full '--noisy-forward-mode' to be more consistent with existing '--forward-mode=N'? > printf(" --noisy-tx-sw-buffer-size=N: size of FIFO buffer\n"); > printf(" --noisy-tx-sw-buffer-flushtime=N: flush FIFO after N ms\n"); > printf(" --noisy-lkup-memory=N: allocate N MB of VNF memory\n"); > @@ -704,6 +705,7 @@ launch_args_parse(int argc, char** argv) > { "noisy-lkup-num-writes", 1, 0, 0 }, > { "noisy-lkup-num-reads", 1, 0, 0 }, > { "noisy-lkup-num-reads-writes", 1, 0, 0 }, > + { "noisy-fwd-mode", 1, 0, 0 }, If there will be a new version can you please move it to the top of the noisy-* block, as done in the help string? And this is same for all new code, from 'extern' to global variable to .rst documentation update.