From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D18EAA00C4; Sat, 29 Oct 2022 16:48:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 711CD40694; Sat, 29 Oct 2022 16:48:24 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0833540146 for ; Sat, 29 Oct 2022 16:48:23 +0200 (CEST) Received: from [192.168.1.39] (unknown [188.170.73.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 336C75A; Sat, 29 Oct 2022 17:48:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 336C75A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1667054902; bh=RW+iVjOdjruiLHVy6LwwvHleTJAZtm0Jk7Kvn9x79K8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iz91KtzHNW8r3QIRMv6/tvd9GyggmX/kKdChocvhGPpC+44zxBl2Sg76EKGgpfNjk L21T2licdrjQ6jnm/oLTkY9JIP19HP97raUCWBmn/8xFCdN8BE6JylSPNT1VWnm0D4 A8pCMeQ2LxQQvU83K3RycBA2rc5es+q5nq9nxgiA= Message-ID: Date: Sat, 29 Oct 2022 17:48:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v15 00/18] add support for idpf PMD in DPDK Content-Language: en-US To: beilei.xing@intel.com, jingjing.wu@intel.com Cc: dev@dpdk.org, Thomas Monjalon References: <20221027074729.1494529-1-junfeng.guo@intel.com> <20221029032729.22772-1-beilei.xing@intel.com> From: Andrew Rybchenko In-Reply-To: <20221029032729.22772-1-beilei.xing@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/29/22 06:27, beilei.xing@intel.com wrote: > From: Beilei Xing > > This patchset introduced the idpf (Infrastructure Data Path Function) PMD in DPDK for Intel® IPU E2000 (Device ID: 0x1452). > The Intel® IPU E2000 targets to deliver high performance under real workloads with security and isolation. > Please refer to > https://www.intel.com/content/www/us/en/products/network-io/infrastructure-processing-units/asic/e2000-asic.html > for more information. > > Linux upstream is still ongoing, previous work refers to https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220128001009.721392-20-alan.brady@intel.com/. > > v2-v4: > fixed some coding style issues and did some refactors. > > v5: > fixed typo. > > v6-v9: > fixed build errors and coding style issues. > > v11: > - move shared code to common/idpf/base > - Create one vport if there's no vport devargs > - Refactor if conditions according to coding style > - Refactor virtual channel return values > - Refine dev_stop function > - Refine RSS lut/key > - Fix build error > > v12: > - Refine dev_configure > - Fix coding style according to the comments > - Re-order patch > - Romove dev_supported_ptypes_get > > v13: > - refine dev_start/stop and queue_start/stop > - fix timestamp offload > > v14: > - fix wrong position for rte_validate_tx_offload > > v15: > - refine the return value for ethdev ops. > - removce forward static declarations. > - refine get caps. > - fix lock/unlock handling. Applied to dpdk-next-net/main, thanks. I've a number of concerns: * conditional compilation IDPF_RX_PTYPE_OFFLOAD in [PATCH v15 17/18] net/idpf: add AVX512 data path for single queue model * the same prefix used for functions in common/idpf/base and net/idpf drivers * common/idpf/base uses own defines for negative errno (defined as a number with corresponding errno in a comment). Strictly speaking it is not the same, but work fine in a majority of cases So, final decision will be done by Thomas on pulling to main tree.