From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 117ED7CE1 for ; Mon, 29 May 2017 14:40:59 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2017 05:40:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,414,1491289200"; d="scan'208";a="92568333" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 29 May 2017 05:40:58 -0700 To: Matej Vido , dev@dpdk.org References: <1495821956-5050-1-git-send-email-vido@cesnet.cz> From: Ferruh Yigit Message-ID: Date: Mon, 29 May 2017 13:40:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1495821956-5050-1-git-send-email-vido@cesnet.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/5] net/szedata2: refactor ibuf and obuf names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2017 12:41:00 -0000 On 5/26/2017 7:05 PM, Matej Vido wrote: > Signed-off-by: Matej Vido Hi Matej, Overall patchset looks good to me, but can you please provide a little more information in commit logs, please check comments on patches. For this patch, it seems refactor naming is removing "cgmii", what is the reason of this, is cgmii no more true or adding different interface? Thanks, ferruh > --- > drivers/net/szedata2/rte_eth_szedata2.c | 80 +++++++++++++++--------------- > drivers/net/szedata2/rte_eth_szedata2.h | 48 +++++++++--------- > 2 files changed, 64 insertions(+), 64 deletions(-) <...>