From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id ED8973777; Fri, 20 Jan 2017 19:43:17 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2017 10:43:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,259,1477983600"; d="scan'208";a="924873787" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga003.jf.intel.com with ESMTP; 20 Jan 2017 10:43:15 -0800 To: Adrien Mazarguil , Yongseok Koh References: <20170118005155.20192-1-yskoh@mellanox.com> <20170120165647.GL3779@6wind.com> Cc: dev@dpdk.org, stable@dpdk.org From: Ferruh Yigit Message-ID: Date: Fri, 20 Jan 2017 18:43:15 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170120165647.GL3779@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix queue wrap-around of multi-packet send X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 18:43:18 -0000 On 1/20/2017 4:56 PM, Adrien Mazarguil wrote: > On Tue, Jan 17, 2017 at 04:51:55PM -0800, Yongseok Koh wrote: >> When the WQ is wrapped around, it wrongly checks the condition when >> resetting the pointer. It should be compared against the end of the queue, >> not the beginning of the queue. And this isn't even needed when the length >> of the copying data crosses the boundary. >> >> Fixes: e5291c280c08 ("net/mlx5: use work queue buffer as a raw buffer") >> >> CC: stable@dpdk.org >> Signed-off-by: Yongseok Koh >> --- >> drivers/net/mlx5/mlx5_rxtx.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) > > Thanks for addressing this issue. > > Acked-by: Adrien Mazarguil Fixes: fdcb0f53053b ("net/mlx5: use work queue buffer as a raw buffer") Applied to dpdk-next-net/master, thanks.