From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D451CA00C3; Mon, 3 Oct 2022 15:58:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DEFA40DFB; Mon, 3 Oct 2022 15:58:38 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 1992340695 for ; Mon, 3 Oct 2022 15:58:37 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7EB1E66; Mon, 3 Oct 2022 16:58:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7EB1E66 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1664805516; bh=bFvw6RtlRvgMOp11BCBLGeM53YCYh3ObDGVQOiD6UjQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=o6TtqBQwgQ/+3BLIDVnT3cnCJ/GeqBjhkeUeYMstkP2xxzKQmWHDAKTYDeEVrq0I2 anxXGa+Qw1b6Z/gKv5DQmweg2XKdcqfZK3et7RPHHMEG+kacgnAS4qZsENJ57eUkyc ZciEz3pA8+j5r7ObQJ+sSO6PSTXkX9Dt2YNcihSw= Message-ID: Date: Mon, 3 Oct 2022 16:58:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 06/14] net/idpf: add support for packet type get Content-Language: en-US To: Junfeng Guo , qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, xiao.w.wang@intel.com, Wenjun Wu References: <20220803113104.1184059-1-junfeng.guo@intel.com> <20220905105828.3190335-1-junfeng.guo@intel.com> <20220905105828.3190335-7-junfeng.guo@intel.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20220905105828.3190335-7-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/5/22 13:58, Junfeng Guo wrote: > Add dev ops dev_supported_ptypes_get. > > Signed-off-by: Beilei Xing > Signed-off-by: Wenjun Wu > Signed-off-by: Junfeng Guo [snip] > diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c > index fe044a80c9..1c5c4688cc 100644 > --- a/drivers/net/idpf/idpf_rxtx.c > +++ b/drivers/net/idpf/idpf_rxtx.c > @@ -8,6 +8,25 @@ > #include "idpf_ethdev.h" > #include "idpf_rxtx.h" > > +const uint32_t * > +idpf_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused) > +{ > + static const uint32_t ptypes[] = { > + RTE_PTYPE_L2_ETHER, > + RTE_PTYPE_L3_IPV4_EXT_UNKNOWN, > + RTE_PTYPE_L3_IPV6_EXT_UNKNOWN, > + RTE_PTYPE_L4_FRAG, > + RTE_PTYPE_L4_NONFRAG, > + RTE_PTYPE_L4_UDP, > + RTE_PTYPE_L4_TCP, > + RTE_PTYPE_L4_SCTP, > + RTE_PTYPE_L4_ICMP, > + RTE_PTYPE_UNKNOWN > + }; How am I supported to verify that these packet types are really recognized by the driver? The patch should include the part of Rx burst callback which does recognition and fill in corresponding data in mbuf. > + > + return ptypes; > +} > + > static inline int > check_rx_thresh(uint16_t nb_desc, uint16_t thresh) > {