From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D32D542C57; Thu, 8 Jun 2023 04:01:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 636A3410D3; Thu, 8 Jun 2023 04:01:34 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id EAF3840042 for ; Thu, 8 Jun 2023 04:01:32 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Qc6pp0pbhz25h80; Thu, 8 Jun 2023 09:59:46 +0800 (CST) Received: from [10.67.103.42] (10.67.103.42) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 8 Jun 2023 10:01:29 +0800 Message-ID: Date: Thu, 8 Jun 2023 10:01:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 00/13] support telemetry query ethdev info To: Ferruh Yigit CC: , References: <20230530090510.56812-1-haijie1@huawei.com> <20230607074209.4798-1-haijie1@huawei.com> <713d8df2-7aa8-7929-a541-2df03db5cbe5@amd.com> From: Jie Hai In-Reply-To: <713d8df2-7aa8-7929-a541-2df03db5cbe5@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.42] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/6/7 19:40, Ferruh Yigit wrote: > On 6/7/2023 8:41 AM, Jie Hai wrote: >> This patchset supports querying information about ethdev. >> The information includes MAC addresses, RxTx offload, flow ctrl, >> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc. >> >> v1->v2: >> 1. Fix incorrect argument of calloc. >> 2. Extract telemetry codes to a file. >> 3. Extract codes parsing port id as a function. >> 4. Use malloc instead of rte_malloc. >> 5. Fix codecheck warnings and build errors reported by CI. >> 6. Use 'int' instead of 'unsigned' in help info. >> >> Dengdui Huang (1): >> ethdev: support telemetry query MAC addresses >> >> Jie Hai (12): >> ethdev: fix incorrect argument of calloc >> ethdev: extract telemetry codes to a file >> ethdev: extract codes parsing port ID as a function >> ethdev: support RxTx offload display >> ethdev: support telemetry query flow ctrl info >> ethdev: support telemetry query Rx queue info >> ethdev: support telemetry query Tx queue info >> ethdev: add firmware version in telemetry info command >> ethdev: support telemetry query DCB info >> ethdev: support telemetry query RSS info >> ethdev: support telemetry query FEC info >> ethdev: support telemetry query VLAN info >> > > For series, > Acked-by: Ferruh Yigit > > > There are minor comments, applied them while merging set. > > Series applied to dpdk-next-net/main, thanks. > . Hi Ferruh Thank you for your valuable comments on the entire patch group. Thanks, Jie Hai