DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>,
	dev@dpdk.org, gakhil@marvell.com
Cc: trix@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com,
	hemant.agrawal@nxp.com, david.marchand@redhat.com,
	stephen@networkplumber.org, hernan.vargas@intel.com
Subject: Re: [PATCH v12 16/16] test-bbdev: unit test capability extension
Date: Thu, 13 Oct 2022 10:56:36 +0200	[thread overview]
Message-ID: <b8c614c8-f378-accc-a412-4318cfa83ff3@redhat.com> (raw)
In-Reply-To: <20221012175930.7560-17-nicolas.chautru@intel.com>

Hi Nicolas,

I think the title should mention FFT.

On 10/12/22 19:59, Nicolas Chautru wrote:
> From: Nic Chautru <nicolas.chautru@intel.com>
> 
> Added support for bbdev level unit test
> for the FFT operations and for Soft-Output options.
> Also added 2 small test vectors for the FFT operation.
> 
> Signed-off-by: Nic Chautru <nicolas.chautru@intel.com>
> ---
>   app/test-bbdev/test_bbdev_perf.c            | 540 +++++++++++++++++++-
>   app/test-bbdev/test_bbdev_vector.c          | 182 +++++++
>   app/test-bbdev/test_bbdev_vector.h          |   1 +
>   app/test-bbdev/test_vectors/fft_150.data    | 474 +++++++++++++++++
>   app/test-bbdev/test_vectors/fft_byp_28.data | 102 ++++
>   5 files changed, 1282 insertions(+), 17 deletions(-)
>   create mode 100644 app/test-bbdev/test_vectors/fft_150.data
>   create mode 100644 app/test-bbdev/test_vectors/fft_byp_28.data
> 

Also, maybe worth adding this FFT extension to the release note.

Other than that, it looks good to me:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


      reply	other threads:[~2022-10-13  8:56 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 17:59 [PATCH v12 00/16] bbdev ACC200 PMD Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 01/16] baseband/acc100: remove unused registers Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 02/16] baseband/acc100: refactor to segregate common code Nicolas Chautru
2023-11-16 17:25   ` David Marchand
2022-10-12 17:59 ` [PATCH v12 03/16] baseband/acc: rename directory from acc100 to acc Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 Nicolas Chautru
2022-10-13  9:11   ` [EXT] " Akhil Goyal
2022-10-30 16:02   ` Thomas Monjalon
2022-10-31 15:43     ` Chautru, Nicolas
2022-10-31 15:53       ` Thomas Monjalon
2022-10-31 21:41         ` Chautru, Nicolas
2022-11-07 23:52           ` Chautru, Nicolas
2022-11-08  8:56             ` Thomas Monjalon
2022-11-08 23:47               ` Chautru, Nicolas
2023-10-24  7:22         ` Chautru, Nicolas
2022-10-12 17:59 ` [PATCH v12 05/16] baseband/acc: add HW register definitions " Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 06/16] baseband/acc: add info get function " Nicolas Chautru
2022-10-12 20:13   ` [EXT] " Akhil Goyal
2022-10-12 21:33     ` Chautru, Nicolas
2022-10-12 20:19   ` Akhil Goyal
2022-10-12 17:59 ` [PATCH v12 07/16] baseband/acc: add queue configuration " Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 08/16] baseband/acc: add LDPC processing functions Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 09/16] baseband/acc: add LTE " Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 10/16] baseband/acc: add support for FFT operations Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 11/16] baseband/acc: support interrupt Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 12/16] baseband/acc: add device status and vf2pf comms Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 13/16] baseband/acc: add PF configure companion function Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 14/16] baseband/acc: simplify meson dependency Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 15/16] baseband/acc: add helper function for descriptor index Nicolas Chautru
2022-10-12 17:59 ` [PATCH v12 16/16] test-bbdev: unit test capability extension Nicolas Chautru
2022-10-13  8:56   ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8c614c8-f378-accc-a412-4318cfa83ff3@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hernan.vargas@intel.com \
    --cc=mdr@ashroe.eu \
    --cc=nicolas.chautru@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).