From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12A59A00C2; Thu, 13 Oct 2022 10:56:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C21FB42D90; Thu, 13 Oct 2022 10:56:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0F4CB40C35 for ; Thu, 13 Oct 2022 10:56:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665651406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OPwKmb331e6AEOel6hA/cyP0Ql4nY2J996fkIgUrKAs=; b=eH9J0+BdDT0fjk/2aaspRTuPle8b96XdawouOd9PkLOEdFmTWWLweeCgd8TxZYS7hBpfVG HUW3IKBKrCP3nyz3NBw/zz9wwQMcDTAXgsWczj70rzyDV1+fnyAJBsSVY2k24eWvHa/dbt Uej0spsuhZkHaqnY6FVoMEwaodatXJQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-505-8Em49e2dPBiAywBqvb3xcg-1; Thu, 13 Oct 2022 04:56:40 -0400 X-MC-Unique: 8Em49e2dPBiAywBqvb3xcg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6276C185A792; Thu, 13 Oct 2022 08:56:40 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DFC41415108; Thu, 13 Oct 2022 08:56:38 +0000 (UTC) Message-ID: Date: Thu, 13 Oct 2022 10:56:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com Cc: trix@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com, hemant.agrawal@nxp.com, david.marchand@redhat.com, stephen@networkplumber.org, hernan.vargas@intel.com References: <20221012175930.7560-1-nicolas.chautru@intel.com> <20221012175930.7560-17-nicolas.chautru@intel.com> From: Maxime Coquelin Subject: Re: [PATCH v12 16/16] test-bbdev: unit test capability extension In-Reply-To: <20221012175930.7560-17-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Nicolas, I think the title should mention FFT. On 10/12/22 19:59, Nicolas Chautru wrote: > From: Nic Chautru > > Added support for bbdev level unit test > for the FFT operations and for Soft-Output options. > Also added 2 small test vectors for the FFT operation. > > Signed-off-by: Nic Chautru > --- > app/test-bbdev/test_bbdev_perf.c | 540 +++++++++++++++++++- > app/test-bbdev/test_bbdev_vector.c | 182 +++++++ > app/test-bbdev/test_bbdev_vector.h | 1 + > app/test-bbdev/test_vectors/fft_150.data | 474 +++++++++++++++++ > app/test-bbdev/test_vectors/fft_byp_28.data | 102 ++++ > 5 files changed, 1282 insertions(+), 17 deletions(-) > create mode 100644 app/test-bbdev/test_vectors/fft_150.data > create mode 100644 app/test-bbdev/test_vectors/fft_byp_28.data > Also, maybe worth adding this FFT extension to the release note. Other than that, it looks good to me: Reviewed-by: Maxime Coquelin Thanks, Maxime