From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Cc: Megha Ajmera <megha.ajmera@intel.com>, <dev@dpdk.org>,
<sham.singh.thakur@intel.com>, <john.mcnamara@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: more than 64 lcores not properly supported
Date: Wed, 23 Feb 2022 11:20:32 +0000 [thread overview]
Message-ID: <b8d60dc6-8a03-7d1e-d368-cc92c9b4e88c@intel.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86EE5@smartserver.smartshare.dk>
On 2/23/2022 10:42 AM, Morten Brørup wrote:
> +Thomas, you may be interested in this discussion about applications using an uint64_t bit mask to identify active lcores.
>
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Wednesday, 23 February 2022 11.03
>>
>> On 2/23/2022 7:17 AM, Morten Brørup wrote:
>>>> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
>>>> Sent: Tuesday, 22 February 2022 17.03
>
> [...]
>
>>>>
>>>> DPDK now supports > 64 lcores. So all code using/assuming a 64 bit
>> mask
>>>> is broken.
>>>>
>>>
>>> Good point. Is there a TODO-list where such a general review request
>> can be filed, or should we just file it as a system-wide bug in
>> Bugzilla?
>>>
>>> Nonetheless, I think this one-line fix should be accepted as a short
>> term solution.
>>>
>>
>> Hi Morten,
>>
>> I suspect there can be more places that testpmd assumes
>> max core number is 64, someone needs to spend time to
>> analyze and fix it.
>
> My point exactly. Someone needs to spend time to analyze all DPDK libraries and applications, and fix it where appropriate. Where do we register this required effort, so it can be picked up by someone?
>
testpmd is an application and it has its own restrictions,
I *assumed* libraries are safe and restriction is only in
testpmd, but may be better to verify this as well.
> Also, it should probably be mentioned as a known bug in the 22.03 release notes.
>
next prev parent reply other threads:[~2022-02-23 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 13:18 [PATCH] sched: fix integer handling issue Megha Ajmera
2022-02-22 14:13 ` Morten Brørup
2022-02-22 16:03 ` Stephen Hemminger
2022-02-22 18:55 ` Ajmera, Megha
2022-02-23 7:17 ` Morten Brørup
2022-02-23 10:03 ` Ferruh Yigit
2022-02-23 10:42 ` more than 64 lcores not properly supported Morten Brørup
2022-02-23 11:20 ` Ferruh Yigit [this message]
2022-02-23 13:49 ` Thomas Monjalon
2022-02-23 15:12 ` Stephen Hemminger
2022-02-23 17:36 ` [PATCH v2] sched: fix integer handling issue Megha Ajmera
2022-02-23 18:13 ` Morten Brørup
2022-02-24 22:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8d60dc6-8a03-7d1e-d368-cc92c9b4e88c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=mb@smartsharesystems.com \
--cc=megha.ajmera@intel.com \
--cc=sham.singh.thakur@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).