From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DBD8641C95;
	Tue, 14 Feb 2023 14:41:28 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CC91342DAE;
	Tue, 14 Feb 2023 14:41:28 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id E8747410D1;
 Tue, 14 Feb 2023 14:41:26 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 8FDC767;
 Tue, 14 Feb 2023 16:41:26 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8FDC767
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1676382086;
 bh=Nv8HJM4kYauq2DOPbkeQ9X3p3i5FT/igB0YgQzur8z0=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=oldw3qZB5lHeGRIAaFpqL51XvFAmZIK+6oDRvHBDX32VGNjeq6xg1QQeqIzL97oK6
 5V3c3EHqEHq8GguBEDg8UvqHqCOn9JUOn9czjy/A2MVU9kG5qlaqzveZ08lAMJN/lN
 BZW5qSg5njAjb4S8lEHVbRbhF3SH5VOW99Kw0ojs=
Message-ID: <b8d747de-d749-71e6-6507-007767e892a8@oktetlabs.ru>
Date: Tue, 14 Feb 2023 16:41:26 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] net/sfc: fix MAC address entry leak in transfer flow
 parsing
Content-Language: en-US
To: Ivan Malov <ivan.malov@arknetworks.am>, dev@dpdk.org
Cc: stable@dpdk.org,
 Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,
 Andy Moreton <amoreton@xilinx.com>
References: <20230214130659.6971-1-ivan.malov@arknetworks.am>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20230214130659.6971-1-ivan.malov@arknetworks.am>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2/14/23 16:06, Ivan Malov wrote:
> When the action parsing helper discovers it can "attach" to
> an existing action set, it must invoke "delete" on the MAC
> address(es) that it has "attached" to during parsing. That
> is because the action set itself (i.e. not the flow rule
> entry) holds a reference of the address(es).
> 
> Fixes: 4c6005999e41 ("net/sfc: support MAC address edits in transfer flows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
> Reviewed-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>