From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1EA45A0032;
	Mon, 15 Nov 2021 18:32:30 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0254441156;
	Mon, 15 Nov 2021 18:32:30 +0100 (CET)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by mails.dpdk.org (Postfix) with ESMTP id 2824040E25
 for <dev@dpdk.org>; Mon, 15 Nov 2021 18:32:27 +0100 (CET)
X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="296917274"
X-IronPort-AV: E=Sophos;i="5.87,237,1631602800"; d="scan'208";a="296917274"
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 15 Nov 2021 09:32:27 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.87,237,1631602800"; d="scan'208";a="644900425"
Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84])
 by fmsmga001.fm.intel.com with ESMTP; 15 Nov 2021 09:32:26 -0800
Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by
 fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Mon, 15 Nov 2021 09:32:26 -0800
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 09:32:26 -0800
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by
 edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2242.12; Mon, 15 Nov 2021 09:32:26 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V/PjIHTsemz4aSO9saaBaRIEessr7Hn8HLyh8A/y661OEBfU5nEOYd1uuVjc6qEHSXyjeCzM6vDB0pGeASBMpHuuQzPHn5BfB2PhYfqYX4XkxnS4G2xU14AlhlkO/qzI2khmDVo3neUaLsLKE7I4drlXdg3VSVC8Q5uxLF7l7GShZehVht2bPKtEei9AoFO1Sj6USvICfN8zi9WWJvO1KvWta47EunLXzbvQ2Re02cpJ9igMPiWMrQkNcTENAy0xjoZMqaWja2mBkkUO0l2O+VPVZirXqiR96HzLStSn3QOG+9KFG19dYsPHdyxPw5qaXLYLi7ahGRcis0BYz8IN4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Qtkd/yOE6Xc81RkWokOtBI/lQp/m7HdXEKMLgO1IptE=;
 b=kFyeU/TVtQcO6leihm8NfpTYVi9ARda85XO6r8WIOTE+sAEfzc5QffMm8ht2vKEG6PaMMIPCUtN19Kz+HyrVUwkKLzftsIWIxg/4gim+1YHx/P8ALM0Z+NX/+o85uVIP4wKiS42A1Iv0b0my/nwkDCMQj27mg0vTGvfUuNlAguvpxXeBJgXhk2w3iHE7k+FFO9d0DLdXWFiiEzwdFz+0KgyAGZ/2HGMPTPrEQP49Irseq89RKC9DRAUJWX8H14xzOVUhBv5EXV2KmLgW3fvZN9RG5GnUnAwZMYtCqzQLeb+dK/q5Z3X+0d2cqn+iLag0gAxVUG4zV5Wq07aro0v4bg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Qtkd/yOE6Xc81RkWokOtBI/lQp/m7HdXEKMLgO1IptE=;
 b=rsi19Z34tyxqzzKqLMAmz1GGvF+I/uazYuubhHF5S3u0zFb2mBXmbZHUoggbqkt9MUYWjFsOfkRD7f5LVacOSVvJPRcmb+bjVaj4Nj91HK3IzTfkWOaXFFirL+zMXGajFdKUzzzh9ezn+5lNAEZFK6NEqbt0WovnyBrATWpECgM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19)
 by PH0PR11MB5782.namprd11.prod.outlook.com (2603:10b6:510:147::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Mon, 15 Nov
 2021 17:32:25 +0000
Received: from PH0PR11MB5000.namprd11.prod.outlook.com
 ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com
 ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Mon, 15 Nov 2021
 17:32:25 +0000
Message-ID: <b8df92a6-859c-a027-1eb6-00644ac8ad4a@intel.com>
Date: Mon, 15 Nov 2021 17:32:18 +0000
Subject: Re: [PATCH 2/2] net/hns3: optimized Tx performance
Content-Language: en-US
To: "Min Hu (Connor)" <humin29@huawei.com>, <dev@dpdk.org>
CC: <thomas@monjalon.net>
References: <20211111133859.13705-1-humin29@huawei.com>
 <20211111133859.13705-3-humin29@huawei.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
In-Reply-To: <20211111133859.13705-3-humin29@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: DU2PR04CA0295.eurprd04.prod.outlook.com
 (2603:10a6:10:28c::30) To PH0PR11MB5000.namprd11.prod.outlook.com
 (2603:10b6:510:41::19)
MIME-Version: 1.0
Received: from [192.168.0.206] (37.228.236.146) by
 DU2PR04CA0295.eurprd04.prod.outlook.com (2603:10a6:10:28c::30) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4690.15 via Frontend Transport; Mon, 15 Nov 2021 17:32:23 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 25424e51-8fb8-4f9a-24e3-08d9a85de335
X-MS-TrafficTypeDiagnostic: PH0PR11MB5782:
X-Microsoft-Antispam-PRVS: <PH0PR11MB5782B2DB1543CE037A7B368695989@PH0PR11MB5782.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mZ6C9VIQPkCKk3T83x8JvNnhkokkblsqDD+O1LuRzpv3T7vPWpBvOv+WwiVNfTtd8IYxUgyiIEwCLIm2FhLOPYeHFC2p/ypTTAm+jZ7SQGJOZF7BRItRHgn9RPCXnSLTnYnrPEzRSIyhwHE5TJWW5l76eVNsieUyFru1OJmAxvzUQFi6FFx4F6I9/4KWvepzwRtCacxPKLgPAnQ1nk8SHgi3JqBL6wNn2y94Jat/IPIYKWDbvfC32ULSimmU6PUl69gRuGrolHuMNmUGcHFqqaSs+5XbPC25iQOUJIImHJP4FWWBUmhMY265eo0G+kJ3uZ63NL9+BB2JAn5IKu6oTXMWHqYF5Zg2E9bQoUQoElba3WUFeAPwFxabe8HoW0w9hEMtsk6qVkmTwABV4pfcLMaSmzTO38YDjfSTRFv2XUxTBQv9gaNZNMurJxTzLnGkhBftlo0CVCrqwjiMtXJ3X8LH5acut4UA4vV6ycA6ZbFc0BkH3pTHoh7Pq8AqyHETboS+C5ALsnQldx48+fuqy5M3Fl+KjqFpDzemxf12oqBehrnIyUaEyeqm/R0C3AQznOR5qFpj5ydHWtZNc99GA8a4KAvY5tWoS5Wlqg4kmv3Sz66OhUhGu5oolIjNEqMmf6TvCejcVgwM589trWJXt6vtJyl4i3YopgFnfihAQ7iTCWh3CQB38NP4AmVbZE+8Z4yN1LbKyBzQ9driTrN0gQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(366004)(82960400001)(2906002)(38100700002)(6486002)(4326008)(6666004)(36756003)(31696002)(5660300002)(316002)(508600001)(186003)(44832011)(956004)(2616005)(8676002)(31686004)(16576012)(4744005)(86362001)(66946007)(66476007)(66556008)(53546011)(8936002)(26005)(45980500001);
 DIR:OUT; SFP:1102; 
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVplYmVBSFhCUDZHK29YSW9vQlYzc1dqb2J6OWtTajU4UWlqTWtXajYxQlll?=
 =?utf-8?B?aDJ0VWs5V2MvdHhsa2tRL0V3bjZtVEo3b3YxbTFua3RBVnhsMVc1Nyt1amIy?=
 =?utf-8?B?RzdRdHE5Z3UxUEFzZnhvK3lrT2dvTHZnV2pUUGlYeWsyQSt3S1VzR05VbWlE?=
 =?utf-8?B?M0RyS3FWNFBXSTczQTJaS2o1dzdQaGZTRFdPb3d6NlIvdUFtQmkyQWNJRDQx?=
 =?utf-8?B?Y3N2RkEra2dPTXNuTXBLUDZIcDFxSG9UaXpKMkJ0TWdvYm1PSDJkYTdZRGFH?=
 =?utf-8?B?SjBIcW5GYXg3dVVLQldwVWVZamR0Y3EwR2d1ZzJ0ZEhZR0V4S2hEWXhrdGZF?=
 =?utf-8?B?SU5YNkVWNVdKRFFrZWpmYWZUOVRnYnRNeTlrcWhZNzdpWlM4cGdsRFJKR0lz?=
 =?utf-8?B?eHF5M25nOUtVaFVkVHZyTVJsT21pd1BDVGNmR05xbDJZTnJqWEk1Yk1EZkNa?=
 =?utf-8?B?ZGR3N1pRTitoTFBtekg5WFR6ZWp1S2pIWjA5cmUwakJLbGdEY2tiRUpsQnlL?=
 =?utf-8?B?aGhhQk5MTlkrNlF4Q0ZXR01uVGhpMCtpYStBT0I1QllpTlFwSFRnVndEMEMz?=
 =?utf-8?B?VWdwL1ZzNFY1N2JacjRONTRIaEZYSml2Q3dPdTNiZkszMVNzb2llU0V3cmZM?=
 =?utf-8?B?ekRWM21IMkdZM2dNRUU0UU85NEJ0Wk8veFVFWVZLMFdMUWFJdkgyb3JtbHdh?=
 =?utf-8?B?dmZJOGRjYUpQeHJhNHVTYWdtUytBMCticjM1bFVIM1hZSEI5aGM5RVYzOXZK?=
 =?utf-8?B?OTAyZmYzWkxXdERsVkduN3NPWnVlMmsxY1RoeUZPVDVFNkptcTdFRHZ1SDg4?=
 =?utf-8?B?Wk5ra21VaFZZSkVaMXVPTmFUeFlQWXZ2M2I3VS94dDlrcTJjaXJJSjNORG4x?=
 =?utf-8?B?NkJ4eW5SQUZleFI3bnBtYjZ0U1dGZFlrZlQ0cVRDUjczcm9qVmpTNEtoWlZl?=
 =?utf-8?B?a0ZybDBKWGx1N2t2dld6REcyU2ZjWVc0WGtuU3hlTGU2YUNkRzFncmlFSHFs?=
 =?utf-8?B?NVpuVFppYmZWY0U0amtadGQrNGJGcnhUYWpYU29jQ2dYd1lvdmR1Z1QyWlgr?=
 =?utf-8?B?MXMvRGwvczJaMTJOb1BJR04vVW1IZVQ3emx4TDZSZXoyVmVCZVN4U0ZqYzB1?=
 =?utf-8?B?TVRWNlp1blFJNTkrVERybS9WWE5SbjZIMVE5MHFmUE13Vlgwbm1BSWV0OGpw?=
 =?utf-8?B?QVVqblBES21SRnljdXY2K25FQXZNSU9XajJCQkpwTmlOTWd6a1Q5dFVQMmc3?=
 =?utf-8?B?dWNjWlZENG0yZlJxeExnTTVQYktoWVFyVG1OQ3lCWEp0TXd4T2RwdVBPSjFo?=
 =?utf-8?B?Q05wdDNYRlR3OHNvalVicTU0c3hlTTRzVUVhb0drN2Rnc2tnTkd3dS9CaGVI?=
 =?utf-8?B?anBJazQrZmdoVlcwVFh1ajdCY2xtOVZ3dzUzR1VCRmNscWNpUmIybnhkZnhO?=
 =?utf-8?B?NlVqTThFU3lFdDJvNnIra213b0EvNFlrdlpRSE52MnJTblJ4WEVkQ255SlBD?=
 =?utf-8?B?MUUyVlJlTEE4dEdoU3c4ZWFCVVB1ZmMyYWFtaGdIdWhRdWNUM1lqWnpBQmht?=
 =?utf-8?B?bTUrWUsvVnVPeXo2SEsyNlBPT3BOMGNEejZyb2JmUVgzSHZoQWxCcjZ5WHhD?=
 =?utf-8?B?SW1BS25nMEZmY25kUHo0Rmo1amk2Y3hTSmRjWkU2UUVmcVZMUTZnK3l4UHBG?=
 =?utf-8?B?ZFh1d1phdjZnWTQvYTFkK3lJTVN1TVlYaUkxcW1lZnE2U1JIRmw4T1QxS2w5?=
 =?utf-8?B?ZlhKZ2RXRjEyWWFWWjQ1VzhYYjArQzRXY25tL0FOcG5ldXJCaHQ0aVFXaVB4?=
 =?utf-8?B?MmVBeVlxOGFiNVZJRmQ2d0RDVmZleXB1UzJFZnVJdUtoK2xwMHJ6KzU5Z0Vs?=
 =?utf-8?B?NTQ4ck1Pa3NUMFZLZGVKY2pGQ292a29LZnFTWGhPTmN2Q1F5ZVp2ZVkrdFpK?=
 =?utf-8?B?R2RpNG55SDNYMVp0YmtHajBFb3VxNjFPbjdmV3FZUUpaMFlqK1ZtNTVJSWd5?=
 =?utf-8?B?MjM3MWppNVhYbmU2OVQ3UjU5ay84eWk2M0p2TUVPUnF4a3VpTjcvd3RBdWs1?=
 =?utf-8?B?RXhzY2NEYm5RbEo1MmRiaDNtRC9EMGlzVXA3WmlSVzlRV0dTUFBTb1ZTdEo1?=
 =?utf-8?B?Y3N5eXovZ3IrWWlueFpyK1lWcEVnMElMeDFmWCs5WFg3SDlQTXEwWDZIQ2h1?=
 =?utf-8?Q?3E8E8you2GF9XDC6hUgyAGo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 25424e51-8fb8-4f9a-24e3-08d9a85de335
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 17:32:24.9510 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iHa/Z0+Dqaos2XsYkNT9WVz3uy2wNyM6lGLPEOEbZENsC6AMPuAQVAEoGa+kwbum88TEAwTwdYJWFojNU9+kPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5782
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 11/11/2021 1:38 PM, Min Hu (Connor) wrote:
> From: Chengwen Feng<fengchengwen@huawei.com>
> 
> The PMD should check whether the descriptor is done by hardware before
> free the corresponding mbuf. Currently the common xmit algorithm will
> free mbuf every time when it's invoked. Because hardware may not have
> finished sending, this may lead to many invalid queries which are
> whether the descriptors are done.
> 

Hi Connor, Chengwen,

Since there will be a new version, can you please reword above paragraph?

> This patch uses tx_free_thresh to control whether invoke free mbuf, and
> free tx_rs_thresh mbufs each time.
> 
> This patch also modifies the implementation of PMD's tx_done_cleanup
> because the mbuf free algorithm changed.
> 
> In the testpmd single core MAC forwarding scenario, the performance is
> improved by 10% at 64B on Kunpeng920 platform.
> 
> Cc:stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng<fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor)<humin29@huawei.com>