From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0681943B39; Fri, 16 Feb 2024 12:33:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD2DE432C8; Fri, 16 Feb 2024 12:33:50 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2064.outbound.protection.outlook.com [40.107.212.64]) by mails.dpdk.org (Postfix) with ESMTP id 38C5243001 for ; Fri, 16 Feb 2024 12:33:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cPQ1B5x5n6tZmzpF+IJc4vfIwD7w0cTcXU/suMFwyaPNKt7Us1okR+BYaoCiSAVppDLsY59RnbN8EUaU6f+Rytgx9W2C8UlBTsXTOjpHH63Hw7QC8f8B0cpT8lwOt9dVUZfN4kQlJJ0egXOrND4a3zq35Grj7j32jXN2s4Z6izjjPuviEM9Jol30UhBgYlJu7pqperihMikCLvaBWNB8KuG6ihBeWTbpNZlX79K7f++RBSLOFRqqkdQEldNg3hk5W+vMTJcPpdsXhbG/E4uZPn8p8bUQzba1zH+qK3jqmlkJz2chccew0gThNWkxSpWwF0S5GrzaAD19fXcNYyv93A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fYAzxMaKPYWDoeQP3SjAsFdhW3WQK2fdLuXAzdGL53I=; b=Xqgtp/1QmO54PF/s9TwPjqqaB91hEvIU0+uVARi4iWpFs+uU5Qfzl/qhw5wpjmcSwOTpzN9rXc1KIpBthV4ZoH04DZqjNmmfVq15YVVOraU3Kn5zrKbjKpfP0BE41PZ4WU4eTLkAhtdxpdvTqsmIKX3yWa2IhwyvZ5RHfhToXyFhZcGltdd4aN334rUH8r4sXTFcrLAaI6d1z6ysyMavZ0hQ6ERz+Aal1lpqLYnZho6sS9CRGha2QWzUF8DfBu1jTpU3bCklF5Diis5KH2XbolwGpFTqFQbtirZWtq2FQOFkYdOWQ0uj+roqIIsKs9nRFoWph96ZPyXlzTYv0TVjRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fYAzxMaKPYWDoeQP3SjAsFdhW3WQK2fdLuXAzdGL53I=; b=YrABkxLUJSEHKEoA+AqCDEGh/52z4IGeGYF6kVyf4r/sIM2KRZBDgNvPUttLVZQh2rmNxMTqk7qocR2uzSEIRT+l2CXRfhoSGHXINTBkKyR7bpA4Rkg/1nPvSoZNaqP/cIwesfBJ7NAIfBYeTd7WbaxXSBzlLncT1kghDdY+DbM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL3PR12MB6545.namprd12.prod.outlook.com (2603:10b6:208:38c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.10; Fri, 16 Feb 2024 11:33:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.012; Fri, 16 Feb 2024 11:33:45 +0000 Message-ID: Date: Fri, 16 Feb 2024 11:33:37 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] net/netvsc: fix parsing of VLAN metadata Content-Language: en-US To: Alan Elder , Long Li , Andrew Rybchenko Cc: "dev@dpdk.org" , stephen References: From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0247.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL3PR12MB6545:EE_ X-MS-Office365-Filtering-Correlation-Id: 769a98ed-94d0-4502-7833-08dc2ee32244 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lTG9f6mIXuiDtbTb+a/WuwIKJ2jj8RR793usNglELC7fNILg5Fr/gySkIZQzYQJgcelNq0AJM/Gq6wlI+BEL6+lxXLg758wCY8QgEr6QPBTWuDlLLusbKn23ZSraEqC6lDyScmrU1lOdrMYh39sbU+TjX92dbgPZX8SZZ6url//goHnvqHH07ujFLS6KfIvrix8C7YI/r8VL4/ImqsjIHLmWbvsZkatqt41JRwHvlU4AYMwHLTCpgb11fKhzTxmIUNs2qAavG89lgyUgI7+NIU8JH6ti1qx515/F/AYJaBHhiydXWKE1Wsy7NcPZLbssj6VRYZoLHKpKijGjL9qno/ILm3whlBUhwZs73yMMUYJfDp47+bOLpDDvHGVif9CgYV5WNNtxyRC52B4o0swvDxeRmH8L+rlFphiyaF/MTLBbhDkMnof36BRFcl/pnO6duwtyjFTOnskCA7HqoRGVglQ1+35YNe+d16SWHJvLNRQzu24Ak4hGSXZl2/y203i8lcMQMrJClIRd5vytHr+5TYSow51a/H/ehN3kHfKUey0CIQKniK2FhV5Nttejvimq X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(39860400002)(136003)(376002)(346002)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(41300700001)(6486002)(45080400002)(478600001)(31686004)(6512007)(54906003)(5660300002)(8676002)(2906002)(4326008)(66946007)(6506007)(8936002)(44832011)(53546011)(66556008)(316002)(110136005)(6666004)(83380400001)(36756003)(2616005)(38100700002)(31696002)(66476007)(86362001)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Lzhtc3IxK2g2UEpzckh6R0ZRRFRUWk95RkJzTVJ4bEhjRDh3UFk4eGpRejRB?= =?utf-8?B?WjQzaGZCTXVzWjAreXhVSmlBKzdOL0hsV3QwMDdpUWpFdUU2Mi82L0hnMW04?= =?utf-8?B?SFpuNHUwV2w0bjZjWVBIV1NFcVFNaTFMOVFINWF1RzNtMDcrYVpTcXZ1V0g3?= =?utf-8?B?V0ZIQThrZVU3RUNhYnRGMzdWODRrdDY1d0VvUmdYS1E2WHEzWmVPN2RBRkRO?= =?utf-8?B?eFdUS3RHS3RYR3pMMHhGQzgyYU51ZTJMQ1hEdFdhblJETzdBN1BuS0ZrU2tL?= =?utf-8?B?TUprK2FHWEZTNy9OMG13QjNoY2lyU3MwbXdBSVFuVEYrb1BhelA4aStPdno3?= =?utf-8?B?U28xV3NVenVjTFRCWEUxeGVIQlpVclBOZkxOVnIwZXR5cUdGVjZtbmtSMThK?= =?utf-8?B?YUpEcTVRcm9NTDhKeGhEVTVrWXVPUWVIUDVIeDAzS2NnM3NFZlR0a0RKbVkv?= =?utf-8?B?c09nY05DQ2N6cmhlYWtNWTQzS2ljbUNzdkNIbXhvYytmYkdtZzlRbDVyMG1q?= =?utf-8?B?VlBDL0FKWFBmLzJsd2NIclZlWjRqaTU5dFZqNGlHcFRadlA0UlFEOS92RUlM?= =?utf-8?B?ZjFsNy8wNjFZeWhPbzhRcW1GT3NJbnFaSFlUQ1VuNEkvZkczcGhDeWwvQmFD?= =?utf-8?B?WkRXaGVzOGJmbG1NZjhyWjJuL1hqczB2RmNkckxOWllBbThGcmNXVy9VSGk3?= =?utf-8?B?QURYaG9LZkdUaWg1V0s5d0p5QTRRblhRYkJHZytnN3V1R2JSQURVb2hobi9E?= =?utf-8?B?QSs3WjEzdWdKYkRMNENmQ0ZhUzBpUUxkaUpmbDd4WlFGcmMvRjU1ZWdtakMr?= =?utf-8?B?MzlFZzNrYkVZTHVBNUFZbHhyTFQzYnd0SVprNDhhSzBYMTIxU3hxM0NOQUc0?= =?utf-8?B?MkJkdHFhdDhDNWFnWm5rUURZZHY1NktIckt4MnNSUWFNdVEvV2s5SHFYcEhr?= =?utf-8?B?cUlDVHRLak5oZnZvUHo2YVNIVFZhV1dUbkErSTJNemd3a1lSdFJpenB1cHM0?= =?utf-8?B?eFQ2YzE2S05xWmJDamkyZnJla3ZoU3N2VWsrdHVsd0tPdkdhWmtlSk9ldHA2?= =?utf-8?B?MXEyNGR3UG1xUTc0di9LQm1VMmYwZnREYnR2U0pDN1VJU0lXdW1JUzhKTUxT?= =?utf-8?B?WDdJTC9yYldzT3hqcDIwRnpOclB5bGZPOU1GUDFSWkFZTmwrWDZiUW1tK09r?= =?utf-8?B?QXhJY3NQQ3dJWmh0Q05EcGQ3ZTBCc0plV1FuTWFSbFdHcHUwdU4wYmVBd3Zv?= =?utf-8?B?cDhGRlgvNkxpdyt1b0MwNm0ydE9kelRYNWhUaHJ0WEFMQW5tTzZWTFVBRkNW?= =?utf-8?B?UStub0s5ZEJTaW5HSGhPenhiemVUd2VzMjEzYkxOSkNUUkdQL1IyenFGc0Fv?= =?utf-8?B?bGM3ZmlEZ201Tk5vTmJ1QVo0WmJGUFRlMEVWTFFZWlVHdkcxWHdHNVVzeDZQ?= =?utf-8?B?QTQydWpscEVkSkJDMTd1QTBsRFQzR292Uktxd1RuallBYUV6Z3NFWEdFU01H?= =?utf-8?B?S3ZrOExkc051b2RxeDYwWTdzR0pDR1gwakZzYWN6b0RvUmZyK2VMN1MzK0RB?= =?utf-8?B?YW00VGduWXR3WnZaRDdSVUFsUjB4S3lmbi9mcGRNK0dJRlQxaTNocnJVa3pp?= =?utf-8?B?bjIrb0J5eUhqcTBncTJzMXF1NktJcHlJOVZHbFNCMkJyczdTRTBXWVZxUkFQ?= =?utf-8?B?U2JJdEphaXNSVDJCK29kMVBmSGdBTE9OSGdOZlJDcEV4RmwvWWpCTUI5YVZB?= =?utf-8?B?SlA0eGFEejJCZmN3ZWVvNmxvak5hSFdadkFSOVVKSTNNVmNFUFI5eWx6Q3Rq?= =?utf-8?B?WGJqNGxuUFNZdGJQR09QbXMrTXdkM0ZtNGFHN1U5V2hOL2hwVlczMVlEUVBw?= =?utf-8?B?WlNLUmtCR0R0WmV4OU4ycXRQWFhaMk5uU2RGd2tXdDdHdHhTSThmRmRjQUdW?= =?utf-8?B?K0p5NUk3UFlXM01ScTJ6a21tSkFOM09WbVJMb2tXSU5vNlk1TTVsallDdk1I?= =?utf-8?B?Tm0rUW5nK0VvOGZkelZPWU14SlJJUW41SWFWeEhNRFZpWWVIQlRSQnB6UFRO?= =?utf-8?B?dWQxNVRtL2Z4M09sV0pGRGpzeG4xUVFVT2NEREtaTVZHK2pJVkJwZkp6WHZU?= =?utf-8?Q?6QrUXPHl6sfFfxqXNYsVGt9of?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 769a98ed-94d0-4502-7833-08dc2ee32244 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 11:33:45.0007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kPnlnDE0G4Uq2if1DjLIgvpfCX3gBfQiJWPUHl8srjIleRMopwc+7R4d7bqvmT6U X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6545 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2024 6:12 PM, Alan Elder wrote: > The previous code incorrectly parsed the VLAN ID and priority. > If the 16-bits of VLAN ID and priority/CFI on the wire was > 0123456789ABCDEF the code parsed it as 456789ABCDEF3012. There > were macros defined to handle this conversion but they were not > used. > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > Cc: sthemmin@microsoft.com > Cc: stable@dpdk.org > > Signed-off-by: Alan Elder > Thanks Alan, overall looks good to me. Can you please make separate the lib/net patch? As first patch lib/net updates, second updates the net/vetvsc. > --- > v5: > * Move the VLAN parsing macros to rte_ether.h > > v4: > * Make consistent with FreeBSD code > > --- > .mailmap | 1 + > drivers/net/netvsc/hn_rxtx.c | 8 ++++++-- > lib/net/rte_ether.h | 16 ++++++++++++++++ > 3 files changed, 23 insertions(+), 2 deletions(-) > > diff --git a/.mailmap b/.mailmap > index a0756974e2..eca02318d6 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -33,6 +33,7 @@ Alain Leon > Alan Brady > Alan Carew > Alan Dewar > +Alan Elder > Alan Liu > Alan Winkowski > Alejandro Lucero > diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c > index e4f5015aa3..9bf1ec5509 100644 > --- a/drivers/net/netvsc/hn_rxtx.c > +++ b/drivers/net/netvsc/hn_rxtx.c > @@ -612,7 +612,9 @@ static void hn_rxpkt(struct hn_rx_queue *rxq, struct hn_rx_bufinfo *rxb, > RTE_PTYPE_L4_MASK); > > if (info->vlan_info != HN_NDIS_VLAN_INFO_INVALID) { > - m->vlan_tci = info->vlan_info; > + m->vlan_tci = RTE_VLAN_TCI_MAKE(NDIS_VLAN_INFO_ID(info->vlan_info), > + NDIS_VLAN_INFO_PRI(info->vlan_info), > + NDIS_VLAN_INFO_CFI(info->vlan_info)); > Is there a good reason why format is not same as spec format?