From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A6BDEA054D;
Thu, 9 Jun 2022 05:25:40 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 97BD34113F;
Thu, 9 Jun 2022 05:25:40 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
by mails.dpdk.org (Postfix) with ESMTP id BC2B24113D
for <dev@dpdk.org>; Thu, 9 Jun 2022 05:25:39 +0200 (CEST)
Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57])
by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LJTwl4Lr4zjXK6;
Thu, 9 Jun 2022 11:24:39 +0800 (CST)
Received: from kwepemm600004.china.huawei.com (7.193.23.242) by
dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.24; Thu, 9 Jun 2022 11:25:38 +0800
Received: from [10.67.103.231] (10.67.103.231) by
kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.24; Thu, 9 Jun 2022 11:25:37 +0800
Message-ID: <b948b82b-c320-b049-afeb-98f8db696ba4@huawei.com>
Date: Thu, 9 Jun 2022 11:25:36 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
Thunderbird/91.2.0
Subject: Re: [PATCH V3 app/testpmd 2/4] app/testpmd: unify RSS types display
and obtaination
To: Ferruh Yigit <ferruh.yigit@xilinx.com>, <xiaoyun.li@intel.com>,
<aman.deep.singh@intel.com>, <yuying.zhang@intel.com>,
<andrew.rybchenko@oktetlabs.ru>
CC: <dev@dpdk.org>, <thomas@monjalon.net>, <huangdaode@huawei.com>
References: <20220429102445.23711-1-lihuisong@huawei.com>
<20220607083246.12259-1-lihuisong@huawei.com>
<20220607083246.12259-3-lihuisong@huawei.com>
<8f636a38-b96f-1eba-9728-aa52b0942f05@xilinx.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <8f636a38-b96f-1eba-9728-aa52b0942f05@xilinx.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.231]
X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To
kwepemm600004.china.huawei.com (7.193.23.242)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
在 2022/6/7 23:46, Ferruh Yigit 写道:
> On 6/7/2022 9:32 AM, Huisong Li wrote:
>
>>
>> The 'rss_type_table[]' maintains string name and value of RSS types.
>> This
>> patch unifies a common interface to display or obtain RSS types.
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>
> <...>
>
>> @@ -5669,6 +5681,7 @@ set_record_burst_stats(uint8_t on_off)
>> record_burst_stats = on_off;
>> }
>>
>> +#if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE)
>> static char*
>> flowtype_to_str(uint16_t flow_type)
>> {
>> @@ -5712,8 +5725,6 @@ flowtype_to_str(uint16_t flow_type)
>> return NULL;
>> }
>>
>> -#if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE)
>> -
>
> I think this change should be in first patch (v1/4) where
> 'flowtype_to_str' stopped being used.
Ack.
>
> .