From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] devtools: check stable tag in fixes
Date: Wed, 18 Jan 2017 17:25:10 +0000 [thread overview]
Message-ID: <b94c6e0b-65e6-a438-0d1b-840ae529a11f@intel.com> (raw)
In-Reply-To: <20170118044150.GN10293@yliu-dev.sh.intel.com>
On 1/18/2017 4:41 AM, Yuanhan Liu wrote:
> On Tue, Jan 17, 2017 at 07:42:33PM +0100, Thomas Monjalon wrote:
>> 2017-01-17 18:15, Ferruh Yigit:
>>> On 1/17/2017 2:54 PM, Thomas Monjalon wrote:
>>>> The tag "Cc: stable@dpdk.org" must be set when the commit must be
>>>> backported to a stable branch.
>>>>
>>>> It must be located just below the "Fixes:" tag (without blank line)
>>>> and followed by a blank line, separated from SoB and review tags below.
>>>
>>> I am OK to keep it if it will help stable tree maintenance, but I still
>>> not clear about why we need this.
>>>
>>> If a patch is a fix, it should already have "Fixes:" line, so this can
>>> be used to parse git history.
>
> Same answer (as I have already replied to you in another email): not all fix
> patches should be picked to stable branch. (I gave some examples below)
I was thinking all fixes will have "Cc: stable" tag, to be sure all
fixes sent to stable mail list, and you will be the picking for stable tree.
Now you are suggesting some fixes may have "Fixes:" tag but not "Cc:
stable" tag.
So this means now author/maintainer/committer will be the picking
patches for stable tree, and to show this decision, will add "Cc:
stable" to the commit log.
If author puts the "Cc: stable" tag, git send-email will ensure this
patch will be sent to stable mail list too.
But if author missed the "Cc: stable" tag, will it be enough for you if
committer adds the tag into commit log? Or should patch sent to stable
mail list too?
What is the relation between "Cc: stable" tag been in commit log and
patch been sent to stable mail list?
Thanks,
ferruh
next prev parent reply other threads:[~2017-01-18 17:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 14:54 Thomas Monjalon
2017-01-17 18:15 ` Ferruh Yigit
2017-01-17 18:42 ` Thomas Monjalon
2017-01-18 4:41 ` Yuanhan Liu
2017-01-18 8:32 ` Thomas Monjalon
2017-01-18 8:54 ` Yuanhan Liu
2017-01-18 17:25 ` Ferruh Yigit [this message]
2017-01-19 8:05 ` Yuanhan Liu
2017-01-19 12:00 ` Ferruh Yigit
2017-01-20 7:59 ` Yuanhan Liu
2017-01-20 10:10 ` Thomas Monjalon
2017-01-20 10:23 ` Yuanhan Liu
2017-01-20 16:20 ` Ferruh Yigit
2017-01-18 9:37 ` [dpdk-dev] [PATCH v2] devtools: relax tag checking " Thomas Monjalon
2017-01-18 10:04 ` Yuanhan Liu
2017-01-18 15:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b94c6e0b-65e6-a438-0d1b-840ae529a11f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).