From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B1A5A0C4D; Mon, 6 Sep 2021 03:42:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7023640E32; Mon, 6 Sep 2021 03:42:50 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 7214B40C35; Mon, 6 Sep 2021 03:42:48 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10098"; a="200068284" X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="200068284" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:42:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="429710293" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 05 Sep 2021 18:42:47 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 5 Sep 2021 18:42:46 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 6 Sep 2021 09:42:44 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Mon, 6 Sep 2021 09:42:44 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , Qiming Chen , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v3] net/ixgbe: fix mac resourece leak Thread-Index: AQHXor4XZQVBpq6gH0ORNd+Vxvg0NauWO2WA Date: Mon, 6 Sep 2021 01:42:44 +0000 Message-ID: References: <20210831142131.9295-1-chenqiming_huawei@163.com> <20210901071207.9379-1-chenqiming_huawei@163.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mac resourece leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Wang, Haiyue > Sent: Monday, September 6, 2021 9:25 AM > To: Qiming Chen ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mac resourece leak >=20 > > -----Original Message----- > > From: Qiming Chen > > Sent: Wednesday, September 1, 2021 15:12 > > To: dev@dpdk.org > > Cc: Wang, Haiyue ; Qiming Chen > > ; stable@dpdk.org > > Subject: [PATCH v3] net/ixgbe: fix mac resourece leak > > > > In the eth_ixgbevf_dev_init and eth_ixgbe_dev_init functions, memory > > is allocated for the MAC address, and the address is stored in the > > eth_dev->data->mac_addrs member variable. If the subsequent function > > is abnormal, you need to use the rte_free function to release the MAC > > address memory. > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: Qiming Chen > > --- > > v2: > > Clear coding style warning. > > v3: > > Modify fixes commit. > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > >=20 > Acked-by: Haiyue Wang Applied to dpdk-next-net-intel. Thanks Qi >=20 > > > > -- > > 2.30.1.windows.1