From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D53BA034F; Mon, 30 Aug 2021 15:47:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8F36406A3; Mon, 30 Aug 2021 15:47:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id C88FF406A2 for <dev@dpdk.org>; Mon, 30 Aug 2021 15:47:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630331260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a+4pITS0Mczm55SKOetK23bIYM5LGsuyh4LaCAMoqI0=; b=MoB2+RDPZth5/LlMe4xkW25ovhyqKNNClSs4S8BVqoqhLBfQi9xE3nmIrMf93Wqnd9K9GM mvFIboqQ0vSdVxyUluOSFq93i/+BVzBuYjEI8thusK9pYW8dc+pvDHfndoIrGqWpJ9bb6G awp5ECqa8yrL+czotBJKtPLKbl3jSGo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-_bjMZJ93MhKzTIbuFI4wyw-1; Mon, 30 Aug 2021 09:47:39 -0400 X-MC-Unique: _bjMZJ93MhKzTIbuFI4wyw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3F4A760C5; Mon, 30 Aug 2021 13:47:37 +0000 (UTC) Received: from [10.39.208.27] (unknown [10.39.208.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F6E360CA0; Mon, 30 Aug 2021 13:47:36 +0000 (UTC) To: Vijay Srivastava <vijay.srivastava@xilinx.com>, dev@dpdk.org Cc: chenbo.xia@intel.com, andrew.rybchenko@oktetlabs.ru, Vijay Kumar Srivastava <vsrivast@xilinx.com> References: <20210706164418.32615-1-vsrivast@xilinx.com> <20210706164418.32615-9-vsrivast@xilinx.com> From: Maxime Coquelin <maxime.coquelin@redhat.com> Message-ID: <b9667b2a-f462-af19-029a-86b9cfbc8b53@redhat.com> Date: Mon, 30 Aug 2021 15:47:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210706164418.32615-9-vsrivast@xilinx.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 08/10] vdpa/sfc: add support for MAC filter config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 7/6/21 6:44 PM, Vijay Srivastava wrote: > From: Vijay Kumar Srivastava <vsrivast@xilinx.com> > > Add support for unicast and broadcast MAC filter configuration. I wonder whether we should not add an API to the vDPA framework for this MAC management, as this is something generic. What do you think? > Signed-off-by: Vijay Kumar Srivastava <vsrivast@xilinx.com> > --- > doc/guides/vdpadevs/sfc.rst | 4 ++ > drivers/vdpa/sfc/meson.build | 1 + > drivers/vdpa/sfc/sfc_vdpa.c | 32 +++++++++ > drivers/vdpa/sfc/sfc_vdpa.h | 30 ++++++++ > drivers/vdpa/sfc/sfc_vdpa_filter.c | 144 +++++++++++++++++++++++++++++++++++++ > drivers/vdpa/sfc/sfc_vdpa_hw.c | 10 +++ > drivers/vdpa/sfc/sfc_vdpa_ops.c | 17 +++++ > 7 files changed, 238 insertions(+) > create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c >