From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 1AE20A09E8;
Tue, 8 Dec 2020 16:48:21 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 7D4B972DE;
Tue, 8 Dec 2020 16:48:19 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id 5CB3772D9
for <dev@dpdk.org>; Tue, 8 Dec 2020 16:48:17 +0100 (CET)
IronPort-SDR: FB7rFgaZCf0IUcFc2UP179FNCVOkE0lERqOfe5i+VrefpHoPQD/47SbiyMGMk3knta4rYOcYfB
zEoCh6YSngFw==
X-IronPort-AV: E=McAfee;i="6000,8403,9828"; a="173148633"
X-IronPort-AV: E=Sophos;i="5.78,402,1599548400"; d="scan'208";a="173148633"
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 Dec 2020 07:48:15 -0800
IronPort-SDR: BCpvglXXsNXp/L8aTTXYDKBK3fa/bIZAHex66A244LYyYUCBiuLd2KcmhdHS8b7LKSmKY8D6kv
EIkP1GDE99WA==
X-IronPort-AV: E=Sophos;i="5.78,402,1599548400"; d="scan'208";a="317856231"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.231.143])
([10.213.231.143])
by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 Dec 2020 07:48:13 -0800
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: bruce.richardson@intel.com, thomas.monjalon@6wind.com, lihuisong@huawei.com
References: <4ae81928-f54e-9d25-6f56-3a79a73c2f00@intel.com>
<1606913335-7145-1-git-send-email-humin29@huawei.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <b96cd277-98ba-f517-ca36-8d51857c8c21@intel.com>
Date: Tue, 8 Dec 2020 15:48:10 +0000
MIME-Version: 1.0
In-Reply-To: <1606913335-7145-1-git-send-email-humin29@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH V1] app/testpmd: fix queue stats mapping
configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 12/2/2020 12:48 PM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
>
> Currently, the queue stats mapping has the following problems:
> 1) Many PMD drivers don't support queue stats mapping. But there is no
> failure message after executing the command "set stat_qmap rx 0 2 2".
> 2) Once queue mapping is set, unrelated and unmapped queues are also
> displayed.
> 3) The configuration result does not take effect or can not be queried
> in real time.
> 4) The mapping arrays, "tx_queue_stats_mappings_array" &
> "rx_queue_stats_mappings_array" are global and their sizes are based on
> fixed max port and queue size assumptions.
> 5) These record structures, 'map_port_queue_stats_mapping_registers()'
> and its sub functions are redundant for majority of drivers.
> 6) The display of the queue stats and queue stats mapping is mixed
> together.
>
> Since xstats is used to obtain queue statistics, we have made the following
> simplifications and adjustments:
> 1) If PMD requires and supports queue stats mapping, configure to driver in
> real time by calling ethdev API after executing the command
> "set stat_qmap rx/tx ...". If not, the command can not be accepted.
> 2) Based on the above adjustments, these record structures,
> 'map_port_queue_stats_mapping_registers()' and its sub functions can be
> removed. "tx-queue-stats-mapping" & "rx-queue-stats-mapping" parameters,
> and 'parse_queue_stats_mapping_config()' can be removed too.
> 3) remove display of queue stats mapping in 'fwd_stats_display()' &
> 'nic_stats_display()', and obtain queue stats by xstats.
> Since the record structures are removed, 'nic_stats_mapping_display()'
> can be deleted.
>
> Fixes: 4dccdc789bf4b ("app/testpmd: simplify handling of stats mappings error")
> Fixes: 013af9b6b64f6 ("app/testpmd: various updates")
> Fixes: ed30d9b691b21 ("app/testpmd: add stats per queue")
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
Thanks for this clean up.