From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org, Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Jiayu Hu <jiayu.hu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] vhost: fix TCP csum not set
Date: Wed, 7 Jun 2017 21:25:38 +0200 [thread overview]
Message-ID: <b97ab9cb-4908-fb18-6b35-625fc61ecacd@redhat.com> (raw)
In-Reply-To: <1496817697-49130-2-git-send-email-jianfeng.tan@intel.com>
On 06/07/2017 08:41 AM, Jianfeng Tan wrote:
> As PKT_TX_TCP_SEG flag in mbuf->ol_flags implies PKT_TX_TCP_CKSUM,
> applications, e.g., testpmd, don't set PKT_TX_TCP_CKSUM when TSO
> is set.
>
> This leads to that packets get dropped in VM tcp stack layer because
> of bad TCP csum.
>
> To fix this, we make sure TCP NEEDS_CSUM info is set into virtio net
> header when PKT_TX_TCP_SEG is set, so that VM tcp stack will not
> check the TCP csum.
>
> Fixes: 859b480d5afd ("vhost: add guest offload setting")
> Cc: stable@dpdk.org
>
> Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Cc: Jiayu Hu <jiayu.hu@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
> ---
> lib/librte_vhost/virtio_net.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
> index 48219e0..0a7e023 100644
> --- a/lib/librte_vhost/virtio_net.c
> +++ b/lib/librte_vhost/virtio_net.c
> @@ -114,11 +114,16 @@ update_shadow_used_ring(struct vhost_virtqueue *vq,
> static void
> virtio_enqueue_offload(struct rte_mbuf *m_buf, struct virtio_net_hdr *net_hdr)
> {
> - if (m_buf->ol_flags & PKT_TX_L4_MASK) {
> + uint64_t csum_l4 = m_buf->ol_flags & PKT_TX_L4_MASK;
> +
> + if (m_buf->ol_flags & PKT_TX_TCP_SEG)
> + csum_l4 |= PKT_TX_TCP_CKSUM;
> +
> + if (csum_l4) {
> net_hdr->flags = VIRTIO_NET_HDR_F_NEEDS_CSUM;
> net_hdr->csum_start = m_buf->l2_len + m_buf->l3_len;
>
> - switch (m_buf->ol_flags & PKT_TX_L4_MASK) {
> + switch (csum_l4) {
> case PKT_TX_TCP_CKSUM:
> net_hdr->csum_offset = (offsetof(struct tcp_hdr,
> cksum));
>
next prev parent reply other threads:[~2017-06-07 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 6:41 [dpdk-dev] [PATCH 0/2] fix vhost enqueue offload Jianfeng Tan
2017-06-07 6:41 ` [dpdk-dev] [PATCH 1/2] vhost: fix TCP csum not set Jianfeng Tan
2017-06-07 19:25 ` Maxime Coquelin [this message]
2017-07-01 23:27 ` Yuanhan Liu
2017-06-07 6:41 ` [dpdk-dev] [PATCH 2/2] vhost: fix IP csum not calculated Jianfeng Tan
2017-06-07 19:28 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b97ab9cb-4908-fb18-6b35-625fc61ecacd@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=jiayu.hu@intel.com \
--cc=stable@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).