From: Kevin Traynor <ktraynor@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH] ethdev: group constant definitions in Doxygen
Date: Thu, 23 Sep 2021 17:35:14 +0100 [thread overview]
Message-ID: <b9bc48e3-bc0b-5c3e-7950-96e541e3b132@redhat.com> (raw)
In-Reply-To: <20210830104232.598703-1-thomas@monjalon.net>
On 30/08/2021 11:42, Thomas Monjalon wrote:
> A lot of flags are parts of a group but are documented alone.
> The Doxygen syntax @{ and @} for grouping is used
> to make flags appear together and have a common description.
>
> Some Rx/Tx offload flags and RSS definitions are not grouped
> because they need to be all properly documented first.
>
> Signed-off-by: Thomas Monjalon<thomas@monjalon.net>
> ---
> lib/ethdev/rte_ethdev.h | 71 ++++++++++++++++++++++++++++-------------
> 1 file changed, 48 insertions(+), 23 deletions(-)
lgtm, this is a nice enhancement when reading the api guide.
Acked-by: Kevin Traynor <ktraynor@redhat.com>
next prev parent reply other threads:[~2021-09-23 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 10:42 Thomas Monjalon
2021-09-09 17:02 ` Ferruh Yigit
2021-09-10 8:07 ` Andrew Rybchenko
2021-09-23 16:35 ` Kevin Traynor [this message]
2021-09-27 11:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9bc48e3-bc0b-5c3e-7950-96e541e3b132@redhat.com \
--to=ktraynor@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).