Re: [dpdk-dev] [PATCH 8/8] drivers: add common driver API to get efx family

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

On 3/14/21 3:36 AM, Ferruh Yigit wrote:
> On 3/11/2021 11:03 AM, Andrew Rybchenko wrote:
>> From: Vijay Kumar Srivastava <vsrivast@xilinx.com>
>>
>> Move function to get efx family from net driver into common driver.
>>
>> Signed-off-by: Vijay Kumar Srivastava <vsrivast@xilinx.com>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> <...>
>
>> diff --git a/drivers/meson.build b/drivers/meson.build
>> index fdf76120ac..9c8eded697 100644
>> --- a/drivers/meson.build
>> +++ b/drivers/meson.build
>> @@ -7,6 +7,7 @@ subdirs = [
>>       'bus',
>>       'common/mlx5', # depends on bus.
>>       'common/qat', # depends on bus.
>> +    'common/sfc_efx', # depends on bus.
>>       'mempool', # depends on common and bus.
>>       'net',     # depends on common, bus, mempool
>>       'raw',     # depends on common, bus and net.
>
> This enables building 'common/sfc_efx' for windows and fail. A windows
> build check needs to be added to 'common/sfc_efx'

I've send v2 which fixes the problem and one more -
undefined functions mentioned in version.map.

Thanks,
Andrew.