From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 91548A054F;
	Mon, 15 Mar 2021 15:01:16 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D876A242671;
	Mon, 15 Mar 2021 15:01:06 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 9FF1924266A
 for <dev@dpdk.org>; Mon, 15 Mar 2021 15:01:05 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 555947F52B;
 Mon, 15 Mar 2021 17:01:05 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 555947F52B
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1615816865;
 bh=/a7CBAWk3bwwglrfq7YCPSyq+ilDB1PWP1TArs/tpKA=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=QQU4H9Ltw9+vAHMDLhczQYhUgM8RgCJ6IvJ9PA9QCZbT/aEYvWEBereiIri9z8az9
 pTO3ZRxPvOF25usp4e+eseZfV9a8ztart5OCRTyx5VUxtWB83ZxCPDn5/4hfughl08
 tUmXvHmTCN6XVBQOagrrtkZbiDilrxanqcOo4LqI=
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Cc: Vijay Kumar Srivastava <vsrivast@xilinx.com>
References: <20210311110325.3291203-1-andrew.rybchenko@oktetlabs.ru>
 <20210311110325.3291203-9-andrew.rybchenko@oktetlabs.ru>
 <c80b1ac3-66f3-9e22-3fef-605c21ed4917@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <b9bfbe70-bf74-0ec3-15ab-2f3f84c7ee8b@oktetlabs.ru>
Date: Mon, 15 Mar 2021 17:01:05 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <c80b1ac3-66f3-9e22-3fef-605c21ed4917@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH 8/8] drivers: add common driver API to get
 efx family
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/14/21 3:36 AM, Ferruh Yigit wrote:
> On 3/11/2021 11:03 AM, Andrew Rybchenko wrote:
>> From: Vijay Kumar Srivastava <vsrivast@xilinx.com>
>>
>> Move function to get efx family from net driver into common driver.
>>
>> Signed-off-by: Vijay Kumar Srivastava <vsrivast@xilinx.com>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> <...>
>
>> diff --git a/drivers/meson.build b/drivers/meson.build
>> index fdf76120ac..9c8eded697 100644
>> --- a/drivers/meson.build
>> +++ b/drivers/meson.build
>> @@ -7,6 +7,7 @@ subdirs = [
>>       'bus',
>>       'common/mlx5', # depends on bus.
>>       'common/qat', # depends on bus.
>> +    'common/sfc_efx', # depends on bus.
>>       'mempool', # depends on common and bus.
>>       'net',     # depends on common, bus, mempool
>>       'raw',     # depends on common, bus and net.
>
> This enables building 'common/sfc_efx' for windows and fail. A windows
> build check needs to be added to 'common/sfc_efx'

I've send v2 which fixes the problem and one more -
undefined functions mentioned in version.map.

Thanks,
Andrew.