From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE9C442D17; Wed, 21 Jun 2023 20:52:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DCB64068E; Wed, 21 Jun 2023 20:52:22 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2064.outbound.protection.outlook.com [40.107.237.64]) by mails.dpdk.org (Postfix) with ESMTP id A3AC54003C for ; Wed, 21 Jun 2023 20:52:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DT6Aahx1MrYpevcK3sZT3+jU3/FxDdkd2Mbr4/opGm0Rqj1XhoWyacNVotS221Vj8SUUd0QZ0II6Y5KI9coeuTjrv9Kj4BrsQEwqF5qM4dP52Ond19TpKr2S8AaDYIc8jkWJEe9lCRWgEOQExWt3+F6QthVicnIiKMpWZXiEh5LVB7qfJ1r7FMQ6v0MEwjMbuCritNUMxQx/cFdwmuvAVOaKhbC4PkkmR+fIj0nkBJMKMxTzPjdUzNuFkXZIROT/TTuJFpfDPSVyDVTDqooa3IKxfk1anNtGqLkINWvTXpBNonnloZIIGnkRrx5u51POBf0dHV8hZmpZmnOrhtAMcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MHg5MucEBztx7PYH0SUtZtTbhOiaba3BRC6d2gS3vpE=; b=caYzCERgG8GTdD3cdKFKlZumedgnhyI80+v2AebazHgQob/c+6DqMauID+JJSOZQI3YYr3xARPJg765Mk19DyVYyCezaDrlQqP4R6keJQv4GB4Z1aY0guirCh4mCyrYlU+Jk4cCoHdlA0nRdTS/k3Xbtzb1/I9fkJUO1tvEQajKaOEqcWM2fse6ro7aUxH0AqbQoxxjSW+ISMZK4KV9/IYKFSldXwuo0qexprDI3GL67tII3rvoxMPkZ4EvxSxbZJCCco9N69d2K7XkQ5kZhjzbFsAsL2K/wMj0kfs0lRNqQEQcbIyvBczb7FNq48Rysc/Q9apShBQJLNqRJ3oxBXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MHg5MucEBztx7PYH0SUtZtTbhOiaba3BRC6d2gS3vpE=; b=U46Lp8p52VhDsMXv60rKhAvaqrbwOYEUdO6oozyncR2du5cVuwR/cLvRScLZxrkdKsJSvUgDMi6FJvAOqSm+WUmYWozyuRs28Fq7BJwTtXM3/ivFzXCgNcrk6dSfNiYApt5jeOVj+YNis1kuuorr62O5NVGWClDH+H59ExcRYWQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB8108.namprd12.prod.outlook.com (2603:10b6:510:2bc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Wed, 21 Jun 2023 18:52:19 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.023; Wed, 21 Jun 2023 18:52:18 +0000 Message-ID: Date: Wed, 21 Jun 2023 19:52:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4] ethdev: advertise flow restore in mbuf Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, i.maximets@ovn.org, alialnu@nvidia.com, Andrew Rybchenko , Viacheslav Ovsiienko , Ori Kam , Aman Singh , Yuying Zhang , Matan Azrad , Suanming Mou , David Christensen , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev References: <20230505103102.2912297-1-david.marchand@redhat.com> <20230621144327.2202591-1-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: <20230621144327.2202591-1-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0069.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB8108:EE_ X-MS-Office365-Filtering-Correlation-Id: df41d203-a232-4314-24c1-08db7288a37e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ofRjnmhl+JVT4JKYR9+75f6AmzE3Crdat0HWTffYcI1y67CRcw9y3UCKiRnmsff4i7EVOJzjamojpzKDSA07ZxRpcnOcC7qxa4IkK+jcIswPrVCEsj1kr9XB0koy6d96NtEA0qqkXkbi2BZHn6nrvPkRJT+IEHaqwyJ3JfXr9tLGwV3aTLMCn8cxJ2vVgioUrGKWgXPHPqUH2bx/5YW6E1e5qYC/mloX6J5aFIjvEueGXIjy93PqkUfim6WFC3sOKxS2JcbZPwRfq2a1FlpYEnoV1r3jfATKt6db5Wosq+AFWiXFBRDb6zVea6ypBGsHjGjDPt6BTX+xN0hKQJjYRNyBDkLLYPPi5gFFFjmej2ebJwVf+r3eqEpcSVIsglWFlIEYMmLh/cpQ+jVllu7OXQUcu0JO3oWMMBb/kga5UZTLpgsVDcNs9/ZTaGvTLi4oss0TOW244r4giJqTBxmMoTiwImSO2hVVx7mGVg5Mitc+YHCbLA36vOhX0jijGJT7EVkHg1oJpczJgWMLT2mBqS6QucccdCAZr+OTTHNPBcLvXGw7xdpNrtEjYnXjQIuMHbDw9lymtLQCOt9lbSoNrQjQ/RwwSSPbG8yDlyX5FlPCNdU00veiMR+2KdPjnO/Plz/oOoSLhq23RTrqrzN30g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(366004)(396003)(376002)(39860400002)(451199021)(41300700001)(31686004)(31696002)(5660300002)(8676002)(86362001)(7416002)(316002)(83380400001)(44832011)(8936002)(38100700002)(66556008)(66476007)(66946007)(4326008)(54906003)(2616005)(478600001)(186003)(36756003)(26005)(6506007)(6512007)(53546011)(2906002)(6486002)(966005)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUxjSUNrcDhQWUs4bUdjY1BJM0htNHFHQ2dRSWUwMDU5cGlxVWUvWmRveWFE?= =?utf-8?B?ZUFVYzVoSkNyeW9EaENRYUJjYmFlKzBGNG10Y2dReTkvS1FlQkloSjgxeTFP?= =?utf-8?B?RkdJZTg0VW5JZ2Q5MHZsb1Ezb1ZBMi9MTkcxNTRrTC9GZVNFZExXcStGOU1N?= =?utf-8?B?dEtHdjFYbG1nKzdOTUJCT1FaQWprS3FFWFc5dVh6NVJ3V0oxS1V0ZzRQUFNz?= =?utf-8?B?Q0JxMCt3ZEYwc05mRkpnTytXTEtINTQyeWcvWWJUZWpXQU5wcXo3SkRhalow?= =?utf-8?B?TlFHUmdpUytNQ3FhT0dBelZJVlFhRVVHQmlFM2hFaVFtZ1dYaFBrdk9zTkNL?= =?utf-8?B?RmdDVm9ZU1U0L3hxWVN0VVZ5WmNWVWNlRG1IUk1yR09KaktGMmExZ0tublR4?= =?utf-8?B?ZUVobVRYUkNyUVB1eW1jTC9LcWhLRURBb3N2Y2hxWmVxMFNmcjRkYlhrV2xR?= =?utf-8?B?SmU5YTN5REREclV3d0V6aG1zdmQ2V21vRjhNSEdvQm94emQ5aXdWSWl3NWlE?= =?utf-8?B?T2o0OXZVMTdiTDdtaWRDOVEwQ1JIdzJ5Yzl2d3VYRjloNXo2cmJzWWlmSVYz?= =?utf-8?B?OG5WMXVCT3ZTT0graFhGMDVWUjVsSWdHK0ZSTUhLeXozTCt3RXVoWnZqTkNT?= =?utf-8?B?dEZHQ0E3V3BadU81TTBPVmZrRmVVS1d2NG9YRTVnMXNpaGp6NHBoU0JydW1Z?= =?utf-8?B?UVZ0UTduWjdlZTlITTU5MkZ2OHNjZVdkQnhWQVZNUEZEdFp4RzNZa3lDTXRI?= =?utf-8?B?aFNGbndPWURJQUhJSDJ1a0NLTEdTT0JHL08xM1dDb3hGL0NYY0V2VjlYMmty?= =?utf-8?B?VEJ1VXRFeXYzSm9GWExpU29adVRmdTIyTjZhNEtaaHBoQUhLOVBTMm1aRmcx?= =?utf-8?B?TkVqaXFyRll2cnd2cTVWS1l6MEowRVhyYWhnYXlmcTFpYWorWFN2c0crejBM?= =?utf-8?B?dW5sb016K2JKM3R3YTgvTkpjNkhiZUF6dzZ4aGcrUkJqa29mVTh4c1lDQ2w4?= =?utf-8?B?aDZ4Q3UyektHd2FIZDR4T1VTdkNHbit6SXRwYWFVOFh1VHkyNDM2T1hONkN1?= =?utf-8?B?ZmM2bGxoNUtYSWNkNExUT1hFWldZbmpFcVZ0MHhyaWEzazd5Vnl2OGorWlQ2?= =?utf-8?B?ZllCRDB1YzJub0kyM3ZSZzJic3dTd24yano0OXhIQ0RkcjhUOVpTUnp1L25i?= =?utf-8?B?MEZ1b3I2NHM1eU1oNnpTdEpZQzBvSUp4RVl0dUV0VDRNWW5BaWhOV2pFcXdt?= =?utf-8?B?M3NPVmhEeXpobDl1bzdnWDVsUEhhaVlNM0xxMEtZdnlQSzZMeVd3ZDA3QWJr?= =?utf-8?B?azUreGlmWlpWMnNYNzJvWXlYak5LUVdqUzE3Nml3VzhpNFl3YzA4V0JGWE9j?= =?utf-8?B?a2V2WFhjdm5FeTdkckh6b1JHZFprRE9vQWlmc3JqZW5xZUFlaXZTMDRuN1RV?= =?utf-8?B?MlJDdUR4K0drQ1IvblYyYzJMUTNXT3RIS3cyVVpRY3ZnOXdvVnd2MlJ1ajh2?= =?utf-8?B?am9NU2thQWJhd016K0c0TmpwTnJvUjVEVi9GTCtXSWZWYmVMY2JSSndxZGpk?= =?utf-8?B?RThlMEpLL3Q0clQ0NXVZK1FaSER4UmhiM1R5WmJpNXBGcjQyd1JWdTJwVDFq?= =?utf-8?B?Y1BxZG1uYWhmaGtPeEZaTjhuZTBBQks1dGJiQUZWWk9uOGlOM1lCeERrbC9K?= =?utf-8?B?S0pseWlRbXYvSndUMHBDbEZZY0xOZmRkdGtzbjBxU1BINXpJeksrN3IySXB2?= =?utf-8?B?V0M0MTM4cURTQmtGeTZIQmRYREowMVpIeC9YRk5PZExXRFhneFZ3ejlNanlM?= =?utf-8?B?QWVDK05HcGExdUk3NWZCaFpRb0hnY3ZaalkrZ3dZTEp1cUUzekVramVRemk3?= =?utf-8?B?azVnVUpqN2d5TVRiTG42UFlNV09ZOWxpaGpHeEw4amRHMkZPU3RBTjF1NDlq?= =?utf-8?B?NzdFUGZJMzlhVFVYWmJWeUM5a3pReE1oZEtVUTFURGQ1M3BLU1g3SisrRVdZ?= =?utf-8?B?eTVYbjRPaFN0c0lvS09zNjJZeWtzcm4reDRlWlhtbGo0OWp3TnB4U1lLWHdS?= =?utf-8?B?aEpSaUs3aVM5OHFtN011alpidUpmOXZJM2htMEdIUEJ3WXZHR2RXdm1SYkR6?= =?utf-8?Q?Aay43IYiBGcBo4psdWrwqVOvC?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: df41d203-a232-4314-24c1-08db7288a37e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 18:52:18.8473 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zz1PjQbwef7P0uH0HnpZEeW6eBt5mCr4dYP/viV9ZFysjOjL31Dxk7BH9AqcdSXg X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8108 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/21/2023 3:43 PM, David Marchand wrote: > As reported by Ilya [1], unconditionally calling > rte_flow_get_restore_info() impacts an application performance for drivers > that do not provide this ops. > It could also impact processing of packets that require no call to > rte_flow_get_restore_info() at all. > > Register a dynamic mbuf flag when an application negotiates tunnel > metadata delivery (calling rte_eth_rx_metadata_negotiate() with > RTE_ETH_RX_METADATA_TUNNEL_ID). > > Drivers then advertise that metadata can be extracted by setting this > dynamic flag in each mbuf. > > The application then calls rte_flow_get_restore_info() only when required. > > Link: http://inbox.dpdk.org/dev/5248c2ca-f2a6-3fb0-38b8-7f659bfa40de@ovn.org/ > Signed-off-by: David Marchand > Acked-by: Andrew Rybchenko > Acked-by: Viacheslav Ovsiienko > Tested-by: Ali Alnubani > Acked-by: Ori Kam > Applied to dpdk-next-net/main, thanks.