From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE60442FB3; Wed, 2 Aug 2023 04:41:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55C45410DC; Wed, 2 Aug 2023 04:41:50 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id AC94840DDB for ; Wed, 2 Aug 2023 04:41:48 +0200 (CEST) Received: from dggpeml500011.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4RFx6j2MPLz1GDQ4; Wed, 2 Aug 2023 10:40:45 +0800 (CST) Received: from [10.67.101.191] (10.67.101.191) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 10:41:46 +0800 Message-ID: Date: Wed, 2 Aug 2023 10:41:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] app/testpmd: add flush multicast MAC address command To: Stephen Hemminger CC: , , , , , References: <20230801024304.2187484-1-huangdengdui@huawei.com> <20230801081821.0fcbf4d1@hermes.local> From: huangdengdui In-Reply-To: <20230801081821.0fcbf4d1@hermes.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.101.191] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500011.china.huawei.com (7.185.36.84) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/8/1 23:18, Stephen Hemminger 写道: > On Tue, 1 Aug 2023 10:43:04 +0800 > Dengdui Huang wrote: > >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index 0d0723f659..2d9d925776 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -494,6 +494,9 @@ static void cmd_help_long_parsed(void *parsed_result, >> "mac_addr remove (port_id) (XX:XX:XX:XX:XX:XX)\n" >> " Remove a MAC address from port_id.\n\n" >> >> + "mcast_addr flush (port_id)\n" >> + " To flush the set of multicast addresses.\n\n" >> + >> "mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)\n" >> " Set the default MAC address for port_id.\n\n" > > Why out this in middle of the mac_addr commands? better to be in logical or alpha order. Sorry Stephen, I made a mistake in my reply. It's already in logical order(mac_addr/mcast_addr add/remove---->other setting), the same order as in the doc. The order looks odd because the help command doesn't have a description of "multicast add/remove".Do you agree with this explanation?