From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2609EA00C4; Thu, 29 Sep 2022 14:41:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF39440694; Thu, 29 Sep 2022 14:41:20 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2383F40395 for ; Thu, 29 Sep 2022 14:41:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664455279; x=1695991279; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=HzaP+UFoMRrWo52fjapfZIQ2DDy2K1y3UzOc6xTjvN8=; b=KMBug27CR0UeGoSWLF0O2P0lD9QHlRTRAmyLym42zNALA1Xe+jeais4E H/Nj0xQDuftSY320RQjBsu6NKhcwx8vnKC0wTKr580fGq9N3IVNqw2PE4 A7sTMaFJgG7bmNxYRSzr7wCjdoR+PNzD373ns3q58rHlcaDVFz0hnHgio qKLnKjhFUk58iCl/JoZa7OQ9H5FETbMMxnCAc5NNombBfMSOjPZBimAor x1zY3ldUcjcn1VRQ3bED32PktF3y2gDhpG2vlhH2Vg7d5LCtAFwxVb/sC N0WCye4MvyZaIQkxEfyBxMaaaqrgoaUcd08l0+d4FtWUQMZTAaxrdI8Es A==; X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="300599132" X-IronPort-AV: E=Sophos;i="5.93,355,1654585200"; d="scan'208";a="300599132" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 05:41:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="867374958" X-IronPort-AV: E=Sophos;i="5.93,355,1654585200"; d="scan'208";a="867374958" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP; 29 Sep 2022 05:41:17 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 29 Sep 2022 05:41:17 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 29 Sep 2022 05:41:17 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 29 Sep 2022 05:41:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QI19KjbehXeFZR2bXonequWfu2SxCW/01YSIp26ZubHMHjCEgMwGdtb/xPeQCM0t3sfLNb/Uvn8CbO14d7okLjJMFSp/fcg993ScTtsBIGb7cmo0AAhQqj/rEArStDy3sPKFZ5xuflqOQNaz0bXVW8pSy6y5mDFfo1EMer9VaCZqYodV8D+QIqnfu+J44DqcT9qNFddN/Y8L+ZLyLeUC547rEAWY9cDUBZdqjbjSRyTzwtOWlt36cjX5I+Zf0m1mua+RfrTQJUFvVyw+MBq25GFSBpE9U58vJCcz1OzGSCpm1Uu5Y2+PRyXwGGoTWTvqRwgeZL8wlpUmKkPY1z5OUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kBoisTehKt7AOsXnoCb7Yr4+oStaqNOYj5B/+CP06zU=; b=fLPMW1vA2VBCZymj9nBpakPNlVm6Ns9gyS1Ni4GQfLlRaLEh3TTwvlMO79b8wfLQ0QXdT4b5JiOaEU7leFNoT/43bhtsDkW3/CdIAebBrjcicdWxdV7CYscbZiAdJAKhHzJ7n0oMyniP375u58w8vxYIVoZpgKZZ/kkGfsuf4VmCVrfVZZ0yhOQyeID+J98TtL0jr6ElbH4eIgHA/TJGmrjSrNV+Cm/4HZIxJu441BJ+sseszNaZix6m8Z7h4Jtk/XqVQFfJl12LV/NWAFAwogdHmoIxQZAxV7Bjlr6c2JO7Y52Ud5vK1qQ0XyOEInpaOHS7rBIAzdL72G4+R0+OZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CH3PR11MB7321.namprd11.prod.outlook.com (2603:10b6:610:150::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Thu, 29 Sep 2022 12:41:14 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%8]) with mapi id 15.20.5676.019; Thu, 29 Sep 2022 12:41:14 +0000 Message-ID: Date: Thu, 29 Sep 2022 13:41:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry Content-Language: en-US To: Konstantin Ananyev , "dev@dpdk.org" CC: "anatoly.burakov@intel.com" , Conor Walsh , David Hunt , Bruce Richardson , Nicolas Chautru , Fan Zhang , Ashish Gupta , Akhil Goyal , Fengchengwen , "Ray Kinsella" , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Jerin Jacob , Sachin Saxena , Hemant Agrawal , Ori Kam , "Honnappa Nagarahalli" , Konstantin Ananyev References: <24c49429394294cfbf0d9c506b205029bac77c8b.1657890378.git.anatoly.burakov@intel.com> <20220914092929.1159773-1-kevin.laatz@intel.com> <20220914092929.1159773-2-kevin.laatz@intel.com> <9a6fec15f9684d21bb4730596cceacff@huawei.com> <4af4b5d6-57a9-39a4-2197-a2acdc57156b@intel.com> From: Kevin Laatz In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0045.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::33) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB5872:EE_|CH3PR11MB7321:EE_ X-MS-Office365-Filtering-Correlation-Id: 9328f7e0-7960-4cf1-e7f0-08daa217e57f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ngwVEm59iX3UPXS2onoOfH9r+QVuv6T7xk0AEzbXBCX+u5cAz3RcTBPIQek07vsTTFFp6PIacMwvyCwWmNECLJGyghX3EoHi1x55sXdPLpqwiqhLLYDbMO0iytRtJEmNO85eYSA99L5c+6qIgaeg6DleiesJ76P/RXr1SyzW07RDuhtXK5kSXMMgcckueGlV7scMbJcp6xmIhv9128Lbq0VlRStiut5aYIeD/nH/oq5pAY+0QHrR+2ks+yDkS9nDMIVmN+IvHI6T+kk6iR8gXm2zdgaz1UXI8gpS/FrCp4VzUwNQ+APFaieJBvLEETiulcfUd1OsquAvvpPgviiMPIC6I4BE0YrLJxonds1DRwkN4xEZoe1M/f0/ELWMhqBKI8maR2wRmYrHGyQzGya64iej6V+j6ytCMeuaTNE2g7lYEUZ7qxWOXUlpH3hFxdia4MeJzPRr2Pu8/Kx4a5uydeo/vvGznIjATm2b1qt7brvTgOgKQeCMwi9WFV2fKAUqISoSo51KqsLglNNTA+dr2zML/cgZkW5s2RI/fFA0JwJDB3HiNWBpYMvO9xMR65a+fiAdrE32a3CV0c+KTnE2zxoUDUHxjO+M5PJWuFny7M+jmjRlM2XTAUCRZjsxaSDK5Lxw0g5IkT/j3BXw8WT6S/ImBE4uHP+odIKPVAznvL7+5lilceFPvlgmZTnNE4kW73Z/BLO8H/OlvQqk/BxPX9Q5bBjDOZqfEEbldZJeDSTJEx2iYakd0qaKbC4hncKsH9hpEfRIGyjQEUILwVIG7qwsAKuSSMyHhACLJmRyERk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(136003)(396003)(39860400002)(366004)(346002)(451199015)(41300700001)(53546011)(86362001)(66556008)(6512007)(66946007)(44832011)(26005)(66476007)(4326008)(31696002)(186003)(36756003)(5660300002)(7416002)(8936002)(2906002)(6506007)(8676002)(6666004)(316002)(2616005)(478600001)(54906003)(38100700002)(6486002)(82960400001)(83380400001)(110136005)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUdYTVUxZm9tQnpLc3dkOVU5ZzJ2czZMNkM3dEx6Lyswa3R5S3FlYUIyMXdF?= =?utf-8?B?eFIwN1BlYkNWMU5vVUhEVkJDUWpmTmRxVzN5dFhsSmpZTS9zTjl2ckpiRXo1?= =?utf-8?B?RlcwUG9jNTcrVEdDRDVhQzFDdHVBZzI1RTIzbjV5RG1TcTFFeEtCTWJPZURW?= =?utf-8?B?MDV1V1cwRTNNMU4xUWJGWWszQ2pjazJrWm13ejU2dTB6TjhOUm9oWlplMGhM?= =?utf-8?B?bGMvQWhDVVFGQ0NIeEhON3p3UTNNazhrdmJXTXNHUGp6dU1SRGtNZ1BwcGdv?= =?utf-8?B?bmJJUXFEV1FpMXlEYkhHa1VCVDJBR0FPM2FCTTFwN3JqaUdudHNMMUcrMVdX?= =?utf-8?B?WXpEQkpNYWM0dENxZEtxSWx3WU1vdmRsdnpGaWRCTVJITVExNHBmQXBKYjhz?= =?utf-8?B?QThvSGxVRThwZ283eWkxV2szVmVhTEsreHR4UlV6TmhqR3h1d3BVWmQ1OFRX?= =?utf-8?B?YU5POG0yeDdJOXd5V2Y4UlZBdEFEZ2FzS3U1V3ZJUXFialpjNzZiODNqSXVh?= =?utf-8?B?aE83ZFIyczYvUlRFWURZMVdrL2w2VFN4MVBsRnZ6WTZvQ3pYaDd5cXNtaVVS?= =?utf-8?B?Ky9lVVJpU3g2N3BaaXhnUjZidks1MTdVRGQ2MCtVNWZ5S2VQOTB4NXpwcWdN?= =?utf-8?B?UXlMUW9RRUNkUXduZnZRKzI1ZzlDaHlJbXgxZ1ZMTzNwWkJ4SjQvclVabVBx?= =?utf-8?B?V1JTK2piRkV3Tk1kSFlzbG95OHpXYXhZK05iZmdDeXMvREFnSS80aFF3T1B1?= =?utf-8?B?U2xSNlNHWGt2UDJ3SG81eHBIV3I4TEhGNHdLd3pVNklXOGRUc1QxdTBxQ25M?= =?utf-8?B?LzhrNzZYRVVHek9rK3Zxb1R3QmJIdWRQOUh1S0M0RnhZWFdheHhmWGxIREpi?= =?utf-8?B?dFdhQzlFbEdreHIyNDBFMGVxK0VNbU5OWStCNWNEN2lRUlJ2Z1pJTmJYYXJJ?= =?utf-8?B?UHdLZUFKNVN5NVdLWEFzYlI5QkdYWUJVdGlNUHBkci9LYjJXZW9ieUtReERE?= =?utf-8?B?ZWNjeHVSWXgxTDZSc2gyemsvK1B4bVR6MnJLdzR0SHBuczZxSjFQL1FZR0Vv?= =?utf-8?B?WjFUZTBIOVNZYnordXE2ZDd2aGVCVlpNYVlRbGI2Ykh4WHp0bFVSTmZTcmgx?= =?utf-8?B?dVpDSlFEYWZrV1l4dkE0aXI2Q0dwNE1ER292blorUSsxTGNCcTZBQmxncHB2?= =?utf-8?B?NlduRG0zNy9XVFFtWDBHSTlERWlyS2ZvS2hmL2M5V2pSYTkvVmhEYTNZRnE4?= =?utf-8?B?NVpIREVKVmJPU20yb0ZCMmhXbGpyYkpON1ZMTnV0SnJCYi8vWmNVVGlBM1d2?= =?utf-8?B?QklDRVlSVmdmcXprVmFEaCtBdmpxa3V3YnFDTXhxSWFiczNuOEg1TVBya0tn?= =?utf-8?B?WEcwaHVsRDdNVmYrc2cwcCtLOGNkM2FURkNEbjBuWUIzaEVMd2Z3cU82T3VT?= =?utf-8?B?SW5nNFpPV0xTQ3lGQStMVkZuVzhLS1crNnRnNzVhVEdncFBmWHpCN3RkMHlR?= =?utf-8?B?QndFRlFxbnJMeGxXNk9aTWk4VzU0cGNkMElhNlB0ejN0bGR0VUpHOWYxZVJl?= =?utf-8?B?YkJkUTRBSUU2bGhTYnZRRzlpNDBEY3g3OHNDMXRVY25zdklxSmdTVDI0WWk1?= =?utf-8?B?eVJZSEtpLzVBd1l2cjVnVkxuT3B6TGI5b3JZTlpra3p5K3pRTDJrQjdKZHBO?= =?utf-8?B?ZG45OFJQSWJIYUFZcUwybHpzNVhZUDNWdXZZQnlNSm84LzZ6TlBJU1NEbit2?= =?utf-8?B?SVo2ZzEwMnczOW5lMlZuN281dEh3NjlJbzVoZUNZbTBlM25lOFZLWGRycHNL?= =?utf-8?B?ek0zNjhOZ0lCS1JjQnFHUktrRC9kUkNlRUdEckpaaWRtaEZxMzJFeWwvRTdD?= =?utf-8?B?Zlg5ZmJ6dlR4dXoyRG5uUWNmM095Z2trd3B1SEhobkJUbWJtNWY4Ull0bGlY?= =?utf-8?B?eGpOZTNlcGowRXFxN0w0ZHFnNFNmRWxMTjRQRnlzdzVOUVVXYSswUmdOUi8r?= =?utf-8?B?c2xqTm0rbEVJWUo0ZDQ4MzNSaVgzbk9CNkdHVkwzTDhKRlVZNjdqTVJFOUJq?= =?utf-8?B?ZjJuUHJpcUN6SWE3a3d3NnJESFJGUUtwU05kQzRHTFZ3WHJqWDB0MGFLdHJL?= =?utf-8?B?eXFWVGFNN0ZTak5ISkRueFB5eHpSOWlveWF4R3lnRUU0TFB6N2lGOUJHeEJp?= =?utf-8?B?R0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9328f7e0-7960-4cf1-e7f0-08daa217e57f X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 12:41:14.7002 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: id+D4pck+60JgO9L9ARRzSKzmmqslqNJUGFNipEdBc9+2WbxYz7GiKTkSmfXy4hXC/+pX1mlBMGZdB7822AmfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7321 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 26/09/2022 10:37, Konstantin Ananyev wrote: > Hi Kevin, > >>>> Currently, there is no way to measure lcore poll busyness in a passive way, >>>> without any modifications to the application. This patch adds a new EAL API >>>> that will be able to passively track core polling busyness. >>>> >>>> The poll busyness is calculated by relying on the fact that most DPDK API's >>>> will poll for work (packets, completions, eventdev events, etc). Empty >>>> polls can be counted as "idle", while non-empty polls can be counted as >>>> busy. To measure lcore poll busyness, we simply call the telemetry >>>> timestamping function with the number of polls a particular code section >>>> has processed, and count the number of cycles we've spent processing empty >>>> bursts. The more empty bursts we encounter, the less cycles we spend in >>>> "busy" state, and the less core poll busyness will be reported. >>>> >>>> In order for all of the above to work without modifications to the >>>> application, the library code needs to be instrumented with calls to the >>>> lcore telemetry busyness timestamping function. The following parts of DPDK >>>> are instrumented with lcore poll busyness timestamping calls: >>>> >>>> - All major driver API's: >>>> - ethdev >>>> - cryptodev >>>> - compressdev >>>> - regexdev >>>> - bbdev >>>> - rawdev >>>> - eventdev >>>> - dmadev >>>> - Some additional libraries: >>>> - ring >>>> - distributor >>>> >>>> To avoid performance impact from having lcore telemetry support, a global >>>> variable is exported by EAL, and a call to timestamping function is wrapped >>>> into a macro, so that whenever telemetry is disabled, it only takes one >>>> additional branch and no function calls are performed. It is disabled at >>>> compile time by default. >>>> >>>> This patch also adds a telemetry endpoint to report lcore poll busyness, as >>>> well as telemetry endpoints to enable/disable lcore telemetry. A >>>> documentation entry has been added to the howto guides to explain the usage >>>> of the new telemetry endpoints and API. >>> As was already mentioned by other reviewers, it would be much better >>> to let application itself decide when it is idle and when it is busy. >>> With current approach even for constant polling run-to-completion model there >>> are plenty of opportunities to get things wrong and provide misleading statistics. >>> My special concern - inserting it into ring dequeue code. >>> Ring is used for various different things, not only pass packets between threads (mempool, etc.). >>> Blindly assuming that ring dequeue returns empty means idle cycles seams wrong to me. >>> Which make me wonder should we really hard-code these calls into DPDK core functions? >>> If you still like to introduce such stats, might be better to implement it via callback mechanism. >>> As I remember nearly all our drivers (net, crypto, etc.) do support it. >>> That way our generic code will remain unaffected, plus user will have ability to enable/disable >>> it on a per device basis. >> Thanks for your feedback, Konstantin. >> >> You are right in saying that this approach won't be 100% suitable for >> all use-cases, but should be suitable for the majority of applications. > First of all - could you explain how did you measure what is the 'majority' of DPDK applications? > And how did you conclude that it definitely work for all the apps in that 'majority'? > Second what bother me with that approach - I don't see s clear and deterministic way > for the user to understand would that stats work properly for his app or not. > (except manually ananlyzing his app code). All of the DPDK example applications we've tested with (l2fwd, l3fwd + friends, testpmd, distributor, dmafwd) report lcore poll busyness and respond to changing traffic rates etc. We've also compared the reported busyness to similar metrics reported by other projects such as VPP and OvS, and found the reported busyness matches with a difference of +/- 1%. In addition to the DPDK example applications, we've have shared our plans with end customers and they have confirmed that the design should work with their applications. >> It's worth keeping in mind that this feature is compile-time disabled by >> default, so there is no impact to any application/user that does not >> wish to use this, for example applications where this type of busyness >> is not useful, or for applications that already use other mechanisms to >> report similar telemetry. > Not sure that adding in new compile-time option disabled by default is a good thing... > For me it would be much more preferable if we'll go through a more 'standard' way here: > a) define clear API to enable/disable/collect/report such type of stats. > b) use some of our sample apps to demonstrate how to use it properly with user-specific code. > c) if needed implement some 'silent' stats collection for limited scope of apps via callbacks - > let say for run-to-completion apps that do use ether and crypto devs only. With the compile-time option, its just one build flag for lots of applications to silently benefit from this. > However, the upside for applications that do >> wish to use this is that there are no code changes required (for the >> most part), the feature simply needs to be enabled at compile-time via >> the meson option. >> >> In scenarios where contextual awareness of the application is needed in >> order to report more accurate "busyness", the >> "RTE_LCORE_POLL_BUSYNESS_TIMESTAMP(n)" macro can be used to mark >> sections of code as "busy" or "idle". This way, the application can >> assume control of determining the poll busyness of its lcores while >> leveraging the telemetry hooks adding in this patchset. >> >> We did initially consider implementing this via callbacks, however we >> found this approach to have 2 main drawbacks: >> 1. Application changes are required for all applications wanting to >> report this telemetry - rather than the majority getting it for free. > Didn't get it - why callbacks approach would require user-app changes? > In other situations - rte_power callbacks, pdump, etc. it works transparent to > user-leve code. > Why it can't be done here in a similar way? From my understanding, the callbacks would need to be registered by the application at the very least (and the callback would have to be registered per device/pmd/lib). > >> 2. Ring does not have callback support, meaning pipelined applications >> could not report lcore poll busyness telemetry with this approach. > That's another big concern that I have: > Why you consider that all rings will be used for a pipilines between threads and should > always be accounted by your stats? > They could be used for dozens different purposes. > What if that ring is used for mempool, and ring_dequeue() just means we try to allocate > an object from the pool? In such case, why failing to allocate an object should mean > start of new 'idle cycle'? Another approach could be taken here if the mempool interactions are of concern. From our understanding, mempool operations use the "_bulk" APIs, whereas polling operations use the "_burst" APIs. Would only timestamping on the "_burst" APIs be better here? That way the mempool interactions won't be counted towards the busyness. Including support for pipelined applications using rings is key for a number of usecases, this was highlighted as part of the customer feedback when we shared the design. > >> Eventdev is another driver which would be completely missed with this >> approach. > Ok, I see two ways here: > - implement CB support for eventdev. > -meanwhile clearly document that this stats are not supported for eventdev scenarios (yet).