From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52147A034C; Fri, 19 Aug 2022 20:13:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D93AE40694; Fri, 19 Aug 2022 20:13:27 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 8C87540689 for ; Fri, 19 Aug 2022 20:13:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660932805; x=1692468805; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=YW7NGFEZJc+LByB7PZzIgciEg2m0m8dGYK+Dv/eZ7FA=; b=b9+8nbsGwvA95RRGELf1i8ZoPDOo4/JpVvKBX3tmATG4Ydziit0lR9d4 InwfeX7F/1VG/Nbpbm+RRuc8XSzwxExDcrXW/5p+50+LXPox0NuFGUTCX +Iz7BRN/VXWXLRYuY/S0Glw3aNxh+J/fzhCWxgkFwim9bQomw48R5HcCT UfUlN9HY6/JB1ext7/MBAiKCmnx95QFZElAQGKlV3TDa0MiI0rSP2kk4K cZLHzTWq/fr2dW8OVHadNdL8NuMlP7Hm2GG8F0IFuZQNdHWa+1QOcziVt 2y4a6Pr5XgFU4DHAT+IRbrzGFi2hoHqIKehsN4DfAeKwQVOOo8UjbxxHt Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10444"; a="294346252" X-IronPort-AV: E=Sophos;i="5.93,248,1654585200"; d="scan'208,217";a="294346252" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2022 11:13:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,248,1654585200"; d="scan'208,217";a="734488665" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 19 Aug 2022 11:13:23 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 19 Aug 2022 11:13:22 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 19 Aug 2022 11:13:22 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 19 Aug 2022 11:13:22 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 19 Aug 2022 11:13:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g2942GuVzqkkIA9UQNl3bJRi8IZ/HIZGvF2LWuMfR7RYW8VXnjzvMf/9zU9z9+rMBLz4nrZqa6vMv1iFAufPGAyKNxKZQ+RvIoI+MODR2/cPFdxroJJO7wUTPZEnT4AXjWo2kye/1vFGTEMuaDYOT4EEFFdbgBSjJ2blUWOjswUHaFgL94Cubq5igpWavrXmsJJVP6cDvTzl3/JtovF4+ZWZdNK2bLpiicenH0z040j8sjzV0VrT5AVPS65VhE/wiat/VIKMa2By6io40mOtg0XzfZwO7JfWQG1VxPxI1CUhy9hRSFzDffk2vYg/DB2b1TkbmdoKN5TDW/0vuWjevQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CQ/cqyf8AXLK7butT/4EbQ4n3zOnXpJytBJEnB0kmHk=; b=SRR/bC7h5uiVlD98PGjia6nsOdz2ejP3/eNPwbzqvmGAjetV8ztxCoDspgoS/jQ8COfNYw2guAzzGnNCcGvbZv9UOVLxtfOpJF0IFEynu+9Al4+TXK6cbTfCPjuZbhG/siFUSs/4hjVe94fTwH0EBvf471JfFRKfu+g84OaXPuhTkh0y2mIF1tJHDRbiQnosNvaoxTdUT/+xCpF3brFRIQoc3944ZLVcWIk9txP2CF3Xz+7UpuTnIbgm5YbskgfUSvWrKUF0wv5VwEugfLJI/rDc6I/xE1YMhnvJDAXaQ0GrHfOJC92FKG4NBla10prpc9Tnjo+O9wfMWDG1cQbgtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BL1PR11MB6025.namprd11.prod.outlook.com (2603:10b6:208:390::16) by MN2PR11MB4509.namprd11.prod.outlook.com (2603:10b6:208:192::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19; Fri, 19 Aug 2022 18:13:19 +0000 Received: from BL1PR11MB6025.namprd11.prod.outlook.com ([fe80::b996:1aac:16ee:993d]) by BL1PR11MB6025.namprd11.prod.outlook.com ([fe80::b996:1aac:16ee:993d%3]) with mapi id 15.20.5546.018; Fri, 19 Aug 2022 18:13:19 +0000 Content-Type: multipart/alternative; boundary="------------EH0Jh2XSNiCg7AEi65oM6PQd" Message-ID: Date: Fri, 19 Aug 2022 11:13:16 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [dpdk-kmods v2] windows/netuio: fix BAR parsing Content-Language: en-US To: Pallavi Kadam , CC: , , , , References: <20220802191058.1779-1-pallavi.kadam@intel.com> <20220811221723.2124-1-pallavi.kadam@intel.com> From: "Menon, Ranjit" In-Reply-To: <20220811221723.2124-1-pallavi.kadam@intel.com> X-ClientProxiedBy: BYAPR06CA0011.namprd06.prod.outlook.com (2603:10b6:a03:d4::24) To BL1PR11MB6025.namprd11.prod.outlook.com (2603:10b6:208:390::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b62a4524-1b04-404e-c883-08da820e7ec1 X-MS-TrafficTypeDiagnostic: MN2PR11MB4509:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AuWD8LvXdrCCeHazoq0LJf+MgT0yZHFtZVeQH/rueqA4u0U5zgk9EKFBHNOkTAz4pBZYGhPjz4FjH0HNg00a3aPFZbpQkfbyYSS0z96T35U19Y/ks3+6ynJhnuF0OIwxYcLiSRRE7wN02DA/1UA+jSTgWFZ7N0XOCWkd6ANGX0FvFgCtF3VMzFPljn3sy4DbbNPTYp4vJ4gxf93eOE1De2O7MS4vzN9UGjys+C7MFne2bUDMgVY6Q0udNVy2OscCTFkJZKOEd24V01LgczFq/rPe6cKRbKX+3liN/qI1Q0MFCFKkiWs5gzbJ42/oD5OlejBdSG5nKFaMH7+gQ5BWhz0J0x5LzpW0qIVMdlZjhrt+s1pyd7mImk4ovLr4MB2PmLnjnDLlMHfwH3yRwUPvOovSeBELr/saGVVXMg333cAZe/KeQHJyZ2aTHWa/C5iW/FevlRtFHgMqo9xOOFR5jsRm7wIj/9CdCKGBXqNcUfWV0z32uahiLy3w4hTbV2CWmuvL6weDcQPf0X9BYUMPEBVZX0x9Gywa49pMfaTXX3kYNWdzEJmQKvJmK0l6mihGyrUA0Ct7W8Prss3yGJ9uqKR+qmQg/TxqTXHwoVXluMYMqnIqE/tC1dBkiSJ/mmk58RcunbyYR4J+2/EjCLEccVM49Pe3FnHO6IS1TSxJ65epLCSSksRUFAsObloQL4WhwM6AqjVOd8weAdZ8OKULSzv7xCwMzyBnJwrGLMa71pe3648tArz9Be3i5FvInArqrx9F23u3+PKa7WO3NGmA54L67TjtMlSFqFCQhoQBA24= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL1PR11MB6025.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(396003)(366004)(39860400002)(136003)(36756003)(41300700001)(6486002)(66946007)(66476007)(107886003)(4326008)(316002)(478600001)(6666004)(31686004)(66556008)(8676002)(8936002)(2906002)(26005)(33964004)(53546011)(82960400001)(86362001)(6512007)(31696002)(2616005)(6506007)(186003)(5660300002)(83380400001)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1BpT0F4eEpmV3lFc2duYnNpalZyK1lFUlhmMUt0c2N4ZnZvbEYvVDgwQzVV?= =?utf-8?B?Sisxc0hqZStjSldGWXFVV0hiMjV1QzN5QVVLemtkTzB5cmx5ODRsNkZ0d3p6?= =?utf-8?B?SzExK1V0K1FlTUtLYi9uQ3ZKRUlwZ1FoeW16SUhnQjZ3eldhNEV4cGo5M3Ax?= =?utf-8?B?TDRCZ2Q5cUpnL2FoM2QzR201TE1veWtqbjZPc1RnODRDRm1CRTNyN0U1UDBH?= =?utf-8?B?c3EvN0IzMnArWk1aVVZQODR5VFlqU0FrSktEN2NsVDcvaStNMytSWitrcXla?= =?utf-8?B?Y3lHMUJQYWxMY3JMM1hMSUlycU42cnlRTFl5emRtVTBFRnpZQS9GOS9ZaCty?= =?utf-8?B?aktXQWxJelk1cnowTzZieDVLWXN2M3hDcFM2a1FmL3MwNzdoQVBVTEprbndk?= =?utf-8?B?MWRiK0kwaXNBNG9wTGc4WXNhSWVlVGFzOW9HN2lDa29ocTlNaDhkYWM5UkVh?= =?utf-8?B?NldXRVZaZWtUVWMxWTExcXl5MzdqUU1FSTJrNG9nRGtZb0hEUXVBNTRHcnhL?= =?utf-8?B?UGlHRUgzdTFLSjRQajN6bEJ4YU9HdVpMZS9MdXpNaHBTMjMwTWZEWGpZRnZ0?= =?utf-8?B?NDlVZlpFTzBiZFRuLzNuS0kvRUZaRWZNN3NLelkyV3MyNE02K1lpQzcxUlU2?= =?utf-8?B?ekNqNVN6ZjNORENSUytHUUhkbmJlOEUyS0tpM0NkcWlLMEMxWmc1V1BsSk5E?= =?utf-8?B?WGlaZWR3YlFZZzZXRTByN2JSVG5CSlZoZEV2ckdEb29uWWhLdC94cU1TTGNl?= =?utf-8?B?UWlydFRYK05jTTFRWlJmaHlwSEV0RUFJMHRqU3VyNHZYcjViLzhKdzgxdldV?= =?utf-8?B?UkJudyt4eUlKNDdUTnVPMjIybEswTGJWdFdWcW5YdHlyRHpUMFdXcUh5YWhY?= =?utf-8?B?QW9MT0hNUzd1NXJoL0dKK1VJU2hUeDY2b2JsWXhHQ2FMMzJHcFhtM2sxR3RY?= =?utf-8?B?U2dRTmx0bnFVeWpYaC8xckxSdW1ERk5CTXVBUmUweVltb1JVNE8yVTJhdkUz?= =?utf-8?B?ZnlockY1QmM4OC9lWS9qaWoyRUVkZXdzV0VXY2lnRlJvRjFtY1BGalk4dzR3?= =?utf-8?B?NUU0WTJhdSsvZDh4Q1J5dWNLMHpTei91bnozVkxCZ0c1ckdKVmNENlhSYWY1?= =?utf-8?B?WnZYdnNZV3ZhQkZ1VEVlODNiNE9CNXZtTWtBVGdPVmJvQ1lXY3hzZU5iZlph?= =?utf-8?B?V3c3OUZ6a3FqbDE1bEdRQ1JDY3N3cVh0OTkzNXh3UGFteEsrNDNyWUVvOU9P?= =?utf-8?B?RzZ2M0xrZzY0dGlOK1NvbG0zUDJtMERlS1NYMzNIMGEzcjVKL3h6Q2Y5eUtp?= =?utf-8?B?RXhGSW52SGN2VWJ3QmpxMy8xU3lWTkl4ZGJtYitXa0pybmRudEtiYnVGOHVj?= =?utf-8?B?Q21EcUVrenpEMmUvWW1GcWwxR09MMXVZV3dxelRET29TNFkxb0NmYW5xb0pl?= =?utf-8?B?OHRraWNsNVBqazlXRnlSVzU3KzkwYmNiYUJqNkp5RFNzNzJMZWlGeFgvcmZ4?= =?utf-8?B?cVVkYmk3Yyt3TEFhT1NyL0FRa0IzRFBkSlp4MlpOL2hXUGNlNDlIUkZnVFI1?= =?utf-8?B?Sm45Tjg4RlpXWmdWckVNakhrdkRpbUxORllMQVFWWEJDU0FlV0VqUDhnYVo5?= =?utf-8?B?Nzh5OXpqMzRhSkUrSEZZNEVZeVF0bDY3R2QvaE9IMzg3VW9uUVV3d3N6Nitx?= =?utf-8?B?TjgyMkJGbHdPSWx2TGhCTXJ5TjlnQndkUnZRaXlFaENWckd0blczYXp3dmV6?= =?utf-8?B?RmNNN2FJUC9SSmV0bGZiZUVyckk4UkE0RWlsMU5sbWczWTIrYXdHc2VzNlpB?= =?utf-8?B?dlYxN0FlR08wdEVyNmlMKzhwYVlSQlF5UGh2eXJDd1NpNVIxUDMyaUlPUkhy?= =?utf-8?B?aXlDTWdqdXg1SlhCeHEzbUFaQ3dhMnBoVDdsaEFLRkZxZ3NLTWN6V2hMMmFX?= =?utf-8?B?ZkM4dkE5RVlPNkRSQ2hSV3dMelg3T2xTZjRjb3UxUmljLzE5VHF3bWQrd01i?= =?utf-8?B?ODFLZWpKME9CR2dGRHBJQUxQM1duNFUzbFZzcytSQ29IMjV0ckNFTXp0c1JD?= =?utf-8?B?RjN3eXd2bFpVR2pjZWtiVm9RbXVsSVA5L3MxQ0RaZGtGbStGMlFTS0pZVkl5?= =?utf-8?B?M3VQbkpDTlpTMkhmZkFlTXhJakFucDlkS2lHUmwvSkNQcGI1OGpmcDN4aEl2?= =?utf-8?B?aEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b62a4524-1b04-404e-c883-08da820e7ec1 X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB6025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 18:13:19.7565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jLLJwU46DoHo2Mly+WefPe5Mhg3P8jjPUUw69yKdbQ0IvNYRyiQ2fDX5k1S+XmZoRGfIx+P1vj3qnGGkacQLzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4509 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------EH0Jh2XSNiCg7AEi65oM6PQd Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 8/11/2022 3:17 PM, Pallavi Kadam wrote: > Current code was always checking the 'prev_bar & PCI_TYPE_64BIT' > though only the first BAR slot of a 64-bit BAR contains flags. > Also for certain PCIe devices, BAR values were not continuous. > This patch fixes this incorrectness and maps the BAR addresses > correctly. > > Reported-by: Qiao Liu > Suggested-by: Dmitry Kozlyuk > Signed-off-by: Dmitry Kozlyuk > Tested-by: Pallavi Kadam > --- > windows/netuio/netuio_dev.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > Acked-by: Ranjit Menon --------------EH0Jh2XSNiCg7AEi65oM6PQd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit
On 8/11/2022 3:17 PM, Pallavi Kadam wrote:
Current code was always checking the 'prev_bar & PCI_TYPE_64BIT'
though only the first BAR slot of a 64-bit BAR contains flags.
Also for certain PCIe devices, BAR values were not continuous.
This patch fixes this incorrectness and maps the BAR addresses
correctly.

Reported-by: Qiao Liu <qiao.liu@intel.com>
Suggested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
---
 windows/netuio/netuio_dev.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

Acked-by: Ranjit Menon <ranjit.menon@intel.com>

--------------EH0Jh2XSNiCg7AEi65oM6PQd--