From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A411A0C4D; Fri, 13 Aug 2021 11:20:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25F3A40DF4; Fri, 13 Aug 2021 11:20:56 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 6227940140 for ; Fri, 13 Aug 2021 11:20:54 +0200 (CEST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4GmJ1t3RKzz1CWFv; Fri, 13 Aug 2021 17:20:34 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 13 Aug 2021 17:20:51 +0800 Received: from [10.40.190.165] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 13 Aug 2021 17:20:51 +0800 To: "Walsh, Conor" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Richardson, Bruce" , "jerinj@marvell.com" , "jerinjacobk@gmail.com" , "andrew.rybchenko@oktetlabs.ru" CC: "dev@dpdk.org" , "mb@smartsharesystems.com" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" , "maxime.coquelin@redhat.com" , "honnappa.nagarahalli@arm.com" , "david.marchand@redhat.com" , "sburla@marvell.com" , "pkapoor@marvell.com" , "Ananyev, Konstantin" References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <1628596454-32918-1-git-send-email-fengchengwen@huawei.com> <1628596454-32918-6-git-send-email-fengchengwen@huawei.com> From: fengchengwen Message-ID: Date: Fri, 13 Aug 2021 17:20:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v14 5/6] doc: add DMA device library guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Conor, Already sent v15, Most of feedback modified, unmodified inline Thanks. On 2021/8/10 23:27, Walsh, Conor wrote: > [snip] > > Hi Chengwen, > I have included some feedback to improve the grammar and readability > of the docs inline. > [snip] >> +the EAL command line options. >> + >> +And then dmadevs are dynamically allocated by > > ^ Change "And then" to "After DPDK initialization". It is part of DPDK initialization, I modify by other ways. > >> rte_dmadev_pmd_allocate() based on >> +the number of hardware DMA channels. [snip] >> +The first API returns the number of operation requests completed >> successfully, >> +the second API returns the number of operation requests completed which >> may >> +successfully or failed and also with meaningful status code. > > Replace above line with the following: > "``rte_dmadev_completed`` will return the number of successfully completed operations. > ``rte_dmadev_completed_status`` will return the total number of completed operations I remove the 'total' because the return limited by nb_cpls. > along with the status of each operation (filled into the ``status`` array passed by user)> >> Also these two >> +APIs could return the last completed operation's ring_idx which will help to >> +track application-defined circular ring. > > Replace the last line with this: > "These two APIs can also return the last completed operations ``ring_idx`` which > could help developers track operations within their own application-defined rings." I change the developers to user. > > With the improvements suggested above, > Acked-by: Conor Walsh > > Thanks, > Conor. > . >