Re: [dpdk-dev] [RFC] remove unused functions

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 11/19/20 4:52 AM, Ferruh Yigit wrote:
> diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c
> index 55d4856f9e..942c5f145b 100644
> --- a/lib/librte_vhost/fd_man.c
> +++ b/lib/librte_vhost/fd_man.c
> @@ -100,21 +100,6 @@ fdset_add_fd(struct fdset *pfdset, int idx, int fd,
>  	pfd->revents = 0;
>  }
>  
> -void
> -fdset_init(struct fdset *pfdset)
> -{
> -	int i;
> -
> -	if (pfdset == NULL)
> -		return;
> -
> -	for (i = 0; i < MAX_FDS; i++) {
> -		pfdset->fd[i].fd = -1;
> -		pfdset->fd[i].dat = NULL;
> -	}
> -	pfdset->num = 0;
> -}
> -
>  /**
>   * Register the fd in the fdset with read/write handler and context.
>   */
> diff --git a/lib/librte_vhost/fd_man.h b/lib/librte_vhost/fd_man.h
> index 3ab5cfdd60..f0157eeeed 100644
> --- a/lib/librte_vhost/fd_man.h
> +++ b/lib/librte_vhost/fd_man.h
> @@ -39,8 +39,6 @@ struct fdset {
>  };
>  
>  
> -void fdset_init(struct fdset *pfdset);
> -
>  int fdset_add(struct fdset *pfdset, int fd,
>  	fd_cb rcb, fd_cb wcb, void *dat);
>  

For Vhost changes:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

For the patch in general, I think it would better be split per driver/lib.

Thanks,
Maxime