From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5160DA04B1; Mon, 23 Nov 2020 17:20:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B7F1C8E6; Mon, 23 Nov 2020 17:20:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 79ECD160 for ; Mon, 23 Nov 2020 17:20:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606148429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jue3yDLhehYFRUiOR1R01+QQ14Y0hDluNNnkrJgdQU4=; b=U24lEcN3auYGn0XmMywLfeTwZ/7hA77KCfmbqi6kc+z6jeVMV1aYNfOnaSCDCK9O1TWhmm rl1Szm2ynqJI0ES4M+miWOO7H9jN5ibq4dvhCFvVK1TAKrC4vfnsa0k9oqvJYacRbb/jmo 1U7ePwCPhpddMFCY5EpFRuWWT7wxuwY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-VShFTYKqP4OWdHkAANg_SA-1; Mon, 23 Nov 2020 11:20:27 -0500 X-MC-Unique: VShFTYKqP4OWdHkAANg_SA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3DB2380363C; Mon, 23 Nov 2020 16:20:21 +0000 (UTC) Received: from [10.36.110.64] (unknown [10.36.110.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96BC01002382; Mon, 23 Nov 2020 16:20:06 +0000 (UTC) To: Ferruh Yigit , Jerin Jacob , Cristian Dumitrescu , Hemant Agrawal , Sachin Saxena , Ray Kinsella , Neil Horman , Rosen Xu , Jingjing Wu , Beilei Xing , Nithin Dabilpuram , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Gagandeep Singh , Somalapuram Amaranath , Akhil Goyal , Jay Zhou , Timothy McDaniel , Liang Ma , Peter Mccarthy , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Rasesh Mody , Shahed Shaikh , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Rahul Lakkireddy , Jeff Guo , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Qi Zhang , Xiao Wang , Qiming Yang , Alfredo Cardigliano , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Heinrich Kuhn , Harman Kalra , Kiran Kumar K , Andrew Rybchenko , Jasvinder Singh , Jiawen Wu , Jian Wang , Tianfei zhang , Ori Kam , Guy Kaneti , Anatoly Burakov , Chenbo Xia Cc: dev@dpdk.org References: <20201119035238.3653702-1-ferruh.yigit@intel.com> From: Maxime Coquelin Message-ID: Date: Mon, 23 Nov 2020 17:20:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201119035238.3653702-1-ferruh.yigit@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] remove unused functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/19/20 4:52 AM, Ferruh Yigit wrote: > diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c > index 55d4856f9e..942c5f145b 100644 > --- a/lib/librte_vhost/fd_man.c > +++ b/lib/librte_vhost/fd_man.c > @@ -100,21 +100,6 @@ fdset_add_fd(struct fdset *pfdset, int idx, int fd, > pfd->revents = 0; > } > > -void > -fdset_init(struct fdset *pfdset) > -{ > - int i; > - > - if (pfdset == NULL) > - return; > - > - for (i = 0; i < MAX_FDS; i++) { > - pfdset->fd[i].fd = -1; > - pfdset->fd[i].dat = NULL; > - } > - pfdset->num = 0; > -} > - > /** > * Register the fd in the fdset with read/write handler and context. > */ > diff --git a/lib/librte_vhost/fd_man.h b/lib/librte_vhost/fd_man.h > index 3ab5cfdd60..f0157eeeed 100644 > --- a/lib/librte_vhost/fd_man.h > +++ b/lib/librte_vhost/fd_man.h > @@ -39,8 +39,6 @@ struct fdset { > }; > > > -void fdset_init(struct fdset *pfdset); > - > int fdset_add(struct fdset *pfdset, int fd, > fd_cb rcb, fd_cb wcb, void *dat); > For Vhost changes: Reviewed-by: Maxime Coquelin For the patch in general, I think it would better be split per driver/lib. Thanks, Maxime