From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>, <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id
Date: Tue, 28 Sep 2021 09:34:56 +0800 [thread overview]
Message-ID: <bac4eac5-6987-2883-128e-b6d3ade31bda@huawei.com> (raw)
In-Reply-To: <1620272768-42421-2-git-send-email-humin29@huawei.com>
Hi, Thomas,
any comments?
在 2021/5/6 11:46, Min Hu (Connor) 写道:
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> In DPDK, 'rte_socket_id' means the running socket while
> 'rte_eth_dev_socket_id' is the device socket. For better performance,
> memory which queue setup used and device should be in the same socket.
>
> This patch make sure it calls rte_eth_dev_socket_id API to get device
> socket_id when setting ringparam.
>
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> examples/ethtool/lib/rte_ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
> index 4132516..b2e45f5 100644
> --- a/examples/ethtool/lib/rte_ethtool.c
> +++ b/examples/ethtool/lib/rte_ethtool.c
> @@ -465,12 +465,12 @@ rte_ethtool_set_ringparam(uint16_t port_id,
> return stat;
>
> stat = rte_eth_tx_queue_setup(port_id, 0, ring_param->tx_pending,
> - rte_socket_id(), NULL);
> + rte_eth_dev_socket_id(port_id), NULL);
> if (stat != 0)
> return stat;
>
> stat = rte_eth_rx_queue_setup(port_id, 0, ring_param->rx_pending,
> - rte_socket_id(), NULL, rx_qinfo.mp);
> + rte_eth_dev_socket_id(port_id), NULL, rx_qinfo.mp);
> if (stat != 0)
> return stat;
>
>
next prev parent reply other threads:[~2021-09-28 1:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 10:14 [dpdk-dev] [PATCH 0/2] fix bugs for ethtool APP Min Hu (Connor)
2021-04-08 10:14 ` [dpdk-dev] [PATCH 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id Min Hu (Connor)
2021-04-20 0:57 ` Thomas Monjalon
2021-04-20 9:05 ` Min Hu (Connor)
2021-04-20 9:37 ` Thomas Monjalon
2021-04-08 10:14 ` [dpdk-dev] [PATCH 2/2] examples/ethtool: add closing port operation Min Hu (Connor)
2021-04-20 0:59 ` Thomas Monjalon
2021-04-20 9:10 ` Min Hu (Connor)
2021-04-20 9:38 ` Thomas Monjalon
2021-05-06 3:46 ` [dpdk-dev] [PATCH v2 0/2] fix bugs for ethtool APP Min Hu (Connor)
2021-05-06 3:46 ` [dpdk-dev] [PATCH v2 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id Min Hu (Connor)
2021-09-28 1:34 ` Min Hu (Connor) [this message]
2021-05-06 3:46 ` [dpdk-dev] [PATCH v2 2/2] examples/ethtool: add closing port operation Min Hu (Connor)
2021-09-28 1:22 ` Min Hu (Connor)
2021-11-17 17:15 ` David Marchand
2021-06-28 3:22 ` [dpdk-dev] [PATCH v2 0/2] fix bugs for ethtool APP Min Hu (Connor)
2021-07-17 2:24 ` Min Hu (Connor)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bac4eac5-6987-2883-128e-b6d3ade31bda@huawei.com \
--to=humin29@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).