DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: wangyunjian <wangyunjian@huawei.com>, dev@dpdk.org
Cc: keith.wiles@intel.com, jerry.lilijun@huawei.com,
	xudingke@huawei.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix unexpected link handler
Date: Thu, 16 Apr 2020 16:06:34 +0100	[thread overview]
Message-ID: <badc8d4b-0892-b981-0f08-c823ee2bbba1@intel.com> (raw)
In-Reply-To: <1587045052-16708-1-git-send-email-wangyunjian@huawei.com>

On 4/16/2020 2:50 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> The nic's interrupt source has some active handler, which maybe call
> tap_dev_intr_handler() to set link handler. We should cancel the link
> handler before close fd to prevent executing the link handler. It
> triggers segfault.
> 
> Call Trace:
>    0x00007f15e08dad99 in __rte_panic (Error adding fd %d epoll_ctl, %s\n")
>    0x00007f15e08e9b87 in eal_intr_thread_main ()
>    0x00007f15e249be15 in start_thread ()
>    0x00007f15d5322f9d in clone ()
> 
> Fixes: c0bddd3a057f ("net/tap: add link status notification")
> CC: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.


      reply	other threads:[~2020-04-16 15:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 13:50 wangyunjian
2020-04-16 15:06 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=badc8d4b-0892-b981-0f08-c823ee2bbba1@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerry.lilijun@huawei.com \
    --cc=keith.wiles@intel.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).