From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) by dpdk.org (Postfix) with ESMTP id BFA7D2C69 for ; Fri, 29 Apr 2016 14:15:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1716; q=dns/txt; s=iport; t=1461932119; x=1463141719; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jk5ycEh0DTY9mE3/IMRi39wqdhDXQ/1UgW4Y5eAhQV0=; b=eA/bZFv1DR/OEmOj7Y9/deh+17/bMt8GoyLkpJiYvrRtrnwYWTOMDmfk ggCAmH3buAK6ELmhUMQFcTtP2erBGuxFKXIKi+Q3yY4e8JKKfpS6vG78U HDBZ6e2Z7W3Rfr28GMlxW7+dumTiOL6hETw6ckwNtfQZaSke8fvQN0Znu k=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AOAgAmTyNX/5FdJa1egzhTfQa3XIIPA?= =?us-ascii?q?Q2BdiKFbQKBLzgUAQEBAQEBAWUnhEEBAQEEOjIKAwwEAgEIEQQBAR8JBzIUCQg?= =?us-ascii?q?CBAENBQiIIg7DfQEBAQEBAQEBAQEBAQEBAQEBAQEBARWGIYNKgQKKEwWHb4Vni?= =?us-ascii?q?j0BhXuIFII8jFyGPYhyAR4BAUKCBRuBS2wBiAF/AQEB?= X-IronPort-AV: E=Sophos;i="5.24,551,1454976000"; d="scan'208";a="267730364" Received: from rcdn-core-9.cisco.com ([173.37.93.145]) by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Apr 2016 12:15:18 +0000 Received: from XCH-ALN-020.cisco.com (xch-aln-020.cisco.com [173.36.7.30]) by rcdn-core-9.cisco.com (8.14.5/8.14.5) with ESMTP id u3TCFIm5022902 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 29 Apr 2016 12:15:18 GMT Received: from xch-rcd-016.cisco.com (173.37.102.26) by XCH-ALN-020.cisco.com (173.36.7.30) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Fri, 29 Apr 2016 07:15:17 -0500 Received: from xch-rcd-016.cisco.com ([173.37.102.26]) by XCH-RCD-016.cisco.com ([173.37.102.26]) with mapi id 15.00.1104.009; Fri, 29 Apr 2016 07:15:17 -0500 From: "David Harton (dharton)" To: Remy Horton , "Tahhan, Maryam" , "dev@dpdk.org" CC: "Mcnamara, John" , "Van Haaren, Harry" Thread-Topic: [dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from xstats Thread-Index: AQHRlyVTq5+EWbgW3kKb6tsWJ2kqsZ+TB72QgAzZ8wD//7Qu4IABkYYA///A/GA= Date: Fri, 29 Apr 2016 12:15:17 +0000 Message-ID: References: <1460731462-21229-1-git-send-email-remy.horton@intel.com> <1A27633A6DA49C4A92FCD5D4312DBF536B1814BF@IRSMSX106.ger.corp.intel.com> <572335BA.7000202@intel.com> In-Reply-To: <572335BA.7000202@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.82.212.42] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2016 12:15:20 -0000 Happy Friday, > -----Original Message----- > From: Remy Horton [mailto:remy.horton@intel.com] > Sent: Friday, April 29, 2016 6:22 AM > To: David Harton (dharton) ; Tahhan, Maryam > ; dev@dpdk.org > Cc: Mcnamara, John ; Van Haaren, Harry > > Subject: Re: [dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from > xstats >=20 > Morning, >=20 > On 28/04/2016 16:58, David Harton (dharton) wrote: [...] >=20 > > Maybe I misread the patch series or missed one but I don't see where > > stats can be obtained without copying strings? This is the real issue > > I raised originally. >=20 > See http://dpdk.org/dev/patchwork/patch/12096/ where xstats[].key is used > to lookup string from ptr_names[].name - I didn't delete the name field > from rte_eth_xstats because doing so would cause a compile error with the > drivers I've not yet converted. Ok, this was one of my fundamental hang ups. I didn't see any gain because of the way the proposal is being introduced. I guess you are saying that not only will drivers be added in future patch series but that you also intend to continue modifying the external API as well. I will start a clean thread and reply/review the provided patches and forgo my work. Cheers, Dave >=20 >=20 >=20 > > I did not add "get the count" because it wasn't provided in the > > current API and instead followed the convention but I do believe > > overtly getting the count it is the better approach. >=20 > I didn't either for the same reason, but if the API is going to be broken= , > I think it should be added. >=20 >=20 > ..Remy