* [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources
@ 2019-07-23 15:34 Dekel Peled
2019-07-24 5:03 ` Slava Ovsiienko
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Dekel Peled @ 2019-07-23 15:34 UTC (permalink / raw)
To: yskoh, viacheslavo, shahafs; +Cc: orika, dev
Function rxq_release_rq_resources() releases resources of RQ object
created by DevX API.
This patch updates this function to properly clear the released
resources, to avoid repeated release of the same resource.
Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API")
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index c9df8b0..441f158 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -573,8 +573,10 @@
rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes);
rxq_ctrl->rxq.wqes = NULL;
}
- if (rxq_ctrl->wq_umem)
+ if (rxq_ctrl->wq_umem) {
mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem);
+ rxq_ctrl->wq_umem = NULL;
+ }
}
/**
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources
2019-07-23 15:34 [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources Dekel Peled
@ 2019-07-24 5:03 ` Slava Ovsiienko
2019-07-24 7:53 ` Raslan Darawsheh
2019-07-24 8:54 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2 siblings, 0 replies; 7+ messages in thread
From: Slava Ovsiienko @ 2019-07-24 5:03 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh, Shahaf Shuler; +Cc: Ori Kam, dev
> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Tuesday, July 23, 2019 18:35
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix Rx queue release of resources
>
> Function rxq_release_rq_resources() releases resources of RQ object created
> by DevX API.
>
> This patch updates this function to properly clear the released resources, to
> avoid repeated release of the same resource.
>
> Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API")
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxq.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index
> c9df8b0..441f158 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -573,8 +573,10 @@
> rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes);
> rxq_ctrl->rxq.wqes = NULL;
> }
> - if (rxq_ctrl->wq_umem)
> + if (rxq_ctrl->wq_umem) {
> mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem);
> + rxq_ctrl->wq_umem = NULL;
> + }
> }
>
> /**
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources
2019-07-23 15:34 [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources Dekel Peled
2019-07-24 5:03 ` Slava Ovsiienko
@ 2019-07-24 7:53 ` Raslan Darawsheh
2019-07-24 8:54 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2 siblings, 0 replies; 7+ messages in thread
From: Raslan Darawsheh @ 2019-07-24 7:53 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh, Slava Ovsiienko, Shahaf Shuler; +Cc: Ori Kam, dev
Hi Dekel,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Tuesday, July 23, 2019 6:35 PM
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources
>
> Function rxq_release_rq_resources() releases resources of RQ object
> created by DevX API.
>
> This patch updates this function to properly clear the released resources, to
> avoid repeated release of the same resource.
>
> Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API")
>
Wrong 'Fixes' reference:
Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API")
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxq.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index c9df8b0..441f158 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -573,8 +573,10 @@
> rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes);
> rxq_ctrl->rxq.wqes = NULL;
> }
> - if (rxq_ctrl->wq_umem)
> + if (rxq_ctrl->wq_umem) {
> mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem);
> + rxq_ctrl->wq_umem = NULL;
> + }
> }
>
> /**
> --
> 1.8.3.1
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH v2] net/mlx5: fix Rx queue release of resources
2019-07-23 15:34 [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources Dekel Peled
2019-07-24 5:03 ` Slava Ovsiienko
2019-07-24 7:53 ` Raslan Darawsheh
@ 2019-07-24 8:54 ` Dekel Peled
2019-07-24 9:05 ` [dpdk-dev] [PATCH v3] " Dekel Peled
2 siblings, 1 reply; 7+ messages in thread
From: Dekel Peled @ 2019-07-24 8:54 UTC (permalink / raw)
To: yskoh, viacheslavo, shahafs; +Cc: orika, dev
Function rxq_release_rq_resources() releases resources of RQ object
created by DevX API.
This patch updates this function to properly clear the released
resources, to avoid repeated release of the same resource.
Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API")
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index c9df8b0..441f158 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -573,8 +573,10 @@
rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes);
rxq_ctrl->rxq.wqes = NULL;
}
- if (rxq_ctrl->wq_umem)
+ if (rxq_ctrl->wq_umem) {
mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem);
+ rxq_ctrl->wq_umem = NULL;
+ }
}
/**
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources
2019-07-24 8:54 ` [dpdk-dev] [PATCH v2] " Dekel Peled
@ 2019-07-24 9:05 ` Dekel Peled
2019-07-24 11:25 ` Raslan Darawsheh
2019-07-24 20:23 ` Matan Azrad
0 siblings, 2 replies; 7+ messages in thread
From: Dekel Peled @ 2019-07-24 9:05 UTC (permalink / raw)
To: yskoh, viacheslavo, shahafs; +Cc: orika, dev
Function rxq_release_rq_resources() releases resources of RQ object
created by DevX API.
This patch updates this function to properly clear the released
resources, to avoid repeated release of the same resource.
Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API")
---
v3: Use adequate 'Fixes' reference.
---
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index c9df8b0..441f158 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -573,8 +573,10 @@
rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes);
rxq_ctrl->rxq.wqes = NULL;
}
- if (rxq_ctrl->wq_umem)
+ if (rxq_ctrl->wq_umem) {
mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem);
+ rxq_ctrl->wq_umem = NULL;
+ }
}
/**
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources
2019-07-24 9:05 ` [dpdk-dev] [PATCH v3] " Dekel Peled
@ 2019-07-24 11:25 ` Raslan Darawsheh
2019-07-24 20:23 ` Matan Azrad
1 sibling, 0 replies; 7+ messages in thread
From: Raslan Darawsheh @ 2019-07-24 11:25 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh, Slava Ovsiienko, Shahaf Shuler; +Cc: Ori Kam, dev
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Wednesday, July 24, 2019 12:05 PM
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources
>
> Function rxq_release_rq_resources() releases resources of RQ object
> created by DevX API.
>
> This patch updates this function to properly clear the released resources, to
> avoid repeated release of the same resource.
>
> Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API")
>
> ---
> v3: Use adequate 'Fixes' reference.
> ---
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxq.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index c9df8b0..441f158 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -573,8 +573,10 @@
> rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes);
> rxq_ctrl->rxq.wqes = NULL;
> }
> - if (rxq_ctrl->wq_umem)
> + if (rxq_ctrl->wq_umem) {
> mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem);
> + rxq_ctrl->wq_umem = NULL;
> + }
> }
>
> /**
> --
> 1.8.3.1
Patch applied to dpdk-next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources
2019-07-24 9:05 ` [dpdk-dev] [PATCH v3] " Dekel Peled
2019-07-24 11:25 ` Raslan Darawsheh
@ 2019-07-24 20:23 ` Matan Azrad
1 sibling, 0 replies; 7+ messages in thread
From: Matan Azrad @ 2019-07-24 20:23 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh, Slava Ovsiienko, Shahaf Shuler; +Cc: Ori Kam, dev
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="iso-8859-8-i", Size: 1393 bytes --]
äùâ àú Outlook òáåø Android<https://aka.ms/ghei36>
îàú: Dekel Peled
ðùìç: éåí øáéòé, 24 áéåìé, 12:05
ðåùà: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources
àì: Yongseok Koh, Slava Ovsiienko, Shahaf Shuler
òåú÷: Ori Kam, dev@dpdk.org
Function rxq_release_rq_resources() releases resources of RQ object
created by DevX API.
This patch updates this function to properly clear the released
resources, to avoid repeated release of the same resource.
Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API")
---
v3: Use adequate 'Fixes' reference.
---
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index c9df8b0..441f158 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -573,8 +573,10 @@
rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes);
rxq_ctrl->rxq.wqes = NULL;
}
- if (rxq_ctrl->wq_umem)
+ if (rxq_ctrl->wq_umem) {
mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem);
+ rxq_ctrl->wq_umem = NULL;
+ }
}
/**
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-07-24 20:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 15:34 [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources Dekel Peled
2019-07-24 5:03 ` Slava Ovsiienko
2019-07-24 7:53 ` Raslan Darawsheh
2019-07-24 8:54 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2019-07-24 9:05 ` [dpdk-dev] [PATCH v3] " Dekel Peled
2019-07-24 11:25 ` Raslan Darawsheh
2019-07-24 20:23 ` Matan Azrad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).