From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 77361F614 for ; Wed, 11 Jan 2017 16:38:18 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 11 Jan 2017 07:38:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="1081799258" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga001.jf.intel.com with ESMTP; 11 Jan 2017 07:38:16 -0800 To: Wei Dai , dev@dpdk.org References: <1484063146-15796-1-git-send-email-wei.dai@intel.com> <1484063146-15796-3-git-send-email-wei.dai@intel.com> Cc: helin.zhang@intel.com, konstantin.ananyev@intel.com From: Ferruh Yigit Message-ID: Date: Wed, 11 Jan 2017 15:38:15 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484063146-15796-3-git-send-email-wei.dai@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/7] net/ixgbe/base: remove a compiler warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 15:38:18 -0000 On 1/10/2017 3:45 PM, Wei Dai wrote: > This patch fixes a compiler warning. I guess compiler warning is because of "mac->led_link_act = i;", since led_link_act is 8bits.. But can you please add the compile warning here, to make it more clear to understand what is the issue. > > Signed-off-by: Wei Dai > --- > drivers/net/ixgbe/base/ixgbe_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c > index 18bb18c..0dd33b8 100644 > --- a/drivers/net/ixgbe/base/ixgbe_common.c > +++ b/drivers/net/ixgbe/base/ixgbe_common.c > @@ -1150,7 +1150,7 @@ s32 ixgbe_init_led_link_act_generic(struct ixgbe_hw *hw) > { > struct ixgbe_mac_info *mac = &hw->mac; > u32 led_reg, led_mode; > - u16 i; > + u8 i; > > led_reg = IXGBE_READ_REG(hw, IXGBE_LEDCTL); > >