From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A1B7432DA; Wed, 8 Nov 2023 20:24:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B0D0406A2; Wed, 8 Nov 2023 20:24:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2052D40395 for ; Wed, 8 Nov 2023 20:24:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699471494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XPupiXtgt//BK4F6rhaTimXWmuDEfmuzGFToUGsnWQc=; b=GHTVUGYyts+M6IcKXrcJ0tJxSCWQRh16hnT0fP7HEqCE/lpVpYWo3e8q0v+joz/sSgLV0d 0egsrUr3IOaGnxwAZgtcxbkuMiOHZhIbQIFlUq0VW4utf8CjlL4U5x64rermqOkqFL+BsK q7VEPCs2bmlSjvzq4f6JdJH7ucnnRE8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-U2-xI1ClOCCBXLwc94rSqw-1; Wed, 08 Nov 2023 14:24:53 -0500 X-MC-Unique: U2-xI1ClOCCBXLwc94rSqw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-32db6a28e24so18773f8f.0 for ; Wed, 08 Nov 2023 11:24:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699471492; x=1700076292; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XPupiXtgt//BK4F6rhaTimXWmuDEfmuzGFToUGsnWQc=; b=G98H+y4LJFA3HF6toW0CxJg5mpf+2JgX7CbYWr/3qHUBqUXkpqwuC6FcJ8Vu3Op6Q+ AQn4bM6/dl622REpTG0ub7/+Darw1dPfbTfozURnzZxprzDUps/gYYRO5mvgaSr0/nYN aIwbZNK9vCO6uVmpQymAbgRRhXJGgxrJaZN8otEonCZarjjUL+YPzxzkfzhTegD1xwiS EEZ2GwM87f8qzBvZ/Kbq1FpEitUbDcTersNCO7gZHMpM30GawH2ZZ+Mz1dZv+wvrC3Lr AYP3/jFS02WWNFYbkp+5ep1uyIAPH3dqxyaBI2dTF3BMvrYkvKH4xWBPujk1EWd4co5U 4qEQ== X-Gm-Message-State: AOJu0Yzd1F8bOXG4wt4Z850IeFbo6pXc5d9y3OZTDHLQOgp6WmGs/PdN HCGOPlRj1ZzljQykqo7iomAVkYO8Rmi1RxIdIQ4jrfb4FqSlcEZaRLu34DFWGoE1RtxD8thqf63 P0sU= X-Received: by 2002:a5d:6d46:0:b0:32d:bafd:809f with SMTP id k6-20020a5d6d46000000b0032dbafd809fmr2765455wri.70.1699471492230; Wed, 08 Nov 2023 11:24:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHdFfWJpq1MEa8m54o571nYbH2dgHa4v2L5JtlDcRAfUTCYATCSNpuWK/W7bJ0Zggzs/tVb7Q== X-Received: by 2002:a5d:6d46:0:b0:32d:bafd:809f with SMTP id k6-20020a5d6d46000000b0032dbafd809fmr2765437wri.70.1699471491873; Wed, 08 Nov 2023 11:24:51 -0800 (PST) Received: from [192.168.0.36] ([78.16.130.39]) by smtp.gmail.com with ESMTPSA id o9-20020a5d62c9000000b0032f7f4d008dsm5629441wrv.20.2023.11.08.11.24.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 11:24:51 -0800 (PST) Message-ID: Date: Wed, 8 Nov 2023 19:24:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Rongwei Liu , matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com, thomas@monjalon.net, stable@dpdk.org Cc: Raslan Darawsheh , dev@dpdk.org References: <20231103030721.930738-1-rongweil@nvidia.com> From: Kevin Traynor Subject: Re: [21.11 PATCH v1] net/mlx5: fix matcher layout size calculation In-Reply-To: <20231103030721.930738-1-rongweil@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 03/11/2023 03:07, Rongwei Liu wrote: > Initially, the rdma-core library only supported misc0 to misc3 fields in > matching resources, misc4 and misc5 fields were added to handle new > features. The matcher layout, passing from DPDK to rdma-core, shouldn't > exceed the size of the engaged library version capabilities. > > For now, there is no way to know what is the maximum capability of > rdma-core, and DPDK should limit the matcher layout to misc3 if > possible (no matching on fields misc4 and misc5 are requested by the > application). > > The check if misc4 and misc5 features were requested was based on checking > the values against zeroes. The matching mask should be checked instead. > > Fixes: 630a587bfb37 ("net/mlx5: support matching on VXLAN reserved field") > Cc:rongweil@nvidia.com > Cc:stable@dpdk.org > Signed-off-by: Rongwei Liu > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) Thanks Rongwei. I added upstream commit hash, removed cc's and applied to branch 21.11 [0]. fyi - patches only for backport should go to stable@dpdk.org only. Just makes things a bit easier for email filters, patchwork, ci etc. regards, Kevin [0] https://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=6de3135f1e2ec52d25505ae1ea3ef9a242ddcd5d