From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B7854545E; Fri, 14 Jun 2024 17:11:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB94740B95; Fri, 14 Jun 2024 17:11:26 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2083.outbound.protection.outlook.com [40.107.101.83]) by mails.dpdk.org (Postfix) with ESMTP id 3FA8D402D0 for ; Fri, 14 Jun 2024 17:11:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZlK7ZVS+w9WxkqeqkFtSbVRrP8JtVZiMPGSsGUO3g5raeHNSoj1Ayp32HCe4FnkpGRMD5dqgeDUuF2qYt0Tvk6u1oJbElqxk4CGpCM2NdsUHTA2zDqu/8XZTpWxBW4Am+EtP3UbyFSHv+rl2lEn9LkMQF1Wq0bZSsRKlMqb7WnHZ0f1zJFVq5LJwOwOljE0rsv/gFe9YjVCd22MZwJcb53MJKaamNAAZd6z3bJYhoYHqMUZcYX4w5EE9OToG3dUXfcEy8dTN0dZnJabc9f7Le9649D0mxyOinhWq2bRj9CIMUYBTtlMgnqZQDGoXMnWuaWNraNWHdE+kjvXAXuDVhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZuuiBL0IEv8yDIFkYaSs6iGMfvgsT1hmzKYV4E318NU=; b=T8z9vw3xPkSAUPjuvD01U/KWFO3dwShgKrvb4iheljZ3XHYN1CILF34dmlulUhxg+5YjqlD4IQWAOGH7TDHotzQCOrA2GJwVQ+vVsDRlE7cKUP9urpLT6UWQXsK14wEDjVSoWvbQIwVJLMR8S7JXYZjK/G/IwEDF0dcCSzAYrOMeVXEcMTXlo2KGL/tTIl0aFimmNkNlj5+DPJA2cKWWJOgmh8TKLgrBEVnRh9z4kSTuHaDVPBBE7Lt8fIrHIwGHD3mrTamNkeHgt9YVvKILre0v9Edpq+63WT9dIhDW6vvZFP9fFDQ+YtA7DbkbVTzmi6q32rKrMrnLdOJAI55xDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZuuiBL0IEv8yDIFkYaSs6iGMfvgsT1hmzKYV4E318NU=; b=aGBCaCXbX9zTKGWq+Iv+PRHNvdpG8Chr8j73JNarRLFsCeEWJcKLh6fAKvKePAtNdOfnMZpL/CSplUM6DKuxq5iqoUuPVkYJUnc7n3RvZKAtZa5Ca3YmNrKUsUCuI3BmhzkfnFLYeoZnrXMbMtV9Yo/8xi7iCLHt+yc6Dbqkix0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB6926.namprd12.prod.outlook.com (2603:10b6:a03:485::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.20; Fri, 14 Jun 2024 15:11:17 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7677.026; Fri, 14 Jun 2024 15:11:16 +0000 Message-ID: Date: Fri, 14 Jun 2024 16:11:11 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 2/4] gro: remove use of VLAs To: Konstantin Ananyev , Konstantin Ananyev , "dev@dpdk.org" Cc: "hujiayu.hu@foxmail.com" , "roretzla@linux.microsoft.com" , "bruce.richardson@intel.com" , "anatoly.burakov@intel.com" , "vladimir.medvedkin@intel.com" , "kumaraparamesh92@gmail.com" References: <20240523162604.2600-1-konstantin.v.ananyev@yandex.ru> <20240523162604.2600-3-konstantin.v.ananyev@yandex.ru> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0361.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB6926:EE_ X-MS-Office365-Filtering-Correlation-Id: f8003e66-17dd-4f0e-0d0c-08dc8c843cd0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T1hUSmU0U0Q1VjBYazQzSy90YjFGZzc2K09rMExEY2gvU0xLY1JNRVlzOEFE?= =?utf-8?B?MDBLZGRKdStsTUttVFJNUFdyamhsNVBDZlIzTVN0MVY0VmlqeW1TY25kaXFz?= =?utf-8?B?aU5UZFBwaVRuemtPRjFEYWliSHF6TTJhYWp4REFuK3ZyKzRObFIwbmltREgv?= =?utf-8?B?aE5zUmN4Z1Q2czNXb005QnA4SXpDdk5kVG1MbHJpTSsxT2JUbURCZWVQVXE1?= =?utf-8?B?UHlZaVB4d3habXplbnlTYmhVRVNwNVZrUUJybHphc04yUTkwS21tMEh3K3Np?= =?utf-8?B?RXUyR0gwU1ZlRTJ1dUd3TVkxODd1SEJZeHI2MVRXam94aUFxZlFHWThhVzFU?= =?utf-8?B?ZDZTaGxXVGJ1ekpQbUJmQk5nMlRlWE41VTVDOEJLQzdOS253WnR5cy93VUQy?= =?utf-8?B?L3pzMTRkRFhOTDB5a1pZMW9kUTg0ZUptb00yeTdaWWNPOXVBVmNnQjdFemtk?= =?utf-8?B?Umkzd1lFcnVsQVRXWGFtZWsvQmNQU2dyUW1QREI5bmVlclFTOWJRaGRrQzFQ?= =?utf-8?B?YW5zQWJaMUFFMUNpby94cmxKSzJqTDZNRTZ4cXFFanBSb0JnVUtwT3FsQkNV?= =?utf-8?B?VmVIMUFvdXNJcVliVUR2dGNYWmVSTGtGNDNsWWcxM2RWYVBBMitLeEtuTndx?= =?utf-8?B?d2V5NS93Z2dGT3MwWXhveHMxYWZyUnU4MlUyOThvUm9sMk9pOGFxZXlKMkpB?= =?utf-8?B?WDU1S1cxQ1IvNFplY09GYzNybkFMNW4wUDRvVkZuYTVmbFR6UlVSelJiVXhC?= =?utf-8?B?SW1yejVtWDZQVWRrZC9LZC9SdkNRQTdod1IveEFKcVlFTVpyN3ByS2liTGYx?= =?utf-8?B?MFZnRjErZzNBQW8xQ2FDcFZQWVBXdmVhZGFNaTRJb2R5UUhkWHBZeU9FZWh4?= =?utf-8?B?bkU4L1hQTDl0ZkN6S1dSSTVyQzNZZzZocjFkaTJUVVVZT2U5OHkydlVHa2M2?= =?utf-8?B?T25uc1U3a010eFVWRUJBS2UyY2RKSXVnZGNiS3BnRy9QSUVKTkRRMWRadW9n?= =?utf-8?B?TmlYUHNBN3JWemMyejdSME1HdG8zcEViY01GQnlheGRPTVZqY0ZraHJqQ3lS?= =?utf-8?B?L1ZYQitPU2tkekR0WWY1YVlBQ1FMWktjSmxqTkJ4NlcwRXgrcU10OCsrRTk3?= =?utf-8?B?V0hJNTBpNG9ENDI4L2ROWTJ3TWVFbmRMdEJSVVBpTWFyQzAyelBXblQycmls?= =?utf-8?B?SnROVXFTbjFIdnJhNk4zWVhxWUxkY20rVXcxaEE5cGM0ZkpydG40KzFVUENu?= =?utf-8?B?Z3NSWld1Y1FiZElHNExBejRxL2p4alFEWTltZGt0N01JUnc2RU1oZVVGL3g3?= =?utf-8?B?azVDNGVoNmw2SHo4TlJNVmJrRWVOM3ZYaGUvY2tTVmMxNC9vcG4rTWhKNzZP?= =?utf-8?B?bTVTeUFsemJBVW41d295a0FVb3kxTktTa1VXM1pNUGdSTGRRWkIxaFF4a3cy?= =?utf-8?B?NUFIZnkyRnhERG45MWkxLzNTUWRqRm1QVUNFazdpZ1JoNHFNSFVkWmdsd0dw?= =?utf-8?B?K0ZiczlvZDFyZVBSM0hkNllkNnd0R3pwOXpRQVB6bmhaYi94RnNTc3Y3Ymtm?= =?utf-8?B?ZGVDMGxXWVVqOXBBVWZHTUJoWEh3YzR6Q0RmZS9McmU0OGhpWEFzcnI4emdH?= =?utf-8?B?MVgwZVkwaVBBazQ1VXdjay95eGY5MUo1QURJVytSc1hwV0JURm1HT1VGeGV3?= =?utf-8?B?OTViaGxrYnZmeVlRSzJtdjRTeWRrV0tJT2cxeEV3bzhtN0FCdUc2c05aU01E?= =?utf-8?Q?STv6lVa8JWgQxi6ekA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzBsWWF1UXArem90NHVPZU1tMlhzNlBJcE80MHN4dTA3L1Q0SHovcVllVWZH?= =?utf-8?B?b0NLSi9xa0x6WW9ob01sbm5XVzZtUHNUSnFzSlU1d1lpVXhWT0hVL0YvUEgw?= =?utf-8?B?b082UllvamJxNU1PbXRYRTFPZEs3dis3aXJhaWVCay9zMkZNNDFpVnRwNVhl?= =?utf-8?B?MWJoZ0hIaVJMRm03VWFidXdmTmdKMFp2eFkycDUvMng4T2ZhTGJRWmNYMUdX?= =?utf-8?B?T2t1aGF2UyswQVNXOFF5YTRyWk8rZmo3dm5oQURkazBqNDUyYU5hS2Z0anc3?= =?utf-8?B?Y0lnSGR2MnZHQXN5NVNCaU1JRUJidUJobUtiNFVoYkRNa0Z5MzhBb01WWEs3?= =?utf-8?B?bkJIT1JkTXFqSDJwNE5FZWxtTDhueElNVit2VTFEZmYzKzRGZ2F3Q3hxMnN5?= =?utf-8?B?VmtnU2kzQThoaloyaE5VOVBnSjVxMEsxMnZFSnRVSDdpS2R6cGNLVTVsRllY?= =?utf-8?B?TGdrajNtSWhjeVE4Ly9QZHA2aUNSYnlRakpnSGFZODIycnRkYWZsNTRLdjg3?= =?utf-8?B?b04rRTJPNmppaXZXL2t2NTEvaFY1RnV2NDRZbEhrMWo4UXlXSVZ1WG9laWNt?= =?utf-8?B?SDl5aHFYWjVGNkhPckdxWnh1Nmc3bFRySXdOSlhXckVKd1F1UDJDVERXVlBa?= =?utf-8?B?c2IzeUVVaFdxZjRoNHlxMVR6S25saENLbG1EeVFYbHA0SFIwYjNYR0xQRG5u?= =?utf-8?B?SXJQMVIxaU1JcnpZQVpSWlRnVXRiMm9yM1doU0lkZWc0blJlRE1yU01yK2l2?= =?utf-8?B?MTNZU25qVEk0cDl5K0k4clRSL1JwSnBKNUNsUXBzV3dlcmplV1VTYVpBbi9Q?= =?utf-8?B?SjJ1WHd5M2Y4RGlnclc4akxlTElTcGFhQnowNFBoZWxxZ1NFRWIwT0ZLU2U0?= =?utf-8?B?YjFJdzl5YnFGM0xUcDRiN2U2RFlDNmRTUmo3Y2FtS2ltSnZhSkIzb3Q4YWJa?= =?utf-8?B?UitGWk9hVDFrVkFzbE16dW1EaWl2YWltZzZWUzJud1AwT2VFTTk5NUNxOU9W?= =?utf-8?B?cDdoZmpMZlJ0RFF0MUhIbVZJOHNqVHk1Q0R2OFZiQytEQWt2OEZNd1FxYmpK?= =?utf-8?B?VGIzMS9oUWlFSm9Jb1JHdlFOYkprYzdINnh0YTBxZFFrY0xrc0pKUjRqbGlQ?= =?utf-8?B?b2ozbGswbWVEYlV2QjZVNVdTUWYxc1R4S3hWWGVXVVRQVXpPWHorUzU3MDZh?= =?utf-8?B?aWJ0ZzgwRm9HVzlxTnN3VWFZcDRJc0JNaTEvN1NxQ005d3l0c1FmN1oxbUlF?= =?utf-8?B?STcwdGlwa2dWTThMeHNoWEFVSy96NTJ6Z2U5NVBaZ1V4WG5qWEVSZjBGWEds?= =?utf-8?B?bWpRRUVoMTlwTWhhYTh5WE1wZmZOWkpHNnRDR0RKK3FPYlFXNkJudFNFTFhE?= =?utf-8?B?VGJVaXpBV2M1SHhZbG5UWWRPcFRQbkxkMnRNZDZEbzdIOXRhTTNsa2Y0SzNs?= =?utf-8?B?aGJyck9JeUJ1OXJiTk1lcWVIVWlyMkppUDgwRFlkUWtyL2FVM255V2tEV1Mx?= =?utf-8?B?a1hjMThtcTQ5dDJXbGlqWWhqc2lWbkQxdlVFVDRnbEYwSXlPeU1HbVZrZSs2?= =?utf-8?B?U2NSNzBPZlZINCtpcXlsWHhHVFJOQ0FMMzJxSEN3K2pJbER1bzh6SEZEUzZI?= =?utf-8?B?UENsdnM2dDFFN00yUVpaYUNES1RYTE5jaDZTNklBWlFYVUFKUXhtbUdKV0w2?= =?utf-8?B?VVJqNFpCaVczWi9vQno0eEg2M3dNbi9SMFJ1TUlpdnF4ZmVvR1RlZTNwZzJL?= =?utf-8?B?cGxaTnF4UjUxeDlXMFc0dWI5enV6Uk5pa2hTckxkN1hsMnB6V1JUZTlmN2Yr?= =?utf-8?B?V0ZadFlPOTJ1WG1QdTlodE1JbVVKbUhMaGlNQ2ZIa2lJLzhhTUtKclpwdzY2?= =?utf-8?B?Q3MxcDZaNWM5SDNxQmlXajZZYVI2UXdBUFp0ZUU0cXhMSDlSaEhLTFlobkkr?= =?utf-8?B?OGZzL3lNdVVoTWlnRlZOU00wMnpMSG9abWQ3RlF1TUhMNWgyb3lhUWhTRHFH?= =?utf-8?B?eFM3OUdYRGM3cFg2Rk1yYk5nTnQzS3JuL295TVJLUXg4MElqQk1STXdNN1p6?= =?utf-8?B?Z0NXVVRvdlhtSFRRcFZlQW5rUDFWN3N4TmFFemF5TXllQ0drZ1kvT2tMMTVy?= =?utf-8?Q?tkG55SZTSxFDKmcttA6huSfL2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8003e66-17dd-4f0e-0d0c-08dc8c843cd0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 15:11:16.6491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UViVsiD4g3zqyPDRZh8jw5rA6/0KaCTvtzbZUEJgGYj/4enQgKXe9FZQQ3/otap4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6926 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/13/2024 11:20 AM, Konstantin Ananyev wrote: > > >> >> On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: >>> From: Konstantin Ananyev >>> >>> ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] >>> ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] >>> >>> In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to >>> collect un-used by GRO packets, and then copy them to the start of >>> input/output pkts[] array. >>> In both cases, we can safely copy pkts[i] into already >>> processed entry at the same array, i.e. into pkts[unprocess_num]. >>> Such change eliminates need of temporary VLA: unprocess_pkts[nb_pkts]. >>> >>> Signed-off-by: Konstantin Ananyev >>> --- >>> lib/gro/rte_gro.c | 40 ++++++++++++++-------------------------- >>> 1 file changed, 14 insertions(+), 26 deletions(-) >>> >>> diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c >>> index db86117609..6d5aadf32a 100644 >>> --- a/lib/gro/rte_gro.c >>> +++ b/lib/gro/rte_gro.c >>> @@ -179,7 +179,6 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts, >>> struct gro_vxlan_udp4_item vxlan_udp_items[RTE_GRO_MAX_BURST_ITEM_NUM] >>> = {{{0}} }; >>> >>> - struct rte_mbuf *unprocess_pkts[nb_pkts]; >>> uint32_t item_num; >>> int32_t ret; >>> uint16_t i, unprocess_num = 0, nb_after_gro = nb_pkts; >>> @@ -275,7 +274,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts, >>> /* Merge successfully */ >>> nb_after_gro--; >>> else if (ret < 0) >>> - unprocess_pkts[unprocess_num++] = pkts[i]; >>> + pkts[unprocess_num++] = pkts[i]; >>> } else if (IS_IPV4_VXLAN_UDP4_PKT(pkts[i]->packet_type) && >>> do_vxlan_udp_gro) { >>> ret = gro_vxlan_udp4_reassemble(pkts[i], >>> @@ -284,7 +283,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts, >>> /* Merge successfully */ >>> nb_after_gro--; >>> else if (ret < 0) >>> - unprocess_pkts[unprocess_num++] = pkts[i]; >>> + pkts[unprocess_num++] = pkts[i]; >>> } else if (IS_IPV4_TCP_PKT(pkts[i]->packet_type) && >>> do_tcp4_gro) { >>> ret = gro_tcp4_reassemble(pkts[i], &tcp_tbl, 0); >>> @@ -292,7 +291,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts, >>> /* merge successfully */ >>> nb_after_gro--; >>> else if (ret < 0) >>> - unprocess_pkts[unprocess_num++] = pkts[i]; >>> + pkts[unprocess_num++] = pkts[i]; >>> } else if (IS_IPV4_UDP_PKT(pkts[i]->packet_type) && >>> do_udp4_gro) { >>> ret = gro_udp4_reassemble(pkts[i], &udp_tbl, 0); >>> @@ -300,7 +299,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts, >>> /* merge successfully */ >>> nb_after_gro--; >>> else if (ret < 0) >>> - unprocess_pkts[unprocess_num++] = pkts[i]; >>> + pkts[unprocess_num++] = pkts[i]; >>> } else if (IS_IPV6_TCP_PKT(pkts[i]->packet_type) && >>> do_tcp6_gro) { >>> ret = gro_tcp6_reassemble(pkts[i], &tcp6_tbl, 0); >>> @@ -308,21 +307,15 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts, >>> /* merge successfully */ >>> nb_after_gro--; >>> else if (ret < 0) >>> - unprocess_pkts[unprocess_num++] = pkts[i]; >>> + pkts[unprocess_num++] = pkts[i]; >>> } else >>> - unprocess_pkts[unprocess_num++] = pkts[i]; >>> + pkts[unprocess_num++] = pkts[i]; >>> } >>> >>> if ((nb_after_gro < nb_pkts) >>> || (unprocess_num < nb_pkts)) { >>> - i = 0; >>> - /* Copy unprocessed packets */ >>> - if (unprocess_num > 0) { >>> - memcpy(&pkts[i], unprocess_pkts, >>> - sizeof(struct rte_mbuf *) * >>> - unprocess_num); >>> - i = unprocess_num; >>> - } >>> + >>> + i = unprocess_num; >>> >>> /* Flush all packets from the tables */ >>> if (do_vxlan_tcp_gro) { >>> >> >> ack to re-use 'pkts[]' buffer for unprocessed packets, that should work. >> >> But as a more general GRO question, above 'rte_gro_reassemble_burst()' >> functions seems returns 'nb_after_gro' and as far as I can see that >> amount of mbufs sits in the 'pkts[]'. >> When packets flushed from tables, flushed packets are replaced to >> 'pkts[]' but still 'nb_after_gro' returned, there is no way for >> application to know that more than 'nb_after_gro' mbufs available in the >> 'pkts[]'. Shouldn't return value increased per flushed packet? >> >> Ahh, I can see it was the case before, but it is updated (perhaps >> broken) in commit: >> 74080d7dcf31 ("gro: support IPv6 for TCP") > > Actually my first thought was - we should return 'I' here. > but then looking at the code more carefully, I realized that it is correct: > nb_after_gro - would contain valid number of packets > (at least I wasn't able to find a case when it wouldn't). > Though yeh, it wasn't very obvious for me at first place, so might be > extra comment wouldn't hurt here. > In first half of the function, 'nb_after_gro' is number of packets not assembled and decided to pass back to user via 'pkts' buffer. In second half, timed out packets are decided to turn back to user (flushed), as they are not reassembled, and these packets are added to 'pkts' array for user, but 'nb_after_gro' not increased. So how user can know about it? Basically, I think we should return 'i', what am I missing, can you please detail?