From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id AAB891B60A for ; Mon, 16 Oct 2017 12:39:00 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id q132so1742565wmd.2 for ; Mon, 16 Oct 2017 03:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev-mellanox-co-il.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=zSbuHy1MBEehU51QPJEFmOOfNfOVCRGZHsNHdESoaVI=; b=D46Q8Ly+e+MwQfUS5+TeysX2qQamZjL5J6DjmL99m/F5JeoKZE+5pZU0zXXN27paU6 TOe5+uNCw+DLGx4QnoGZu4mKsjVwD1iYbq7eovwQT+B7pZ3Gtsq9rdxF7WqMv4KXfJhm KIY55P8jPCLEi9CsevGkZ8C4Gv6EUY9tt7hODubGg2gj7vUuQgHWv+vMFtm/htuZhJZc P0ag8fz34TJQdwMScxPAFp8iYg2wCrRJVvI10dDPeig3FdI1jyuWaeLQ2LNvNpxvcokD cTmdVRdpSb+NLtAH3+unPgpJr9sRLrCMVzrR27zdFxOhLb7aVBo8M2e78x2XpCCEfwDR AJ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zSbuHy1MBEehU51QPJEFmOOfNfOVCRGZHsNHdESoaVI=; b=gn4YQuzmNu/qIEMyyQSX/NKx/bfLXYaC/Ih6AJYUlPNsu0NXf3VxUEWZ98St3t9rxk w/6lvLH+oXBUHXmCKaHB1zJhfzvGXajgNh4rzdLy9bKp2bMZktQuWU6SFgF3tmU18Pui trDTAPEsKI85puly5AqG7Rw0vz6IPP92mgcttAq9VWr8GA+wzEPsijLuaHwgnXK/A8Uu jfYuB2M0ePYHbW7piXjGMagUG3JyZUG2ttLD/M/3L6/4trIINowcYeDbpNw2rwyxlrN4 bzuN1ISexHQ8oUwdhIkoW4tMz9B3JjxBJdiCUztTQtlTp95dRDicvVd8F4NLDeqylTOH 9fYg== X-Gm-Message-State: AMCzsaUE9jOTjOEsTCXMKWC5sSIE9fVDitMrXHoS1xQWjl6Rwh3sd6uS fHFyjJzqZDK9xRTu1HN8i3Nr9Q== X-Google-Smtp-Source: ABhQp+T6NX1ynUiiRc1XLRUSe7AyVq7ePsSIzvVorgmVlT8+kb5u9D1yQhP+1hqUD0+IjYLB+VoGHA== X-Received: by 10.28.109.220 with SMTP id b89mr550679wmi.30.1508150340383; Mon, 16 Oct 2017 03:39:00 -0700 (PDT) Received: from [10.0.38.219] ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id s21sm3742084wra.16.2017.10.16.03.38.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Oct 2017 03:38:59 -0700 (PDT) To: Sergio Gonzalez Monroy , dev@dpdk.org, pablo.de.lara.guarch@intel.com, aviadye@mellanox.com Cc: borisp@mellanox.com, akhil.goyal@nxp.com, hemant.agrawal@nxp.com, radu.nicolau@intel.com, declan.doherty@intel.com, liranl@mellanox.com, nelio.laranjeiro@6wind.com, thomas@monjalon.net References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il> <1507987683-12315-10-git-send-email-aviadye@dev.mellanox.co.il> From: Aviad Yehezkel Message-ID: Date: Mon, 16 Oct 2017 13:38:57 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 10/11] app/testpmd: compile even if ixgbe anf bnxt pmds are not compiling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 10:39:00 -0000 On 10/16/2017 12:44 PM, Sergio Gonzalez Monroy wrote: > On 14/10/2017 14:28, aviadye@dev.mellanox.co.il wrote: >> From: Aviad Yehezkel >> >> Signed-off-by: Aviad Yehezkel >> Signed-off-by: Nicolai Radu >> --- >>   app/test-pmd/cmdline.c | 13 ++++++++++--- >>   app/test-pmd/config.c  | 12 +++++++++++- >>   2 files changed, 21 insertions(+), 4 deletions(-) > > This patch is modifying a different app, should be on its own. > > Thanks, > Sergio Agreed. Will send as different patch in next version with fixes. Thanks, Aviad. >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index bb19d72..e4a636e 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -7377,11 +7377,17 @@ struct cmd_set_vf_rxmode { >>   }; >>     static void >> -cmd_set_vf_rxmode_parsed(void *parsed_result, >> -               __attribute__((unused)) struct cmdline *cl, >> -               __attribute__((unused)) void *data) >> +cmd_set_vf_rxmode_parsed( >> +#if defined(RTE_LIBRTE_IXGBE_PMD) || defined(RTE_LIBRTE_BNXT_PMD) >> +        void *parsed_result, >> +#else >> +        __attribute__((unused)) void *parsed_result, >> +#endif >> +        __attribute__((unused)) struct cmdline *cl, >> +        __attribute__((unused)) void *data) >>   { >>       int ret = -ENOTSUP; >> +#if defined(RTE_LIBRTE_IXGBE_PMD) || defined(RTE_LIBRTE_BNXT_PMD) >>       uint16_t rx_mode = 0; >>       struct cmd_set_vf_rxmode *res = parsed_result; >>   @@ -7396,6 +7402,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result, >>           else if (!strncmp(res->mode, "MPE",3)) >>               rx_mode |= ETH_VMDQ_ACCEPT_MULTICAST; >>       } >> +#endif >>     #ifdef RTE_LIBRTE_IXGBE_PMD >>       if (ret == -ENOTSUP) >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >> index bafe76c..d38ba82 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -3181,7 +3181,17 @@ set_queue_rate_limit(portid_t port_id, >> uint16_t queue_idx, uint16_t rate) >>   } >>     int >> -set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate, >> uint64_t q_msk) >> +set_vf_rate_limit( >> +        portid_t port_id, >> +#if defined(RTE_LIBRTE_IXGBE_PMD) || defined(RTE_LIBRTE_BNXT_PMD) >> +        uint16_t vf, >> +        uint16_t rate, >> +        uint64_t q_msk) >> +#else >> +        __attribute__((unused)) uint16_t vf, >> +        __attribute__((unused)) uint16_t rate, >> +        __attribute__((unused)) uint64_t q_msk) >> +#endif >>   { >>       int diag = -ENOTSUP; > >