From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 76ED9201; Thu, 7 Dec 2017 10:16:04 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A5CE6820F2; Thu, 7 Dec 2017 09:16:03 +0000 (UTC) Received: from [10.36.112.55] (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FF317B8FF; Thu, 7 Dec 2017 09:15:58 +0000 (UTC) To: Tiwei Bie , yliu@fridaylinux.org, dev@dpdk.org Cc: stable@dpdk.org References: <20171207053059.19487-1-tiwei.bie@intel.com> <20171207053059.19487-3-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: Date: Thu, 7 Dec 2017 10:15:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171207053059.19487-3-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 07 Dec 2017 09:16:03 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 2/5] net/virtio: fix typo in LRO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 09:16:04 -0000 On 12/07/2017 06:30 AM, Tiwei Bie wrote: > Fixes: 86d59b21468a ("net/virtio: support LRO") > Fixes: ec9f3d122a58 ("net/virtio: revert not claiming LRO support") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 64a0cc608..9caa133c9 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1754,7 +1754,7 @@ virtio_dev_configure(struct rte_eth_dev *dev) > > if (rxmode->enable_lro && > (!vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO4) || > - !vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO4))) { > + !vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO6))) { > PMD_DRV_LOG(ERR, > "Large Receive Offload not available on this host"); > return -ENOTSUP; > Good catch! Reviewed-by: Maxime Coquelin Thanks, Maxime