From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xiaolong Ye <xiaolong.ye@intel.com>,
dev@dpdk.org, Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: xiao.w.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH] vhost: add doxygen comment to vDPA header
Date: Thu, 11 Oct 2018 14:42:11 +0200 [thread overview]
Message-ID: <bb8836fd-e5c3-b323-63f3-17a2296d878d@redhat.com> (raw)
In-Reply-To: <20181010091447.64542-1-xiaolong.ye@intel.com>
On 10/10/2018 11:14 AM, Xiaolong Ye wrote:
> As APIs in rte_vdpa.h are public, we need to add doxygen comments
> to all APIs and structures.
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
> doc/api/doxy-api-index.md | 1 +
> lib/librte_vhost/rte_vdpa.h | 54 +++++++++++++++++++++++++++++++++----
> 2 files changed, 50 insertions(+), 5 deletions(-)
>
Looks good to me:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2018-10-11 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 9:14 Xiaolong Ye
2018-10-11 12:42 ` Maxime Coquelin [this message]
2018-10-11 13:28 ` Ferruh Yigit
2018-10-11 20:25 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb8836fd-e5c3-b323-63f3-17a2296d878d@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).