From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id CB3291B4A2
 for <dev@dpdk.org>; Thu, 11 Oct 2018 14:42:16 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 10D46308421A;
 Thu, 11 Oct 2018 12:42:16 +0000 (UTC)
Received: from [10.36.112.55] (ovpn-112-55.ams2.redhat.com [10.36.112.55])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D54C842C2;
 Thu, 11 Oct 2018 12:42:14 +0000 (UTC)
To: Xiaolong Ye <xiaolong.ye@intel.com>, dev@dpdk.org,
 Tiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>
Cc: xiao.w.wang@intel.com
References: <20181010091447.64542-1-xiaolong.ye@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <bb8836fd-e5c3-b323-63f3-17a2296d878d@redhat.com>
Date: Thu, 11 Oct 2018 14:42:11 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20181010091447.64542-1-xiaolong.ye@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.40]); Thu, 11 Oct 2018 12:42:16 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] vhost: add doxygen comment to vDPA header
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Oct 2018 12:42:17 -0000



On 10/10/2018 11:14 AM, Xiaolong Ye wrote:
> As APIs in rte_vdpa.h are public, we need to add doxygen comments
> to all APIs and structures.
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>   doc/api/doxy-api-index.md   |  1 +
>   lib/librte_vhost/rte_vdpa.h | 54 +++++++++++++++++++++++++++++++++----
>   2 files changed, 50 insertions(+), 5 deletions(-)
> 

Looks good to me:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime