From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EC654618E; Tue, 4 Feb 2025 16:14:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAD2F427CC; Tue, 4 Feb 2025 16:12:09 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 2F76C410FB for ; Tue, 4 Feb 2025 16:11:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738681915; x=1770217915; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DbyiQlNe36sZbXIRrfSHSQilwsi4wijIEi7wQJE19HQ=; b=KdHTYdxPN/XYltzSm9uPGizz2WktLstRpHE7+z4+ELOUnOUGkzA8gH8G 55IZQlDF7B+ZAjaJ0pUDlXaAl/N11QgxjQ8C6WbKCHnxZGFvha4BAopdN U3pkSZGmCDKjFzpQsEjxDTBzTCO1SBUKCc9J25lFD7z6b6r/2WWOyfrnG GBPOuStkHDKDlwoAjuYKcxzU05GFzVvHUX2Je+jhU7OAAL+mfiro0vl4V P1IVXzYfZ7QBbUxV7bZrN4QWWQh/1VYOUX/YLdBrIhUaGiWn0jqviCSIg aXkeQeKpG/H1ZhVpLq/FXhxYj8iwFu2U8w2FVrL3nQ/i+KuR7gQqU/xN/ w==; X-CSE-ConnectionGUID: F4TKW+JzSU2mQ09Bh4JzNA== X-CSE-MsgGUID: POzbUb/VRH6zpIUsE+uv1g== X-IronPort-AV: E=McAfee;i="6700,10204,11336"; a="39097128" X-IronPort-AV: E=Sophos;i="6.13,258,1732608000"; d="scan'208";a="39097128" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2025 07:11:54 -0800 X-CSE-ConnectionGUID: gDkDP2VVQUOf/HhtJ+eG1w== X-CSE-MsgGUID: DARJyxxnTq+s7V4Tjg40Ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,258,1732608000"; d="scan'208";a="110792659" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by fmviesa008.fm.intel.com with ESMTP; 04 Feb 2025 07:11:53 -0800 From: Anatoly Burakov To: dev@dpdk.org Cc: bruce.richardson@intel.com Subject: [PATCH v2 21/54] net/e1000/base: fix LTR for i225 Date: Tue, 4 Feb 2025 15:10:27 +0000 Message-ID: X-Mailer: git-send-email 2.43.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sasha Neftin i225 specification recommends minus 1 microsecond from a value calculated for a LTR. Fix the calculation to match spec. Signed-off-by: Sasha Neftin Signed-off-by: Anatoly Burakov --- drivers/net/intel/e1000/base/e1000_i225.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/intel/e1000/base/e1000_i225.c b/drivers/net/intel/e1000/base/e1000_i225.c index 999fa03a3d..0b029c0ac2 100644 --- a/drivers/net/intel/e1000/base/e1000_i225.c +++ b/drivers/net/intel/e1000/base/e1000_i225.c @@ -982,7 +982,9 @@ static s32 e1000_set_ltr_i225(struct e1000_hw *hw, bool link) scale_max = (ltr_max / 1024) < 1024 ? E1000_LTRMAXV_SCALE_1024 : E1000_LTRMAXV_SCALE_32768; ltr_min /= scale_min == E1000_LTRMINV_SCALE_1024 ? 1024 : 32768; + ltr_min -= 1; ltr_max /= scale_max == E1000_LTRMAXV_SCALE_1024 ? 1024 : 32768; + ltr_max -= 1; /* Only write the LTR thresholds if they differ from before. */ ltrv = E1000_READ_REG(hw, E1000_LTRMINV); -- 2.43.5