From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0083.outbound.protection.outlook.com [104.47.41.83]) by dpdk.org (Postfix) with ESMTP id 1E8781094 for ; Wed, 5 Jul 2017 09:08:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fKzjjJlEmGO3jbqd89X3F76Q2OgUyBmVo9BDYNKMZQw=; b=VBpgVAgX4TTY45u5o4KcYqtB0g/nKZZBOHssNUOmgr+her+uSHdTcvgZN8kBPSSRogwA5/BD4spxuHEaeKEId9IEaBFkU9o215auJpT7eUKGY5antfA/yd11rdvfYGrGxLFqCTrGsuajxF30i2Zf3mOrvhSREiwyYWDcrjX5yzM= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from [192.168.0.101] (103.76.56.167) by BN6PR07MB3089.namprd07.prod.outlook.com (10.172.105.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11; Wed, 5 Jul 2017 07:08:09 +0000 To: Olivier Matz References: <20170621173248.1313-1-santosh.shukla@caviumnetworks.com> <20170621173248.1313-3-santosh.shukla@caviumnetworks.com> <20170703183715.3b1c8ff6@platinum> Cc: dev@dpdk.org, thomas@monjalon.net, hemant.agrawal@nxp.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com From: santosh Message-ID: Date: Wed, 5 Jul 2017 12:37:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170703183715.3b1c8ff6@platinum> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [103.76.56.167] X-ClientProxiedBy: BM1PR01CA0096.INDPRD01.PROD.OUTLOOK.COM (10.174.208.12) To BN6PR07MB3089.namprd07.prod.outlook.com (10.172.105.7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc837f7c-21d0-4005-ad20-08d4c3749904 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN6PR07MB3089; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3089; 3:A3DhkIQSGhs5HA1GIWo3pPx8HC/H1YJzkpFwkLd3iklIhtwizlZDiL17sRTVjiR5wu8UmcNxxBP1HeW2nBFQzkNtF2YMBThJ4WeXrCH5b1PgxpcH+Ir7EIs5lPp2nJzccJXgzYJXoimX19tysmwPIZOgegLUn//OX1rLJvOvq0KDFEfF4AaMM6dbJ5pI+HsISY5ZTFqbVbJ8Y5q3IljLvy0MS84TrzDkIusn4QkPCOXINVFGTXIRiADZKO7zuY3sgHXA5AxBmt75zWuPB/wt0L1xz24d1K2CL6gPdPbP2vyILHiJWfnPvoDn6WI2z16oILxdBUjHk+FHFE5ol3JiOndfUjcnlwDwTbODU9U+EgP4e5Hb/Pyskw3rqf5KSkgumcnIUV9gh04kONP3PTGxy1CoDsFumSoU/flcG6hNj78w0B5SlQd2bvPFM9naVGuYta7NrvZVWURZ1cvyVMLzG24QcfRhOfyUbdsm+lrq9AhKscpGqtqohoPvtC0dm2BQMnz3Ta8gvr66eoF66hWEzuuTyCFx8gx09mCfm6suZ9smbyctpGR2oCCKUsajCpdlPRn3vJ+uMUsu0UktWgR2KKbbE38mXVO0uUKaTXwPd3bpWI8/DlP4OT3dei7UKZF7y73nB16XFf0rLfQ+QPJ+lqoP6cAfhZktNm/3FnT8CHc40Egv3pMRl6jDBPcRVBHEu8jv+QJuWiopWyq/YW2G2fFDb3tIHdDChEWUr9gpUA2iupxl+CmZKIjdhr1x4Byq X-MS-TrafficTypeDiagnostic: BN6PR07MB3089: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3089; 25:n8jAvGO61d5Yl8qrbTBQ2dSIszkrnuX+9lAsH96bvZ0CgmR4OV7umFCXPTAzURfowKg5vXp60N7MnXLWqa/pcucC755lFw9plkIkgo2KT2iDLYGSv1fZnDO4sO0XElc5JUxHLAeOSBDEcKY6/koDHy+svwdVnYEmrMsrxwvAL9h+4oSKmB68XCAuZrt0R7j0t54FtwM1y3xqbVjMdIFvGe8i9rXYzeEpwdBa0y0/RDCf7MPTV63PJf3qrV6g+p4bZ/H5gApItq1KM3Easm6U2psbCJ32I6U0mr86SvJz56AUxRUOzTPvTKHHzFl+XZhvb5xX0wY5S4hFogwemBRtF0IgzzkHFxXeNCHmMHoKgneQuurXdOIaDYnAVqZ9YQMMUQ2utKnw7F92gmGZSIP+NlXthsmtHtIUNtkHQkepgxHFqU+HEzVV78JIE8rgu0gCPv05ZqQU13gzy8nq552I21vtztquuHUKbPJ4XXO62iicjl92eRsrCysIOI457fmR9cGScpcMGELcepwEHsbuPdY/ynlJCHe6aUydKw9dvktUrVZ41qnopq2sJwRawv0pc8+IzHT+L+wedTtljdujoniBovMsgsj9trI1JGdq7dzv02BdDlFR49L+JvIHRd4lNxrObdpztaJRf+mL/h98bQdlVNoF3FViSdBtAHGrhex4CTi7L7rVqMl7fcw5Kc7YUdKGsCOmFrIuvjenPb71vectveqGtFPkdJSu9NlaskvJTgjn9ktD2TS+2AfDlGq6eP9xurcPmPUXHeoeLJHq0d6aCFnQla+gD6bdooEJOANCyslskHfX5aZqGivviHtuuv2peRMd8lksM+aGXeLinSBBejPHBOaUcAfIT/+0baEh7hkqGiJiEyb1tisr36LP8+GgpS/QhfW2JdqtaUkAjg+y3geNKAGo6nZF4KZWJ6I= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3089; 31:KX/IcgqKL948XKRlPE/Waejj5EwKMyo97dh7ehgLZNjb0Nt6bzA1t21PxV6YAzYIt6Hg+GzRYS2jFT3RH0nM/nQZhAs9t/7ATYKwBTYVS5fvwinDsIiGXWayt/x3ArjofI8NYhAJ1cHEEzfe5stSccOIGI5dth/YUR1zBSpOOnyoYjtfZBPRTXBKnD6xA4J5VtyR7YenoIniKGM7zKc679FgRNnIT3qhdKbXRvZ2r7amyBM6jE9RAuPZ4pX8kYREa2aPSGZ8yqB72QtRU5mo/ih4ioJo8y4iXY70nxaVxk+jcesvVVD8z6JxPi/CiAIuBNrr4ECyztlYq2ZbsHW14Ke5vpidpOrKJ4JqDcmViHuABJv415rAwevcptuI2QP8N6/lrH6AJ7k/lo8iANPtFcaNARxFkGQkgdw025+RKwapt79RX39mmvcpJ/vWAEVefG/jSWqsPbAnu/0ZU41ZGUpq64wvG//SHA0+FvBLqYfXrrjbW0moGzlFFFv43Ox3avhacb8h/csK1Pe/F1peFwRhSH0DIgGzBszHs0rzBzR6bdeZgCFrxbHTBdhVpEiwEdBnZfQyMPEZPkwlNNbCnK94J16LNvI0MUri/4lwoXUfWQUr2LV/qjyR6STW3NshErAnTpCZ9mgi+GNqytw+au2J84oUK0rkGYbOhtLCuTk= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3089; 20:7iAem+w60RQivZrT3JoLpgai4emyz1+wfOb2jWOTMV9wQA3mlFCDdroz5LycMP7Sxs4wcoWnnmRwmivwirE+f3dSxHHVMeLJiLQVo6dsyhUdKsi1nhkDLRMikpcYQgN2IQOtpOh+s9YBy1hcaU3XIzt/EGBRdEYi7/Rh6aKBXZtAUC4qR4yhz6DZSCJ7TrfE/gdCV9FrC11s6/7h11E27PXDtFHoUXDaBIS0zRz2mWkO8nUiWdwwwIbKMpBGIWEr9cVNNoR7hSgzPonMXjJ9LIkltvDBrG+2YnZZz617vaDtLJacbVUTJvqyFEfqCUGAqnQOAdr/SOrRmnR8aNxsmZ1jAnpr9rTsPJSso/xKDyFWmuM4JwvfcllAfnRnteAQlABNl8v/AV54tH0ac73s3o388t2pd2Ovloda4T3vgRpelLl8C4ZE+Rz3wXSJETQFT3s/euir1zSQx5gKOE681aVHLEpo1PDpnpxS9K2nlVQxGyvrxaJYR7Qg4bfYI8Ere0MKxD9caauCxkBm/9okMN6kfondxQC87ESilBDTI+GWfuZj1fLroae85JC8Y7WCMO4cjw+Kk6n+CE4W/8+hGco9P75Wb2qOvKrPnRIFX4A= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236129657087228)(247924648384137); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3089; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3089; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR07MB3089; 4:tFrPhXPYoX3RLSaJdAa0MME2KHDViaJuYTC3HW?= =?Windows-1252?Q?GcAoTIfrt5eqqsaBJl4j6RhrXBK8ZcZcLSPQDfJYktm4HXZi5y8nkEp0?= =?Windows-1252?Q?v5u+hklVPQ2+mIL+/kVAWd7jYBScTKgWrSAlPZ/cgKJzNL7iokV0cvVA?= =?Windows-1252?Q?vnpcJCGIUoQX/am3ZWoCePwz3B9DJvJN7oJbgWxTME8P63CYGObHUfZb?= =?Windows-1252?Q?gzT6B1VQd0UQWzdn0r/FfdyqQx9bonx3Z/QJZbOnD2YYF4i4t65zwIF5?= =?Windows-1252?Q?RT058dF0qK4nr95oCkoWdQi9Ac2HVzOxl7dQofvKsHCd82hj6YXAGCyK?= =?Windows-1252?Q?JJiZxbvkme2g1Tefaz4IKcOXlWzHFw7XmUF28qWa9A/4el0et3j3+i3z?= =?Windows-1252?Q?GvBE0pDTMhxSh5VVrR3PKNRe/oI/Rzb52ptAGFk1Ra6X+4ReX3n3yT/H?= =?Windows-1252?Q?sAl8xxgT7segzDnnN2AaP/bzcuQkAXO+2rLil/UU5QF5GlyMH0H4smhR?= =?Windows-1252?Q?9bwbQlw4SULRC1cHZJEIEFi7fEyZazqWhM8A3gBh2C+BCOOeKkobHP9G?= =?Windows-1252?Q?KKPgqicJ0aqdAoS4vzr9ZKaMBBbXjk00tbKMoSYkBq00WYdrGG6Rlsyb?= =?Windows-1252?Q?yaDdjX8nc0K68TIBSI1OnQ8RBBBwppb2mY6Z38lRpzbEjBJVctdGlk+K?= =?Windows-1252?Q?G6wHfjSnX2qALUe042dGDcGTzr+Sa+i6VH2e9b1QlVSsYxZU0KrQuchW?= =?Windows-1252?Q?ZHPW8ahmKkFr0gKivfve0rvyWA/WoA4EENeGkZZy7eJ3wR7j/RJnO3R9?= =?Windows-1252?Q?1TRXyb+D5mzSM5xR2b+tr7dl642LtGWUTAnLJr3moMANgPIh391Sq0SP?= =?Windows-1252?Q?Rnmj+JuEGQPKa0taPEyBR9fvow/dL4Wgt9STMIiZgFubGnfQI5MlyAMh?= =?Windows-1252?Q?eoymiVcuIqGVpDHby7V5L7ejmsfQwfgkyEd/2bqTAk3saYEAS3SSUsLZ?= =?Windows-1252?Q?4vPwbUHjIAdMsB7SKEmfwr50AtUbPveeyYgV70AnPga5Fszp8/ZZjAoe?= =?Windows-1252?Q?vxzjnkZabK/eN4mjMRugGLLRgqVmb8aCQuDAiExopdp9z+SHoA5AwzNt?= =?Windows-1252?Q?5wQVb+x3aXDFfINmR3tjS+E0g96iLI82ZxXNBuOVDlhNStDk58eERXEI?= =?Windows-1252?Q?K+Z5b2tLWFkfXH/XJ2aY84dvW7irSxM67LYLngORnldqMREDav5NZ/6J?= =?Windows-1252?Q?UIBQdhnhnmkk8EY5Qj3X5LdC2CbQANyc1XaZvPnV6BZoHKooq48qGnYM?= =?Windows-1252?Q?9J?= X-Forefront-PRVS: 0359162B6D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(39840400002)(39450400003)(39410400002)(39400400002)(377454003)(24454002)(50986999)(478600001)(54356999)(76176999)(72206003)(65826007)(4001350100001)(23746002)(65956001)(66066001)(86152003)(2906002)(8656002)(230700001)(6116002)(83506001)(50466002)(3846002)(5660300001)(7736002)(4326008)(6666003)(53936002)(31686004)(110136004)(42882006)(38730400002)(81166006)(189998001)(2950100002)(305945005)(6916009)(8676002)(42186005)(36756003)(33646002)(77096006)(117156002)(47776003)(25786009)(6486002)(229853002)(31696002)(6246003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3089; H:[192.168.0.101]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR07MB3089; 23:/Dlm71V6vXUns1kgrUPZpIjTXALB/EC2aMCKT?= =?Windows-1252?Q?tt0id27vKCb6/4Ni+dJxFvdeyR69d/t8Gu/rI7wBzvFDrvlFRxBzUDX5?= =?Windows-1252?Q?MfTAVcLfbXaq4U32h9tR3XBGEUDH0l3WoFs7hWtO8E1GkcDbdZ0nEfIL?= =?Windows-1252?Q?4lfjmDvZjfkjChru82uDYh9XCcwctKeJFfTYHBo2RHtPRTKY64ekns1o?= =?Windows-1252?Q?hcreKy0KFazVq1QLu/doTqrhJb3Q6u0JnIxhEO1N08y7kq8BxsF/tO+D?= =?Windows-1252?Q?Ykfx7189XnBrx+YYiDdGYYaIwB71lbxet3iv4IDdbcSnd/T54cZB7vGs?= =?Windows-1252?Q?GlCzm0JCi9YU4HMc4hDtbHZUcFV9D6ItaGRUKeaIoMNbe9wFp6ZAFMQe?= =?Windows-1252?Q?6OizEQwlsQxX7QQSNup3QROrVqtQRM14SthyZ/VzAx8yKBVbDaMJPD2i?= =?Windows-1252?Q?Y4tZFItsJmJOYCtApt7z5Uz2lwpaUvXCtHtVyKmw8jloBBSZxgWXGkNy?= =?Windows-1252?Q?XhU2lZ6+x5x3mCDCSD6JDUIVDlw4ZOOp69Zk+K1shjMfRtnEy/3nNDiT?= =?Windows-1252?Q?2vJGAl4fPWiTZcG+Kv5rVe4/J9tDWAj0KetdsfPjHgR8JBXSm8sptPMj?= =?Windows-1252?Q?6Z4BWqjA6OJt/l1Q2K2tHpraaIYPNkg/hj4xAM3Z7zN21ZDDXhiQnP0p?= =?Windows-1252?Q?47HaIzkexnK5rNUAUrOKoMqwfBDoU+kH8VIW5h7gNw1JT+yhWEXDcBe+?= =?Windows-1252?Q?Ddt6oAOE7jOucGXJLn3TDl3ILwSnGJsyV86/Jc9hshBtTtceF4EvQcpH?= =?Windows-1252?Q?/ds+wZJYi+wY5DEAaDWHsNxnMuMyjiwzv7/azADA0oQejNZSjetR2UbB?= =?Windows-1252?Q?oaGYxR3t3EQrnB+kx28dA4wDP81mZsPRk+Bm07nhE/TfUo+9OZas85+I?= =?Windows-1252?Q?Qyb88091GUToTL3r8H2uIJv5QG8iJPzzT/XiF6A9O2PVcPazor9paozM?= =?Windows-1252?Q?FtYcq2TukEQBBprsceW9sAYGIyTEKzJ8sKbuvTnV3V0xUsZjfSRCq4Lk?= =?Windows-1252?Q?wYLbRsZ1hIg6RzVUz3OqM+29Whs0JH3gOkKlaSX423pgn4a+0G8CKh62?= =?Windows-1252?Q?fVEWVCPoqxB6ia4u3OY8u09Uzw6c+ufl8zXhPI2HXLNMFpQK6BViSFdY?= =?Windows-1252?Q?fKinxpjI2KTwAvBh4OynVOip04eKKNSgWWxaXDJMpUTgdGNdRZWwyJhh?= =?Windows-1252?Q?wJQHQGPSYtC7FIluEBjXPvdreqs3UlURbM7UHtd2GaQ1pjGe6e1BEDD4?= =?Windows-1252?Q?iqogUOANgfGTncBiFNCC8BCk894uOUZCcz6ByntcTyDn9Pn0yDAHDr/8?= =?Windows-1252?Q?/E71+SgXvGDXfog/iLjfcJ4xXwNdIEJIA=3D=3D?= X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR07MB3089; 6:hJSco9PR4mNaadCdQFVBvwhmjvQVpfoIEhRvDV?= =?Windows-1252?Q?uvoX9ENsyLWtOn8qbt1ugtjiU0C43fxUnmxDo8vCpSQCBCfPYGubwQZK?= =?Windows-1252?Q?33q+/nLFJ2f2YnuHTsD+5PAnWp7aYlaCyUo7jGC8utKB8uriU7js/nGV?= =?Windows-1252?Q?BOW1r/6BWkXkEV0eUFU5nCr0GmfoE4HUcmg11tOEeMAVslGB/Qna8rvu?= =?Windows-1252?Q?DThigt4ILVZh083Ind0IyELQ0s7VDbswXp1s5NLq6+VR54tkNkOMpOfX?= =?Windows-1252?Q?91T56f+7ErChhOxe9kpdMAz9QKSNii2vOMmKfr4/2o7cM+QVaFvH6cJt?= =?Windows-1252?Q?cMaC/hH5cGI1T59JMBldCn3kKpUL0lKGuSXcaQnEBTHjk8NvVRAIr+45?= =?Windows-1252?Q?NcZephY77Fi96lifFwNzEoqTlfr+LazqKLbtDnYw+bptUf7MaN8tTiND?= =?Windows-1252?Q?YLcTZPoNEujIdKQ9zVfqaG2ntHU4/+xfvZGRDsW1z85Ot5cYMkUP7BOr?= =?Windows-1252?Q?QOLH6t9b6yaPqArJSrSJa1KGNcFUVC7i1dvJyT4iuistcY06tdYbK4L/?= =?Windows-1252?Q?tB6eD66gm++SPm75AT5EXO5XUTMnjyY7vuYLprDTJNeWXbqc9BOWKmUE?= =?Windows-1252?Q?BUXPzYsL6j5GzRcVIKtxY0wi0sN4wXqexcQMwOwD+yMNVioZw96N69r9?= =?Windows-1252?Q?BASPKaH8uuqoLT4cgqrERJ1lUIWkArYBwGVlSgZO9xkH7eNwj2CXcL0z?= =?Windows-1252?Q?RjmD2CnCtfXGbWn89b5ZHoTKdwVFopRCU10PkfwLququ9KGiscFA6H5E?= =?Windows-1252?Q?W17SdE7Si3/amMLg9xnikv0WDCt34B+8zoyIurkc9e2sRLE146hR4/2a?= =?Windows-1252?Q?nPOFHG+2LyTytEPRd2vCV67+4DjdK2LenudGnIn8BsX870F5O8F8N+S3?= =?Windows-1252?Q?cr4PlxYrcD58M1Th3rKlW+//GlKHEFwt+TK+cqsi29ijv5AuBvCMaTHW?= =?Windows-1252?Q?Dg2c5CF6EF6C4RUG0/8o+utFW8NyNX8pPzYLcJxJSpbhiJAJWDKTZ+gA?= =?Windows-1252?Q?OmCMY5FS13fPY=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3089; 5:UtXwYLyylzp+Iu/Q1djSVDYl9mtJgdz4s+QvBYG4kZ9i64cDfpQrT+okl5HL+1qFtA0A/fiphIPiD2KO+QKr3u/+rxXr/5ObnyCahYm/YjbukdTb5Yq56LUWqvGrtnwzvEJnWMPSMDmrHNLehq3AsfaMA8S7XacgT0xLLA3Xgl3K8jUDuEQdP8XRg26r4IppeUJkgIbYqmLUcQN+Eg9hZPh1WYma8ChaotylxBpja9oOHuu2A4z7CKCSE05uE5IBALWg+XHeFRDVU61nBHsUBr418kLToX86+i8FXZXyszUHnOiTNNQpQg9LG0B41fblPRiOUgWi5YpVSIUcG+5q7N81pglcxXuIDXDi1DLmftPwnb941P3iR4wFRxgWGE5HYiT//r1qevD907VCVk1rwKHMVS4atzaJYu2YlLhu/eLGmrY2PFwePC0ZMS7aZ1knZp9kJJZ6VRQtsJNUulOu7JaTehpnjbFcvDsvqIkW+6CSuP5SZP6W7OMOwxwfSvbE; 24:7keOwMdQnIBXWN7b96qZdxxMCI0pXbKFdqPcVh4XNTtDG6nOQKMJBdYsQwvBFeiYF0disO72VL/jb5boBMgY5bHhO1yswAlcH+qVW7D+B7o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3089; 7:lkC0l410Kjeqy7llXWgAiSisPkLEH5vG6hkpykNoNVVfWrQMNPOqFaDGg5HWcWVBzfV9opJSqf7xP8OSmNlnq/fOlYL57dKmg2FRcQMDjUwRkqDQo2JzmJAUEGjZ4O727OQu3rHSlErCN6QqGnhlMhJTNL6hmN2EBW/593vuDmSZ95RX0dyJlDSXJcvJ9iGn3vE3MTpcIFKGtq/pMy4z8gLI7GasfuQA9JStmjo1cmSvXozdELdfP/jjVosBlcpWA8+Ob8hnM98rkXfqBCpLro4tZVMlZSyxFYPbwg6U/RCLZ4OFSKi9FdQz+1PuLvEP4u1J6lt4kGksQUrIVlBRRZ1twJM4Uha0e9sfR+6tEhmAFPF5lE91paNHOSzjaTDLoqvpJw59faQCT4TuZgQj9yWwZDEgIki9GKZUcTqD48cE+eYuIq1ZIob77XZEjLAPAfT5+ipRH4kWC9qxrBSSmX+rzHkXNVxkm0igBJ4zhXYd0i7RSPhmB1D+q9KI/kTxs49jOGd4VxQO2WlZ10itxJXnVt5f/HjOs43gyV9j39e2l89hWV7t/j+/V2Mg8QcitKbxcYWq/TqWEZ9SlwAhFT5ACB4Xlv17IhTSJK/DT2R3VLqnaSwYu7axBT273GM+741ejDo45il8mcbInMS03uQDUJOLZuoyq+MxRl3hD+Jlbul2Np0Z7YX4+PAkAH0vU+GgtYriIVYytd6qKyTPM8a5xJl7uNxfYXbUm5XX2vhFWcpV+ofMNRU3TzjGIkFVjGWl+fPBfZFVeHJjf16ovw/MYLXGpm8ubVgMOGfglZQ= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2017 07:08:09.9894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3089 Subject: Re: [dpdk-dev] [PATCH 2/4] mempool: detect physical contiguous object in pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 07:08:14 -0000 Hi Olivier, On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: > On Wed, 21 Jun 2017 17:32:46 +0000, Santosh Shukla wrote: >> HW mempool blocks may need physical contiguous obj in a pool. > This should be clarified: the memory area containing all the > objects must be physically contiguous, right? ok. >> Introducing MEMPOOL_F_POOL_CONTIG flag for such use-case. The flag >> useful to detect whether all buffer fits within a hugepage or not. If >> not then return -ENOSPC. This way, we make sure that all object within a >> pool is contiguous. >> >> Signed-off-by: Santosh Shukla >> Signed-off-by: Jerin Jacob >> --- >> lib/librte_mempool/rte_mempool.c | 8 ++++++++ >> lib/librte_mempool/rte_mempool.h | 1 + >> 2 files changed, 9 insertions(+) >> >> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c >> index 045baef45..7dec2f51d 100644 >> --- a/lib/librte_mempool/rte_mempool.c >> +++ b/lib/librte_mempool/rte_mempool.c >> @@ -368,6 +368,14 @@ rte_mempool_populate_phys(struct rte_mempool *mp, char *vaddr, >> >> total_elt_sz = mp->header_size + mp->elt_size + mp->trailer_size; >> >> + /* Detect nb_mbuf fit in hugepage */ >> + if (mp->flags & MEMPOOL_F_POOL_CONTIG) { >> + if (len < total_elt_sz * mp->size) { >> + RTE_LOG(ERR, MEMPOOL, "nb_mbufs not fitting in one hugepage,..exit\n"); >> + return -ENOSPC; >> + } >> + } >> + > We should not reference mbuf, we are in mempool code, dealing with > any kind of object. ok, in v2. > Also, len is not necessarily the size of a hugepage, but the size of the > physical area passed to te_mempool_populate_phys(). The idea is to make sure that blk_sz (total_elt_sz * mp->size) fits with in hugepage. So if rte_eal_has_hugepages() is true then 'len' is hugepage size, in-case of non-hugepage this condition would fail. Does that make sense? if so then I'll modify comment and error log. Otherwise could you pl. suggest better approach to detect phys contiguity. >> memhdr = rte_zmalloc("MEMPOOL_MEMHDR", sizeof(*memhdr), 0); >> if (memhdr == NULL) >> return -ENOMEM; >> diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h >> index c3cdc77e4..fd8722e69 100644 >> --- a/lib/librte_mempool/rte_mempool.h >> +++ b/lib/librte_mempool/rte_mempool.h >> @@ -266,6 +266,7 @@ struct rte_mempool { >> #define MEMPOOL_F_SC_GET 0x0008 /**< Default get is "single-consumer".*/ >> #define MEMPOOL_F_POOL_CREATED 0x0010 /**< Internal: pool is created. */ >> #define MEMPOOL_F_NO_PHYS_CONTIG 0x0020 /**< Don't need physically contiguous objs. */ >> +#define MEMPOOL_F_POOL_CONTIG 0x0040 /**< Detect physcially contiguous objs */ > We must highlight here that it's a capability flag. > Following my other comments on the first patch, this define should be > renamed in something else. I suggest: > > #define RTE_MEMPOOL_CAPA_PHYS_CONTIG 0x0001 > > The description should be longer and more accurate. > > I'm also a bit puzzled because this is more a limitation than a > capability. ok with renaming flag but per my [1/4] comment. But i find it makes more sense to - not differentiate PHYS_CONTIG with existing mempool cap flags. >> >> /** >> * @internal When debug is enabled, store some statistics.