From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED576A04E6; Tue, 17 Nov 2020 15:33:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6029F37B1; Tue, 17 Nov 2020 15:33:30 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 01085F90 for ; Tue, 17 Nov 2020 15:33:28 +0100 (CET) IronPort-SDR: 16iJRo495YtQpKg0syPouMnaE3dBSkcxx2zNv1rWriXB7bM3fCgLSJph5rfn3btjxs3fTgWXq1 gUPfrDBNc/iQ== X-IronPort-AV: E=McAfee;i="6000,8403,9807"; a="150781200" X-IronPort-AV: E=Sophos;i="5.77,485,1596524400"; d="scan'208";a="150781200" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 06:33:27 -0800 IronPort-SDR: JQDcWdp1MgQeNE7XvEqRMw7xPBlsyfITsCkjQWX96CGe81qJ/Hb1b5LNyhrjsPR4lm7oGyCIXq PALdOcf6Hk2w== X-IronPort-AV: E=Sophos;i="5.77,485,1596524400"; d="scan'208";a="475941785" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.210.196]) ([10.213.210.196]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 06:33:25 -0800 To: Gregory Etelson , dev@dpdk.org Cc: matan@nvidia.com, rasland@nvidia.com, Viacheslav Ovsiienko , Shahaf Shuler References: <20201111071417.21177-1-getelson@nvidia.com> <20201116140224.8464-1-getelson@nvidia.com> <20201116140224.8464-3-getelson@nvidia.com> From: Ferruh Yigit Message-ID: Date: Tue, 17 Nov 2020 14:33:21 +0000 MIME-Version: 1.0 In-Reply-To: <20201116140224.8464-3-getelson@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 2/6] net/mlx5: fix build with Direct Verbs disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/16/2020 2:02 PM, Gregory Etelson wrote: > Tunnel offload API is implemented for Direct Verbs environment only. > Current patch re-arranges tunnel related functions for compilation in > non Direct Verbs setups to prevent compilation failures. The patch > does not introduce new functions. > > Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") > > Signed-off-by: Gregory Etelson > Acked-by: Viacheslav Ovsiienko <...> > +void mlx5_release_tunnel_hub(__rte_unused struct mlx5_dev_ctx_shared *sh, > + __rte_unused uint16_t port_id) > +{ > + return; > +} There is a checkpatch warning about 'return' in the void funciton, will remove in next-net. Also will fix the snytax and move function return type to one line above.