From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8C55A0A0C; Fri, 2 Jul 2021 10:55:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6097841353; Fri, 2 Jul 2021 10:55:05 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 4B65A40686 for ; Fri, 2 Jul 2021 10:55:04 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id CCF407F504; Fri, 2 Jul 2021 11:55:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru CCF407F504 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625216103; bh=Er9p09cGMVfRpw7LpWIh2xHurffXPr7QCnvUXMf/1W4=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=L3oI72/TEXqoLwvvCI8fY0xE6sGkL3AKQSSLi0/Txn/VO1eBdRY2K26GKpkjSrr6y G46MDdn3gMk6RCgf7DbfZ2nRQF+LtT2JRvug160FvNRmmHtueSJHl/dtjE1DF/gzl6 meY4cMj3LdAkmz2Eii7TTMLQU3SYUr6jMT/BvZ7c= To: "Min Hu (Connor)" , dev@dpdk.org Cc: ferruh.yigit@intel.com, thomas@monjalon.net References: <1620378499-5090-7-git-send-email-humin29@huawei.com> <1625018183-58204-1-git-send-email-humin29@huawei.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Fri, 2 Jul 2021 11:55:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1625018183-58204-1-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] doc: add link status event pre-conditions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/30/21 4:56 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > This patch adds link status event pre-conditions. > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- > v2: > * not modified, only waiting for 5.13 kernel released. > --- > doc/guides/nics/hns3.rst | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst > index cf72810..c5c55d3 100644 > --- a/doc/guides/nics/hns3.rst > +++ b/doc/guides/nics/hns3.rst > @@ -115,6 +115,16 @@ Runtime Config Options > For example:: > -a 0000:7d:00.0,dev_caps_mask=0xF > > +Link status event Pre-conditions > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +Firmware 1.8.0.0 and later versions support reporting link changes to the PF. > +Therefore, to use the LSC for the PF driver, ensure that the firmware version > +also supports reporting link changes. > +If the VF driver needs to support LSC, special patch must be added: > +``_. > +Note: The patch has been uploaded to 5.13 of the Linux kernel mainline. > + > Driver compilation and testing > ------------------------------ > > I've added extra empty lines before new section and changed prefix to net/hns3 since doc sounds very misleading for me here. net/hns3: add link status event pre-conditions Add link status event pre-conditions in the driver documentation. Applied, thanks. @Thomas I'm not 100% sure about such links in the documentation. Please, double-check.