From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AD04A0471 for ; Tue, 16 Jul 2019 17:00:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0EA382BF5; Tue, 16 Jul 2019 17:00:59 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id A49BA1B53; Tue, 16 Jul 2019 17:00:57 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 14102A8006D; Tue, 16 Jul 2019 15:00:55 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 16 Jul 2019 16:00:39 +0100 To: Bruce Richardson , Ferruh Yigit CC: A.McLoughlin , Wenzhuo Lu , Jingjing Wu , "Bernard Iremonger" , , , , Thomas Monjalon , Stephen Hemminger References: <20190712083221.4987-1-aideen.mcloughlin@intel.com> <6dec383f-a559-7036-8ecd-22f11f2c1d5f@solarflare.com> <131f21d3-dd47-4536-655a-0bb7af54ee0e@intel.com> <20190716142823.GA1313@bricha3-MOBL.ger.corp.intel.com> From: Andrew Rybchenko Message-ID: Date: Tue, 16 Jul 2019 18:00:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190716142823.GA1313@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24764.000 X-TM-AS-Result: No-12.027600-8.000000-10 X-TMASE-MatchedRID: EMyCvCfVN1HmLzc6AOD8DfHkpkyUphL9amDMhjMSdnkmwE7sgPtN9gAH NJDKNbPhvbQicXCNkiQABGAQkj8VcWE12GZvI1jlEhGH3CRdKUVXjjsM2/Dfxgg2kgWdt3qahp4 SQh/ttLd1eqDjq1nHWiYQx2PIQgZESc0meJ+asng1VHP4fCovgpY4MP/LOm93B2QWi8BF5SiArq oIZrVn164TFeUM+0iB7KGNpgCqvMgfOjKSU0pCEQ3BRWEgXqlWGwKs3RUcsbgN+F513KGyq1pWP E37MsM+7pA1TBPNQ91iMBwCX1lHZkP8wYcu6bTezfqlpbtmcWj9VCCsocWPatfVxEPp7g/kYObL IBJK7EFVLniVVFJTYSZEI52vGo1+0cvBfcPxgBO2FZ3uVRBKVZGi2FvzLDzA+QYBHm2fyHfbEtj PX1xJPZMnmGlI37lV62ejkWvjtBRjyj59yPGk5LsHVDDM5xAP30ZykK+rMdpE6qvV2uOcuXtcSB Xe4RfN/SwzVfmaVyibhFaTwD8pPUDsrsj0YBWFw0z6QDA9shN9LQinZ4QefL6qvLNjDYTwsuf7R WbvUtyrusVRy4an8SAHAopEd76vaDrKSCjaZQSWTvJBzudFlak5VRMq0XaLdsUgykgS849c3KTo lXFLtg== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--12.027600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24764.000 X-MDID: 1563289256-k45bJRLZHbhz Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/16/19 5:28 PM, Bruce Richardson wrote: > On Tue, Jul 16, 2019 at 03:23:03PM +0100, Ferruh Yigit wrote: >> On 7/16/2019 1:23 PM, Andrew Rybchenko wrote: >>> On 7/15/19 5:53 PM, Ferruh Yigit wrote: >>>> On 7/12/2019 9:32 AM, A.McLoughlin wrote: >>>>> The 'Accumulated forward statistics for all ports' incorrectly displayed >>>>> double the actual value for 'total_tx_dropped'. This was because 2 >>>>> lines in the same function both incremented total_tx_dropped every time >>>>> a packet was dropped. I removed one of these lines to fix this issue. >>>>> >>>>> Fixes: 53324971a14e ("app/testpmd: display/clear forwarding stats on demand") >>>>> Cc: david.marchand@redhat.com >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: A.McLoughlin >>>>> --- >>>>> app/test-pmd/testpmd.c | 1 - >>>>> 1 file changed, 1 deletion(-) >>>>> >>>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c >>>>> index 3ed3523b7..c41bada50 100644 >>>>> --- a/app/test-pmd/testpmd.c >>>>> +++ b/app/test-pmd/testpmd.c >>>>> @@ -1555,7 +1555,6 @@ fwd_stats_display(void) >>>>> total_recv += stats.ipackets; >>>>> total_xmit += stats.opackets; >>>>> total_rx_dropped += stats.imissed; >>>>> - total_tx_dropped += ports_stats[pt_id].tx_dropped; >>>>> total_tx_dropped += stats.oerrors; >>>>> total_rx_nombuf += stats.rx_nombuf; >>>>> >>>>> >>>> >>>> Hi Aideen, >>>> >>>> Indeed 'rte_eth_stats->oerrors' and 'tx_dropped' are different values, >>>> >>>> in testpmd, 'TX-total' is taken as "total_xmit + total_tx_dropped", from this >>>> description it may be fair to say >>>> "total_tx_dropped = oerrors + tx_dropped" >>>> >>>> This is easier to see in HW devices, 'oerrors' is the packets sent to HW but HW >>>> reported failure for some reason, so these packets not transmitted to the medium. >>>> 'tx_dropped' is mostly calculated by application, driver returns packets that >>>> can't able to sent to HW, so application can re-try to send or free them and >>>> increase 'tx_dropped' counter. >>>> >>>> >>>> The problem is in the virtual drivers, the packets not able to sent are >>>> calculated as 'oerrors' and tx_burst functions returns the number of the >>>> successfully sent packets which cause application calculate remaining ones as >>>> 'tx_dropped' which cause the duplication. >>> >>> I don't understand how it is. Tx burst returns a number of owned packets >>> (either successfully transmitted or internally dropped/freed). If it is >>> smaller than number of packets in request, other packets are either >>> retried or calculated as tx_dropped. >> >> Virtual PMDs, at least the ones I checked, calculating not sent packets as >> error, also application calculates them as tx_dropped. >> >> Like: >> https://git.dpdk.org/dpdk/tree/drivers/net/ring/rte_eth_ring.c?h=v19.08-rc1#n97 >> > That is probably incorrect to do. Virtual PMDs should behave as real ones > do as far as possible. I think we should change them to not count as errors > any that are not handled by the driver, provided those are returned to the > app. I agree with Bruce. It is a bug in ring PMD. If so, too fast attempts to transmit packets will blow up err_pkts counter.