From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0CF2241E96;
	Wed, 15 Mar 2023 03:02:34 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8817240A7A;
	Wed, 15 Mar 2023 03:02:33 +0100 (CET)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
 by mails.dpdk.org (Postfix) with ESMTP id 95721400EF
 for <dev@dpdk.org>; Wed, 15 Mar 2023 03:02:31 +0100 (CET)
Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.57])
 by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Pbttt2rJGzKmvD;
 Wed, 15 Mar 2023 10:02:14 +0800 (CST)
Received: from [10.67.100.224] (10.67.100.224) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.21; Wed, 15 Mar 2023 10:02:28 +0800
Subject: Re: [PATCH] app/testpmd: support dump ethdev private cmd
To: Ferruh Yigit <ferruh.yigit@amd.com>, <thomas@monjalon.net>, Aman Singh
 <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>
CC: <dev@dpdk.org>
References: <20230314115035.33356-1-fengchengwen@huawei.com>
 <f59e455e-3365-2d82-d2d1-d89c071a3e38@amd.com>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <bbdfc4bb-0c41-a4d1-d473-42c352137333@huawei.com>
Date: Wed, 15 Mar 2023 10:02:28 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <f59e455e-3365-2d82-d2d1-d89c071a3e38@amd.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.100.224]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2023/3/14 21:45, Ferruh Yigit wrote:
> On 3/14/2023 11:50 AM, Chengwen Feng wrote:
>> This patch adds 'dump_eth_priv [port_id]' which could used to dump
>> the specific ethdev port private info.
>>
> 
> We have already "show port ..." commands to display various port related
> information, what do you think to follow same syntax for port private info.
> 
> Something like "show port private_info <port_id>"
> 
> 
> Or it is possible to append this to the output of the existing port info
> ("show port info <port_id>"),
> as a new section of output if port has private info?
> 
> This can be an addition parameter to existing command but not sure if we
> need it, like:
> "show port info <port_id> private on"
> 
> I think displaying private info as port of port info without additional
> parameter is OK, it is simpler.

+1 for this, will send a new patch.

Thanks.

> 
> 

...