From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DABC0376C for ; Mon, 4 Sep 2017 15:58:02 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 06:58:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,474,1498546800"; d="scan'208";a="145303054" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.130]) ([163.33.230.130]) by orsmga005.jf.intel.com with ESMTP; 04 Sep 2017 06:57:59 -0700 To: Maxime Coquelin , dev@dpdk.org, yliu@fridaylinux.org, jfreiman@redhat.com, tiwei.bie@intel.com References: <20170831095023.21037-1-maxime.coquelin@redhat.com> <20170831095023.21037-11-maxime.coquelin@redhat.com> Cc: mst@redhat.com, vkaplans@redhat.com, jasowang@redhat.com From: Remy Horton Organization: Intel Shannon Limited Message-ID: Date: Mon, 4 Sep 2017 14:57:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170831095023.21037-11-maxime.coquelin@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 10/21] vhost: initialize vrings IOTLB caches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 13:58:03 -0000 On 31/08/2017 10:50, Maxime Coquelin wrote: [..] > +reset_vring_queue(struct virtio_net *dev, uint32_t vring_idx) > { > + struct vhost_virtqueue *vq = dev->virtqueue[vring_idx]; > int callfd; Probably ought to have a bounds check on vring_idx..