From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DDF4A00C2; Wed, 22 Apr 2020 11:59:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB3A91D51E; Wed, 22 Apr 2020 11:59:26 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 90CEA1D453 for ; Wed, 22 Apr 2020 11:59:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587549564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+HSGeArOMyRRrPsgd0TES6TQGJwyCmo7WSIGxKOcnUE=; b=Za+KaQ7/c19ZMcZEu65A42yqVFyj8H5KHlW089STnjaLb5kr8oh8CsaRKpjzvQnrX0vzKw xfbsANpunjM9W/zW87o4pP/x5JfHrILzdfAFyUpJeF6CGXnmBnZZcZA/ynvHdRKsSSV0GW Xj/qYOwxr6HqOaO0vXJ+NaECuyqV7h4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-heoU_pmQNNeB_7irmWTHoA-1; Wed, 22 Apr 2020 05:59:21 -0400 X-MC-Unique: heoU_pmQNNeB_7irmWTHoA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2F3218C35A0; Wed, 22 Apr 2020 09:59:19 +0000 (UTC) Received: from [10.33.36.244] (unknown [10.33.36.244]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAE41385; Wed, 22 Apr 2020 09:59:17 +0000 (UTC) To: Ferruh Yigit , Ye Xiaolong , Beilei Xing Cc: dev@dpdk.org, haiyue.wang@intel.com, qi.z.zhang@intel.com References: <1587558164-5504-1-git-send-email-beilei.xing@intel.com> <20200422073102.GD105307@intel.com> <264593bd-f786-d03a-164e-bd0e7f448c8c@redhat.com> <56451aa6-63d4-a02c-2cc0-6408ea6551fa@intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: Date: Wed, 22 Apr 2020 10:59:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <56451aa6-63d4-a02c-2cc0-6408ea6551fa@intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/ice: fix flow redirector issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22/04/2020 10:35, Ferruh Yigit wrote: > On 4/22/2020 9:40 AM, Kevin Traynor wrote: >> On 22/04/2020 08:31, Ye Xiaolong wrote: >>> On 04/22, Beilei Xing wrote: >>>> If there's VF reset, the kernel PF will remove rules >>>> associated with the reset VF no matter the HW VSI ID >>>> is changed or not. So DCF should redirector all rules >>>> associated with the reset VF no matter the HW VSI ID >>>> is changed or not. >>>> >>>> Fixes: f10cde8e8478 ("net/ice: get VF hardware index in DCF") >>>> Fixes: dc0f06849e50 ("net/ice: redirect switch rule to new VSI") >>>> >> >> I think these commit-id's will need some fix up before reaching master >=20 > We are aware of it, but these fixes are in the next-net and next-net keep= s > rebasing on the main repo, so commit ids keeps changes there. These shoul= d be > fixed while next-net merged to main repo. > I tend to squash fixes in this case whenever reasonable, but not always. > Frequently pulling from next-net to main solves this issue too. >=20 Thanks Ferruh - I know you do a good job on this. Was just flagging as I noticed while checking if it needed a stable tag (it doesn't). >> >>>> Signed-off-by: Beilei Xing >>>> --- >>>> drivers/net/ice/ice_dcf.c | 2 +- >>>> drivers/net/ice/ice_dcf_parent.c | 2 +- >>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c >>>> index 4c30f0e..0cd5d1b 100644 >>>> --- a/drivers/net/ice/ice_dcf.c >>>> +++ b/drivers/net/ice/ice_dcf.c >>>> @@ -536,7 +536,7 @@ ice_dcf_handle_vsi_update_event(struct ice_dcf_hw = *hw) >>>> =09rte_intr_disable(&pci_dev->intr_handle); >>>> =09ice_dcf_disable_irq0(hw); >>>> >>>> -=09if (ice_dcf_get_vf_resource(hw) || ice_dcf_get_vf_vsi_map(hw)) >>>> +=09if (ice_dcf_get_vf_resource(hw) || ice_dcf_get_vf_vsi_map(hw) < 0) >>>> =09=09err =3D -1; >>>> >>>> =09rte_intr_enable(&pci_dev->intr_handle); >>>> diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dc= f_parent.c >>>> index d4b4ede..bdfc7d4 100644 >>>> --- a/drivers/net/ice/ice_dcf_parent.c >>>> +++ b/drivers/net/ice/ice_dcf_parent.c >>>> @@ -45,7 +45,7 @@ ice_dcf_update_vsi_ctx(struct ice_hw *hw, uint16_t v= si_handle, >>>> =09=09=09VIRTCHNL_DCF_VF_VSI_ID_S; >>>> >>>> =09=09/* Redirect rules if vsi mapping table changes. */ >>>> -=09=09if (!first_update && vsi_ctx->vsi_num !=3D new_vsi_num) { >>>> +=09=09if (!first_update) { >>>> =09=09=09struct ice_flow_redirect rd; >>>> >>>> =09=09=09memset(&rd, 0, sizeof(struct ice_flow_redirect)); >>>> --=20 >>>> 2.7.4 >>>> >>> >>> Applied to dpdk-next-net-intel, Thanks. >>> >> >=20