From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91D77A09E4; Sat, 5 Dec 2020 01:46:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9D7C2C6E; Sat, 5 Dec 2020 01:46:48 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9BA4D2C58 for ; Sat, 5 Dec 2020 01:46:46 +0100 (CET) IronPort-SDR: T05mYoliOipF1ImkBgkAS3NlE9WUkZ+UUWYbJVDHQ2RYjDM3Ik2TmsxRrxcAs6ERuVvqGdUtPU IoVU4fDZ6tZg== X-IronPort-AV: E=McAfee;i="6000,8403,9825"; a="161239820" X-IronPort-AV: E=Sophos;i="5.78,394,1599548400"; d="scan'208";a="161239820" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2020 16:46:43 -0800 IronPort-SDR: L+e66x331Sdmq5N1jev18ZlT/5TdEAr0JHFH2t/vw+NshzoE5XtKXvkvD4jvcMXsrv5bOORGzA ILfIBMQo/X3A== X-IronPort-AV: E=Sophos;i="5.78,394,1599548400"; d="scan'208";a="551155918" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.209.62.157]) ([10.209.62.157]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2020 16:46:43 -0800 To: Nick Connolly , Bruce Richardson Cc: dev@dpdk.org, David Marchand , Dmitry Kozlyuk References: <20201127113623.26707-1-nick.connolly@mayadata.io> <20201129160024.879-1-nick.connolly@mayadata.io> From: "Kadam, Pallavi" Message-ID: Date: Fri, 4 Dec 2020 16:46:42 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201129160024.879-1-nick.connolly@mayadata.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2] windows: build warnings with clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Nick, Thanks for this patch. Could not see the deprecated warnings anymore. On 11/29/2020 8:00 AM, Nick Connolly wrote: > Microsoft CRT defines Windows-specific secure alternatives to > standard library functions and triggers warnings when "insecure" > functions are used [1]. However, calling code already has all > necessary checks around those functions, so these warnings are not > useful for DPDK. MinGW provides its own CRT without this issue. > > [1]: > https://docs.microsoft.com/en-us/cpp/c-runtime-library/security-features-in-the-crt?view=msvc-160 > > Disable this by defining -D_CRT_SECURE_NO_WARNINGS. > > Signed-off-by: Nick Connolly > --- Acked-by: Pallavi Kadam