From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C72F9A09FF; Thu, 24 Dec 2020 10:33:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7079CA1A; Thu, 24 Dec 2020 10:33:13 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 56F63CA04; Thu, 24 Dec 2020 10:33:10 +0100 (CET) IronPort-SDR: sLpkIzB+CuneVgKP0Z7kfGB+F8IVqpXteQS5pC+7M4V4d4xkHi0igUX+FMcDmT0hYKNVQhTVrL Eu26xLOE/GhQ== X-IronPort-AV: E=McAfee;i="6000,8403,9844"; a="155338215" X-IronPort-AV: E=Sophos;i="5.78,444,1599548400"; d="scan'208";a="155338215" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2020 01:33:07 -0800 IronPort-SDR: Wqa7nKT10SFmjPkY0l9WyCwNSGgG+qYQMpoJDn/gbvNwe3TrrTearnaoS8BXhqbTt5N34X2ors aAQ2aHjSgmSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,444,1599548400"; d="scan'208";a="565906359" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga005.fm.intel.com with ESMTP; 24 Dec 2020 01:33:07 -0800 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 24 Dec 2020 01:33:06 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 24 Dec 2020 17:33:04 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Thu, 24 Dec 2020 17:33:04 +0800 From: "Huang, ZhiminX" To: "Zhang, AlvinX" , "Xing, Beilei" , "Xu, Ting" CC: "dev@dpdk.org" , "Zhang, AlvinX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration Thread-Index: AQHW2OyzzfgByPCGCk6nWMD4Yl+iFaoF/PHA Date: Thu, 24 Dec 2020 09:33:04 +0000 Message-ID: References: <20201223052936.7200-1-alvinx.zhang@intel.com> In-Reply-To: <20201223052936.7200-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Huang, ZhiminX Regards, HuangZhiMin > -----Original Message----- > From: dev On Behalf Of Zhang,Alvin > Sent: Wednesday, December 23, 2020 1:30 PM > To: Xing, Beilei ; Xu, Ting > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration >=20 > From: Alvin Zhang >=20 > Check if there are enough queue pairs currently allocated, and if not, re= quest > PF to allocate them. >=20 > Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more queue= s") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alvin Zhang > --- > drivers/net/iavf/iavf_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c index > 7e3c26a..f015121 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -372,8 +372,10 @@ struct rte_iavf_xstats_name_off { > } else { > /* Check if large VF is already enabled. If so, disable and > * release redundant queue resource. > + * Or check if enough queue pairs. If not, request them from PF. > */ > - if (vf->lv_enabled) { > + if (vf->lv_enabled || > + num_queue_pairs > vf->vsi_res->num_queue_pairs) { > ret =3D iavf_queues_req_reset(dev, num_queue_pairs); > if (ret) > return ret; > -- > 1.8.3.1