From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Takeshi Yoshimura <t.yoshimura8869@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vfio: fix workaround of BAR0 mapping
Date: Thu, 12 Jul 2018 10:10:56 +0100 [thread overview]
Message-ID: <bc10e52d-1d7e-860a-b683-c6d08d1b8304@intel.com> (raw)
In-Reply-To: <20180712030833.4887-1-t.yoshimura8869@gmail.com>
On 12-Jul-18 4:08 AM, Takeshi Yoshimura wrote:
> The workaround of BAR0 mapping does not work if BAR0 area is smaller
> than page size (64KB in ppc). In addition, we no longer need the
> workaround in recent Linux because VFIO allows MSIX mapping (*).
> This fix is just to skip the workaround if BAR0 is smarller than a page.
>
> (*): "vfio-pci: Allow mapping MSIX BAR",
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
> commit/id=a32295c612c57990d17fb0f41e7134394b2f35f6
>
> Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables")
>
> Signed-off-by: Takeshi Yoshimura <t.yoshimura8869@gmail.com>
> ---
Minimum support kernel version in DPDK is 3.2, we cannot rely on
functionality provided by the recent kernel versions.
It would be better if you modified the check at line 350 instead (or
added a new check, specifically testing for whether BAR size is less
than page size).
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-07-12 9:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 2:44 [dpdk-dev] [PATCH] " Takeshi Yoshimura
2018-07-12 3:08 ` [dpdk-dev] [PATCH v2] " Takeshi Yoshimura
2018-07-12 9:10 ` Burakov, Anatoly [this message]
2018-07-13 10:11 ` [dpdk-dev] [PATCH v3] " Takeshi Yoshimura
2018-07-13 11:00 ` Burakov, Anatoly
2018-07-13 11:08 ` Burakov, Anatoly
2018-07-17 8:21 ` Takeshi Yoshimura
2018-07-17 8:22 ` [dpdk-dev] [PATCH v4] " Takeshi Yoshimura
2018-07-17 10:08 ` Burakov, Anatoly
2018-07-20 8:13 ` [dpdk-dev] [PATCH v5] vfio: fix workaround of BAR mapping Takeshi Yoshimura
2018-07-26 9:35 ` Thomas Monjalon
2018-07-29 8:44 ` Jerin Jacob
2018-07-30 8:51 ` Burakov, Anatoly
2018-07-30 10:03 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc10e52d-1d7e-860a-b683-c6d08d1b8304@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=t.yoshimura8869@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).